@object-ui/plugin-list 0.5.0 → 2.0.0

package/src/ListView.tsx

@@ -7,12 +7,12 @@
  */
 
 import * as React from 'react';
-import { cn, Button, Input, Popover, PopoverContent, PopoverTrigger, FilterBuilder, SortBuilder } from '@object-ui/components';
+import { cn, Button, Input, Popover, PopoverContent, PopoverTrigger, FilterBuilder, SortBuilder, NavigationOverlay } from '@object-ui/components';
 import type { SortItem } from '@object-ui/components';
-import { Search, SlidersHorizontal, ArrowUpDown, X } from 'lucide-react';
+import { Search, SlidersHorizontal, ArrowUpDown, X, EyeOff, Group, Paintbrush, Ruler } from 'lucide-react';
 import type { FilterGroup } from '@object-ui/components';
 import { ViewSwitcher, ViewType } from './ViewSwitcher';
-import { SchemaRenderer } from '@object-ui/react';
+import { SchemaRenderer, useNavigationOverlay } from '@object-ui/react';
 import type { ListViewSchema } from '@object-ui/types';
 
 export interface ListViewProps {
@@ -22,6 +22,10 @@ export interface ListViewProps {
   onFilterChange?: (filters: any) => void;
   onSortChange?: (sort: any) => void;
   onSearchChange?: (search: string) => void;
+  /** Callback when a row/item is clicked (overrides NavigationConfig) */
+  onRowClick?: (record: Record<string, unknown>) => void;
+  /** Show view type switcher (Grid/Kanban/etc). Default: false (view type is fixed) */
+  showViewSwitcher?: boolean;
   [key: string]: any;
 }
 
@@ -65,6 +69,8 @@ export const ListView: React.FC<ListViewProps> = ({
   onFilterChange,
   onSortChange,
   onSearchChange,
+  onRowClick,
+  showViewSwitcher = false,
   ...props
 }) => {
   // Kernel level default: Ensure viewType is always defined (default to 'grid')
@@ -236,7 +242,15 @@ export const ListView: React.FC<ListViewProps> = ({
     return views;
   }, [schema.options, schema.viewType]);
 
-  // Load saved view preference
+  // Sync view from props
+  React.useEffect(() => {
+     if (schema.viewType) {
+        setCurrentView(schema.viewType as ViewType);
+     }
+  }, [schema.viewType]);
+
+  // Load saved view preference (DISABLED: interfering with schema-defined views)
+  /*
   React.useEffect(() => {
     try {
       const savedView = localStorage.getItem(storageKey);
@@ -247,6 +261,7 @@ export const ListView: React.FC<ListViewProps> = ({
       console.warn('Failed to load view preference from localStorage:', error);
     }
   }, [storageKey, availableViews]);
+  */
 
   const handleViewChange = React.useCallback((view: ViewType) => {
     setCurrentView(view);
@@ -263,6 +278,14 @@ export const ListView: React.FC<ListViewProps> = ({
     onSearchChange?.(value);
   }, [onSearchChange]);
 
+  // --- NavigationConfig support ---
+  const navigation = useNavigationOverlay({
+    navigation: schema.navigation,
+    objectName: schema.objectName,
+    onNavigate: schema.onNavigate,
+    onRowClick,
+  });
+
   // Generate the appropriate view component schema
   const viewComponentSchema = React.useMemo(() => {
     const baseProps = {
@@ -273,6 +296,8 @@ export const ListView: React.FC<ListViewProps> = ({
       className: "h-full w-full",
       // Disable internal controls that clash with ListView toolbar
       showSearch: false,
+      // Pass navigation click handler to child views
+      onRowClick: navigation.handleClick,
     };
 
     switch (currentView) {
@@ -365,124 +390,181 @@ export const ListView: React.FC<ListViewProps> = ({
     }));
   }, [objectDef, schema.fields]);
 
+  const [searchExpanded, setSearchExpanded] = React.useState(false);
+
   return (
     <div className={cn('flex flex-col h-full bg-background', className)}>
-      {/* Airtable-style Toolbar */}
-      <div className="border-b px-4 py-2 flex items-center justify-between gap-4 bg-background/95 backdrop-blur supports-[backdrop-filter]:bg-background/60">
-        <div className="flex items-center gap-2 flex-1 overflow-hidden">
-          {/* View Switcher on the Left */}
-          <div className="flex items-center pr-2 border-r mr-2">
-            <ViewSwitcher
-              currentView={currentView}
-              availableViews={availableViews}
-              onViewChange={handleViewChange}
-            />
-          </div>
-
-          {/* Action Tools */}
-          <div className="flex items-center gap-1">
-             <Popover open={showFilters} onOpenChange={setShowFilters}>
-               <PopoverTrigger asChild>
-                  <Button
-                    variant={hasFilters ? "secondary" : "ghost"}
-                    size="sm"
-                    className={cn(
-                      "h-8 px-2 lg:px-3 text-muted-foreground hover:text-primary",
-                      hasFilters && "text-primary bg-secondary/50"
-                    )}
-                  >
-                    <SlidersHorizontal className="h-4 w-4 mr-2" />
-                    <span className="hidden lg:inline">Filter</span>
-                    {hasFilters && (
-                      <span className="ml-1.5 flex h-4 w-4 items-center justify-center rounded-full bg-primary/10 text-[10px] font-medium text-primary">
-                        {currentFilters.conditions?.length || 0}
-                      </span>
-                    )}
-                  </Button>
-               </PopoverTrigger>
-               <PopoverContent align="start" className="w-[600px] p-4">
-                  <div className="space-y-4">
-                    <div className="flex items-center justify-between border-b pb-2">
-                      <h4 className="font-medium text-sm">Filter Records</h4>
-                    </div>
-                    <FilterBuilder
-                      fields={filterFields}
-                      value={currentFilters}
-                      onChange={(newFilters) => {
-                        console.log('Filter Changed:', newFilters);
-                        setCurrentFilters(newFilters);
-                        // Convert FilterBuilder format to OData $filter string if needed
-                        // For now we just update state and notify listener
-                        // In a real app, this would likely build an OData string
-                        if (onFilterChange) onFilterChange(newFilters);
-                      }}
-                    />
-                  </div>
-               </PopoverContent>
-             </Popover>
-            
-             <Popover open={showSort} onOpenChange={setShowSort}>
-               <PopoverTrigger asChild>
-                  <Button
-                    variant={currentSort.length > 0 ? "secondary" : "ghost"}
-                    size="sm"
-                    className={cn(
-                      "h-8 px-2 lg:px-3 text-muted-foreground hover:text-primary",
-                      currentSort.length > 0 && "text-primary bg-secondary/50"
-                    )}
-                  >
-                    <ArrowUpDown className="h-4 w-4 mr-2" />
-                    <span className="hidden lg:inline">Sort</span>
-                     {currentSort.length > 0 && (
-                      <span className="ml-1.5 flex h-4 w-4 items-center justify-center rounded-full bg-primary/10 text-[10px] font-medium text-primary">
-                        {currentSort.length}
-                      </span>
-                    )}
-                  </Button>
-               </PopoverTrigger>
-               <PopoverContent align="start" className="w-[600px] p-4">
-                  <div className="space-y-4">
-                    <div className="flex items-center justify-between border-b pb-2">
-                       <h4 className="font-medium text-sm">Sort Records</h4>
-                    </div>
-                    <SortBuilder
-                      fields={filterFields}
-                      value={currentSort}
-                      onChange={(newSort) => {
-                        console.log('Sort Changed:', newSort);
-                        setCurrentSort(newSort);
-                        if (onSortChange) onSortChange(newSort);
-                      }}
-                    />
-                  </div>
-               </PopoverContent>
-             </Popover>
-            
-            {/* Future: Group, Color, Height */}
-          </div>
+      {/* Airtable-style Toolbar — Row 1: View tabs */}
+      {showViewSwitcher && (
+        <div className="border-b px-4 py-1 flex items-center bg-background">
+          <ViewSwitcher
+            currentView={currentView}
+            availableViews={availableViews}
+            onViewChange={handleViewChange}
+          />
         </div>
+      )}
 
-        {/* Right Actions: Search + New */}
-        <div className="flex items-center gap-2">
-             <div className="relative w-40 lg:w-64 transition-all">
-                <Search className="absolute left-2 top-1/2 -translate-y-1/2 h-4 w-4 text-muted-foreground" />
-                <Input
-                  placeholder="Find..."
-                  value={searchTerm}
-                  onChange={(e) => handleSearchChange(e.target.value)}
-                  className="pl-8 h-8 text-sm bg-muted/50 border-transparent hover:bg-muted focus:bg-background focus:border-input transition-colors"
+      {/* Airtable-style Toolbar — Row 2: Tool buttons */}
+      <div className="border-b px-4 py-1 flex items-center justify-between gap-2 bg-background">
+        <div className="flex items-center gap-0.5 overflow-hidden">
+          {/* Hide Fields */}
+          <Button
+            variant="ghost"
+            size="sm"
+            className="h-7 px-2 text-muted-foreground hover:text-primary text-xs"
+            disabled
+          >
+            <EyeOff className="h-3.5 w-3.5 mr-1.5" />
+            <span className="hidden sm:inline">Hide fields</span>
+          </Button>
+
+          {/* Filter */}
+          <Popover open={showFilters} onOpenChange={setShowFilters}>
+            <PopoverTrigger asChild>
+              <Button
+                variant="ghost"
+                size="sm"
+                className={cn(
+                  "h-7 px-2 text-muted-foreground hover:text-primary text-xs",
+                  hasFilters && "text-primary"
+                )}
+              >
+                <SlidersHorizontal className="h-3.5 w-3.5 mr-1.5" />
+                <span className="hidden sm:inline">Filter</span>
+                {hasFilters && (
+                  <span className="ml-1 flex h-4 min-w-[16px] items-center justify-center rounded-full bg-primary/10 text-[10px] font-medium text-primary">
+                    {currentFilters.conditions?.length || 0}
+                  </span>
+                )}
+              </Button>
+            </PopoverTrigger>
+            <PopoverContent align="start" className="w-[600px] p-4">
+              <div className="space-y-4">
+                <div className="flex items-center justify-between border-b pb-2">
+                  <h4 className="font-medium text-sm">Filter Records</h4>
+                </div>
+                <FilterBuilder
+                  fields={filterFields}
+                  value={currentFilters}
+                  onChange={(newFilters) => {
+                    setCurrentFilters(newFilters);
+                    if (onFilterChange) onFilterChange(newFilters);
+                  }}
                 />
-                 {searchTerm && (
-                  <Button
-                    variant="ghost"
-                    size="sm"
-                    className="absolute right-1 top-1/2 -translate-y-1/2 h-6 w-6 p-0 hover:bg-muted-foreground/20"
-                    onClick={() => handleSearchChange('')}
-                  >
-                    <X className="h-3 w-3" />
-                  </Button>
+              </div>
+            </PopoverContent>
+          </Popover>
+
+          {/* Group */}
+          <Button
+            variant="ghost"
+            size="sm"
+            className="h-7 px-2 text-muted-foreground hover:text-primary text-xs"
+            disabled
+          >
+            <Group className="h-3.5 w-3.5 mr-1.5" />
+            <span className="hidden sm:inline">Group</span>
+          </Button>
+
+          {/* Sort */}
+          <Popover open={showSort} onOpenChange={setShowSort}>
+            <PopoverTrigger asChild>
+              <Button
+                variant="ghost"
+                size="sm"
+                className={cn(
+                  "h-7 px-2 text-muted-foreground hover:text-primary text-xs",
+                  currentSort.length > 0 && "text-primary"
+                )}
+              >
+                <ArrowUpDown className="h-3.5 w-3.5 mr-1.5" />
+                <span className="hidden sm:inline">Sort</span>
+                {currentSort.length > 0 && (
+                  <span className="ml-1 flex h-4 min-w-[16px] items-center justify-center rounded-full bg-primary/10 text-[10px] font-medium text-primary">
+                    {currentSort.length}
+                  </span>
                 )}
-             </div>
+              </Button>
+            </PopoverTrigger>
+            <PopoverContent align="start" className="w-[600px] p-4">
+              <div className="space-y-4">
+                <div className="flex items-center justify-between border-b pb-2">
+                  <h4 className="font-medium text-sm">Sort Records</h4>
+                </div>
+                <SortBuilder
+                  fields={filterFields}
+                  value={currentSort}
+                  onChange={(newSort) => {
+                    setCurrentSort(newSort);
+                    if (onSortChange) onSortChange(newSort);
+                  }}
+                />
+              </div>
+            </PopoverContent>
+          </Popover>
+
+          {/* Color */}
+          <Button
+            variant="ghost"
+            size="sm"
+            className="h-7 px-2 text-muted-foreground hover:text-primary text-xs"
+            disabled
+          >
+            <Paintbrush className="h-3.5 w-3.5 mr-1.5" />
+            <span className="hidden sm:inline">Color</span>
+          </Button>
+
+          {/* Row Height */}
+          <Button
+            variant="ghost"
+            size="sm"
+            className="h-7 px-2 text-muted-foreground hover:text-primary text-xs hidden lg:flex"
+            disabled
+          >
+            <Ruler className="h-3.5 w-3.5 mr-1.5" />
+            <span className="hidden sm:inline">Row height</span>
+          </Button>
+        </div>
+
+        {/* Right: Search */}
+        <div className="flex items-center gap-1">
+          {searchExpanded ? (
+            <div className="relative w-48 lg:w-64">
+              <Search className="absolute left-2 top-1/2 -translate-y-1/2 h-3.5 w-3.5 text-muted-foreground" />
+              <Input
+                placeholder="Find..."
+                value={searchTerm}
+                onChange={(e) => handleSearchChange(e.target.value)}
+                className="pl-7 h-7 text-xs bg-muted/50 border-transparent hover:bg-muted focus:bg-background focus:border-input transition-colors"
+                autoFocus
+                onBlur={() => {
+                  if (!searchTerm) setSearchExpanded(false);
+                }}
+              />
+              <Button
+                variant="ghost"
+                size="sm"
+                className="absolute right-0.5 top-1/2 -translate-y-1/2 h-5 w-5 p-0 hover:bg-muted-foreground/20"
+                onClick={() => {
+                  handleSearchChange('');
+                  setSearchExpanded(false);
+                }}
+              >
+                <X className="h-3 w-3" />
+              </Button>
+            </div>
+          ) : (
+            <Button
+              variant="ghost"
+              size="sm"
+              className="h-7 px-2 text-muted-foreground hover:text-primary text-xs"
+              onClick={() => setSearchExpanded(true)}
+            >
+              <Search className="h-3.5 w-3.5 mr-1.5" />
+              <span className="hidden sm:inline">Search</span>
+            </Button>
+          )}
         </div>
       </div>
 
@@ -498,6 +580,33 @@ export const ListView: React.FC<ListViewProps> = ({
           loading={loading}
         />
       </div>
+
+      {/* Navigation Overlay (drawer/modal/popover) */}
+      {navigation.isOverlay && (
+        <NavigationOverlay
+          {...navigation}
+          title={
+            schema.label
+              ? `${schema.label} Detail`
+              : schema.objectName
+                ? `${schema.objectName.charAt(0).toUpperCase() + schema.objectName.slice(1)} Detail`
+                : 'Record Detail'
+          }
+        >
+          {(record) => (
+            <div className="space-y-3">
+              {Object.entries(record).map(([key, value]) => (
+                <div key={key} className="flex flex-col">
+                  <span className="text-xs font-medium text-muted-foreground uppercase tracking-wide">
+                    {key.replace(/_/g, ' ')}
+                  </span>
+                  <span className="text-sm">{String(value ?? '—')}</span>
+                </div>
+              ))}
+            </div>
+          )}
+        </NavigationOverlay>
+      )}
     </div>
   );
 };

package/src/__tests__/ListView.test.tsx

@@ -66,7 +66,7 @@ describe('ListView', () => {
     expect(container).toBeTruthy();
   });
 
-  it('should render search input', () => {
+  it('should render search button', () => {
     const schema: ListViewSchema = {
       type: 'list-view',
       objectName: 'contacts',
@@ -75,11 +75,11 @@ describe('ListView', () => {
     };
 
     renderWithProvider(<ListView schema={schema} />);
-    const searchInput = screen.getByPlaceholderText(/find/i);
-    expect(searchInput).toBeInTheDocument();
+    const searchButton = screen.getByRole('button', { name: /search/i });
+    expect(searchButton).toBeInTheDocument();
   });
 
-  it('should call onSearchChange when search input changes', () => {
+  it('should expand search and call onSearchChange when search input changes', () => {
     const onSearchChange = vi.fn();
     const schema: ListViewSchema = {
       type: 'list-view',
@@ -89,8 +89,12 @@ describe('ListView', () => {
     };
 
     renderWithProvider(<ListView schema={schema} onSearchChange={onSearchChange} />);
-    const searchInput = screen.getByPlaceholderText(/find/i);
     
+    // Click search button to expand
+    const searchButton = screen.getByRole('button', { name: /search/i });
+    fireEvent.click(searchButton);
+    
+    const searchInput = screen.getByPlaceholderText(/find/i);
     fireEvent.change(searchInput, { target: { value: 'test' } });
     expect(onSearchChange).toHaveBeenCalledWith('test');
   });
@@ -108,7 +112,7 @@ describe('ListView', () => {
       },
     };
 
-    renderWithProvider(<ListView schema={schema} />);
+    renderWithProvider(<ListView schema={schema} showViewSwitcher={true} />);
     
     // Find kanban view button and click it
     // ViewSwitcher uses buttons with aria-label
@@ -196,13 +200,18 @@ describe('ListView', () => {
     };
 
     renderWithProvider(<ListView schema={schema} />);
+    
+    // Click search button to expand search input
+    const searchButton = screen.getByRole('button', { name: /search/i });
+    fireEvent.click(searchButton);
+    
     const searchInput = screen.getByPlaceholderText(/find/i) as HTMLInputElement;
     
     // Type in search
     fireEvent.change(searchInput, { target: { value: 'test' } });
     expect(searchInput.value).toBe('test');
     
-    // Find and click clear button
+    // Find and click clear button (the X button inside the expanded search)
     const buttons = screen.getAllByRole('button');
     const clearButton = buttons.find(btn => 
       btn.querySelector('svg') !== null && searchInput.value !== ''

package/src/__tests__/ListViewPersistence.test.tsx

@@ -56,7 +56,7 @@ describe('ListView Persistence', () => {
       },
     };
 
-    renderWithProvider(<ListView schema={schema} />);
+    renderWithProvider(<ListView schema={schema} showViewSwitcher={true} />);
     
     // Simulate changing to kanban view
     const kanbanButton = screen.getByLabelText('Kanban'); 
@@ -89,7 +89,7 @@ describe('ListView Persistence', () => {
         },
      };
 
-     renderWithProvider(<ListView schema={viewB_Schema} />);
+     renderWithProvider(<ListView schema={viewB_Schema} showViewSwitcher={true} />);
      
      // Should use the schema default 'kanban' (since no storage exists for THIS view id)
      // It should NOT use 'grid' from the global/default view.
@@ -117,10 +117,13 @@ describe('ListView Persistence', () => {
           },
       };
       
-      renderWithProvider(<ListView schema={schema} />);
+      renderWithProvider(<ListView schema={schema} showViewSwitcher={true} />);
       
-      // Should respect storage ('kanban') over schema ('grid')
+      // Should respect schema ('grid') because storage persistence is currently disabled
       const kanbanButton = screen.getByLabelText('Kanban');
-      expect(kanbanButton.getAttribute('data-state')).toBe('on');
+      expect(kanbanButton.getAttribute('data-state')).toBe('off');
+
+      const gridButton = screen.getByLabelText('Grid');
+      expect(gridButton.getAttribute('data-state')).toBe('on');
   });
 });

package/src/index.tsx

@@ -45,3 +45,25 @@ ComponentRegistry.register('list-view', ListView, {
     options: {},
   }
 });
+
+// Alias for generic view
+ComponentRegistry.register('list', ListView, {
+  namespace: 'view',
+  category: 'view',
+  label: 'List',
+  icon: 'LayoutList',
+  inputs: [
+    { name: 'objectName', type: 'string', label: 'Object Name', required: true },
+    { name: 'viewType', type: 'enum', label: 'Default View', enum: [
+      { label: 'Grid', value: 'grid' },
+      { label: 'List', value: 'list' },
+      { label: 'Kanban', value: 'kanban' },
+      { label: 'Calendar', value: 'calendar' },
+      { label: 'Chart', value: 'chart' }
+    ], defaultValue: 'grid' },
+    { name: 'fields', type: 'array', label: 'Fields' },
+    { name: 'filters', type: 'array', label: 'Filters' },
+    { name: 'sort', type: 'array', label: 'Sort' },
+    { name: 'options', type: 'object', label: 'View Options' },
+  ]
+});