@object-ui/fields 17.3.0 → 17.6.0

package/src/__tests__/spec-symbol-batch7.test.ts

@@ -1,126 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-/**
- * `@object-ui/fields` ↔ `@objectstack/spec` symbol-collision guards
- * (objectui#3161, objectstack#4115 ledger batch 7).
- *
- * Two symbols, two different verdicts:
- *
- *  - `isFileIdToken` was a character-for-character copy of the spec's function
- *    under the spec's own name. It is a re-export now, and the gate below is
- *    REFERENCE IDENTITY — not behaviour. A faithful copy passes every behaviour
- *    test ever written for it (objectui#3003, re-proved on
- *    `isAggregatedViewContainer` in objectui#3169), so `toBe` is the only
- *    assertion that can tell a re-export from a fork.
- *
- *  - `FieldWidgetProps` is now `FieldWidgetComponentProps`. The spec owns that
- *    name for the DECLARED widget-plugin props contract; this package's is the
- *    React interface its widgets implement. The pins record what still makes
- *    re-exporting impossible (`field` is the far richer `FieldMetadata` here)
- *    and, since objectui#3222, what no longer does: the validation slot is the
- *    spec's `error` on both sides.
- *
- * The other direction — "the spec must not start owning the NEW names" — is not
- * asserted here because `scripts/check-spec-symbol-derivation.mjs` already
- * answers it on every CI run, for every name in the package rather than the
- * handful a test would remember to list.
- */
-
-import { describe, it, expect } from 'vitest';
-import { isFileIdToken as specIsFileIdToken } from '@objectstack/spec/data';
-import type { FieldWidgetProps as SpecFieldWidgetProps } from '@objectstack/spec/ui';
-
-import { isFileIdToken, fileIdOf } from '../widgets/file-value';
-import type { FieldWidgetComponentProps } from '../widgets/types';
-
-describe('isFileIdToken IS the spec function', () => {
-  it('is the same function object, not an equivalent one', () => {
-    // The whole point. Every value/behaviour assertion below this line would
-    // also pass against a re-forked copy; this one would not.
-    expect(isFileIdToken).toBe(specIsFileIdToken);
-  });
-
-  it('is the arbiter the rest of the module routes through', () => {
-    // `fileIdOf` must keep agreeing with the shared predicate, so a future
-    // "small local tweak" to the id shape cannot be reintroduced one caller at
-    // a time.
-    for (const value of ['abc123', 'AbC-_9', 'x'.repeat(64)]) {
-      expect(specIsFileIdToken(value)).toBe(true);
-      expect(fileIdOf(value)).toBe(value);
-    }
-    for (const value of ['https://example.com/f.png', '/api/v1/storage/files/1', 'a.b', 'x'.repeat(65)]) {
-      expect(specIsFileIdToken(value)).toBe(false);
-      expect(fileIdOf(value)).toBeUndefined();
-    }
-  });
-});
-
-/* -------------------------------------------------------------------------- */
-/* Compile-time pins. A violation is a `tsc` error, not a runtime failure.     */
-/* This package's tsconfig.json includes its tests, so `type-check` compiles   */
-/* them (scripts/check-type-check-coverage.mjs keeps that true).              */
-/* -------------------------------------------------------------------------- */
-
-type Assert<T extends true> = T;
-type Equal<A, B> = (<T>() => T extends A ? 1 : 2) extends <T>() => T extends B ? 1 : 2 ? true : false;
-type Extends<A, B> = [A] extends [B] ? true : false;
-type IsAny<T> = 0 extends 1 & T ? true : false;
-type HasKey<T, K extends string> = K extends keyof T ? true : false;
-
-describe('FieldWidgetComponentProps is the RENDERED layer of the spec contract', () => {
-  it('is pinned at compile time', () => {
-    // The import above is itself half the tripwire: the day the spec stops
-    // exporting `FieldWidgetProps`, this file stops compiling and the rename's
-    // reason is up for re-triage (the plain name could come back).
-    type _SpecIsReal = Assert<Equal<IsAny<SpecFieldWidgetProps>, false>>;
-
-    // The validation-message slot no longer diverges. objectui#3161 could only
-    // RECORD that the declared contract called it `error` while every widget
-    // here read `errorMessage`; objectui#3222 resolved it in the direction the
-    // contract points — this package adopted `error`, and the form renderer
-    // started producing it, so the name and the delivery landed together.
-    // Both sides are pinned: the spec still owns the name, and this package
-    // still spells it the same way.
-    type _SpecNamesItError = Assert<HasKey<SpecFieldWidgetProps, 'error'>>;
-    type _LocalNamesItErrorToo = Assert<HasKey<FieldWidgetComponentProps, 'error'>>;
-    type _SameOptionalStringSlot = Assert<
-      Equal<FieldWidgetComponentProps['error'], SpecFieldWidgetProps['error']>
-    >;
-    // The old name is gone, not kept as an alias. An alias would be exactly the
-    // lenient second dialect AGENTS.md #0.1 forbids — and the reason a missed
-    // call site would have gone quiet again.
-    type _OldNameRetired = Assert<Equal<HasKey<FieldWidgetComponentProps, 'errorMessage'>, false>>;
-
-    // …and the reason nobody noticed used to sit right here: three pins
-    // asserting that `[key: string]: any` was still present, and that
-    // `props.required` / `props.error` therefore read as `any`. objectui#3221
-    // removed that index signature, so those pins have gone red on purpose and
-    // are gone with it. What replaces them is the inverse claim — the type is
-    // now CLOSED, so a key the spec declares and this one does not can finally
-    // be reported as missing. That is what made objectui#3222's rename
-    // decidable by the compiler instead of by a symbol guard.
-    type _NoStringIndexSignature = Assert<Equal<Extends<string, keyof FieldWidgetComponentProps>, false>>;
-    // `required` is the one key that stayed behind, and deliberately so
-    // (objectui#3222): the required marker has a single author — the form
-    // renderer's `<FormLabel>` — and lowering the flag into widget props gives
-    // it a second, i.e. the double-display failure that also keeps the
-    // validation TEXT out of the widget. The a11y state a widget could
-    // legitimately carry is `aria-required`, and `AriaAttributes` already
-    // supplies that key with no contract change at all.
-    type _RequiredIsAbsent = Assert<Equal<HasKey<FieldWidgetComponentProps, 'required'>, false>>;
-
-    // `data-*` stays open (it is open in HTML too), but as a template-literal
-    // key — the distinction that keeps `keyof` finite above. A pin, because
-    // widening it back to `[key: string]` would silently restore the defect
-    // while every assertion here still read as "closed".
-    type _DataAttributesStayOpen = Assert<Extends<'data-testid', keyof FieldWidgetComponentProps>>;
-
-    expect(true).toBe(true);
-  });
-});

package/src/__tests__/validation-feedback.test.tsx

@@ -1,361 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-/**
- * P3.2 Field Widget Polish - Validation Feedback
- *
- * Tests that field widgets consistently handle validation feedback:
- * `error` prop, aria-invalid attribute, and disabled states.
- *
- * The slot is `error` — the name `@objectstack/spec/ui`'s
- * `FieldWidgetPropsSchema` gives it — since objectui#3222. These are the
- * CONSUMER half only: they prove a widget handed a message marks its control
- * invalid. That was true before #3222 too, under the name `errorMessage`, and
- * it did not help anyone, because no host ever passed the prop. The PRODUCER
- * half is `form-error-delivery.test.tsx` in `@object-ui/components` plus
- * `widget-aria-invalid-e2e.test.tsx` next to this file; a rename alone would
- * have swapped one dead key for another.
- */
-
-import { describe, it, expect, vi } from 'vitest';
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import '@testing-library/jest-dom';
-
-import { TextField } from '../widgets/TextField';
-import { NumberField } from '../widgets/NumberField';
-import { EmailField } from '../widgets/EmailField';
-import { UrlField } from '../widgets/UrlField';
-import { PhoneField } from '../widgets/PhoneField';
-import { TextAreaField } from '../widgets/TextAreaField';
-import { CurrencyField } from '../widgets/CurrencyField';
-import { BooleanField } from '../widgets/BooleanField';
-import { SelectField } from '../widgets/SelectField';
-
-const noop = vi.fn();
-
-describe('P3.2 Validation Feedback', () => {
-  // ---------------------------------------------------------------
-  // aria-invalid on `error`
-  // ---------------------------------------------------------------
-  describe('aria-invalid attribute', () => {
-    it('EmailField sets aria-invalid when `error` provided', () => {
-      render(
-        <EmailField
-          value=""
-          onChange={noop}
-          field={{ type: 'email' } as any}
-          error="Invalid email"
-        />
-      );
-      const input = screen.getByRole('textbox');
-      expect(input).toHaveAttribute('aria-invalid', 'true');
-    });
-
-    it('EmailField does not set aria-invalid without `error`', () => {
-      render(
-        <EmailField
-          value=""
-          onChange={noop}
-          field={{ type: 'email' } as any}
-        />
-      );
-      const input = screen.getByRole('textbox');
-      expect(input).not.toHaveAttribute('aria-invalid', 'true');
-    });
-
-    it('UrlField sets aria-invalid when `error` provided', () => {
-      render(
-        <UrlField
-          value=""
-          onChange={noop}
-          field={{ type: 'url' } as any}
-          error="Invalid URL"
-        />
-      );
-      const input = screen.getByDisplayValue('');
-      expect(input).toHaveAttribute('aria-invalid', 'true');
-    });
-
-    it('PhoneField sets aria-invalid when `error` provided', () => {
-      render(
-        <PhoneField
-          value=""
-          onChange={noop}
-          field={{ type: 'phone' } as any}
-          error="Invalid phone"
-        />
-      );
-      const input = screen.getByRole('textbox');
-      expect(input).toHaveAttribute('aria-invalid', 'true');
-    });
-
-    it('TextAreaField sets aria-invalid when `error` provided', () => {
-      render(
-        <TextAreaField
-          value=""
-          onChange={noop}
-          field={{ type: 'textarea' } as any}
-          error="Required"
-        />
-      );
-      const textarea = screen.getByRole('textbox');
-      expect(textarea).toHaveAttribute('aria-invalid', 'true');
-    });
-
-    it('CurrencyField sets aria-invalid when `error` provided', () => {
-      render(
-        <CurrencyField
-          value={0}
-          onChange={noop}
-          field={{ type: 'currency' } as any}
-          error="Must be positive"
-        />
-      );
-      const input = screen.getByRole('spinbutton');
-      expect(input).toHaveAttribute('aria-invalid', 'true');
-    });
-  });
-
-  // ---------------------------------------------------------------
-  // Disabled state consistency
-  // ---------------------------------------------------------------
-  describe('disabled state', () => {
-    it('TextField supports disabled prop', () => {
-      render(
-        <TextField
-          value="test"
-          onChange={noop}
-          field={{ type: 'text' } as any}
-          disabled={true}
-        />
-      );
-      expect(screen.getByRole('textbox')).toBeDisabled();
-    });
-
-    it('NumberField supports disabled prop', () => {
-      render(
-        <NumberField
-          value={5}
-          onChange={noop}
-          field={{ type: 'number' } as any}
-          disabled={true}
-        />
-      );
-      expect(screen.getByRole('spinbutton')).toBeDisabled();
-    });
-
-    it('EmailField supports disabled prop', () => {
-      render(
-        <EmailField
-          value=""
-          onChange={noop}
-          field={{ type: 'email' } as any}
-          disabled={true}
-        />
-      );
-      expect(screen.getByRole('textbox')).toBeDisabled();
-    });
-
-    it('PhoneField supports disabled prop', () => {
-      render(
-        <PhoneField
-          value=""
-          onChange={noop}
-          field={{ type: 'phone' } as any}
-          disabled={true}
-        />
-      );
-      expect(screen.getByRole('textbox')).toBeDisabled();
-    });
-
-    it('TextAreaField supports disabled prop', () => {
-      render(
-        <TextAreaField
-          value=""
-          onChange={noop}
-          field={{ type: 'textarea' } as any}
-          disabled={true}
-        />
-      );
-      expect(screen.getByRole('textbox')).toBeDisabled();
-    });
-  });
-
-  // ---------------------------------------------------------------
-  // Readonly mode consistency
-  // ---------------------------------------------------------------
-  describe('readonly mode output', () => {
-    it('TextField shows dash for empty value in readonly', () => {
-      const { container } = render(
-        <TextField
-          value=""
-          onChange={noop}
-          field={{ type: 'text' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('NumberField shows dash for null value in readonly', () => {
-      const { container } = render(
-        <NumberField
-          value={null as any}
-          onChange={noop}
-          field={{ type: 'number' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('EmailField shows dash for empty value in readonly', () => {
-      const { container } = render(
-        <EmailField
-          value=""
-          onChange={noop}
-          field={{ type: 'email' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('UrlField shows dash for empty value in readonly', () => {
-      const { container } = render(
-        <UrlField
-          value=""
-          onChange={noop}
-          field={{ type: 'url' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('PhoneField shows dash for empty value in readonly', () => {
-      const { container } = render(
-        <PhoneField
-          value=""
-          onChange={noop}
-          field={{ type: 'phone' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('TextAreaField shows dash for empty value in readonly', () => {
-      const { container } = render(
-        <TextAreaField
-          value=""
-          onChange={noop}
-          field={{ type: 'textarea' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('BooleanField shows Yes/No in readonly', () => {
-      const { container: yesC } = render(
-        <BooleanField
-          value={true}
-          onChange={noop}
-          field={{ type: 'boolean' } as any}
-          readonly={true}
-        />
-      );
-      expect(yesC.textContent).toBe('Yes');
-
-      const { container: noC } = render(
-        <BooleanField
-          value={false}
-          onChange={noop}
-          field={{ type: 'boolean' } as any}
-          readonly={true}
-        />
-      );
-      expect(noC.textContent).toBe('No');
-    });
-
-    it('SelectField shows dash for empty value in readonly', () => {
-      const { container } = render(
-        <SelectField
-          value=""
-          onChange={noop}
-          field={{ type: 'select', options: [] } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-
-    it('CurrencyField shows dash for null value in readonly', () => {
-      const { container } = render(
-        <CurrencyField
-          value={null as any}
-          onChange={noop}
-          field={{ type: 'currency' } as any}
-          readonly={true}
-        />
-      );
-      expect(container.textContent).toBe('—');
-    });
-  });
-
-  // ---------------------------------------------------------------
-  // Placeholder consistency
-  // ---------------------------------------------------------------
-  describe('placeholder support', () => {
-    it('TextField uses field placeholder', () => {
-      render(
-        <TextField
-          value=""
-          onChange={noop}
-          field={{ type: 'text', placeholder: 'Enter name...' } as any}
-        />
-      );
-      expect(screen.getByPlaceholderText('Enter name...')).toBeInTheDocument();
-    });
-
-    it('EmailField uses default placeholder', () => {
-      render(
-        <EmailField
-          value=""
-          onChange={noop}
-          field={{ type: 'email' } as any}
-        />
-      );
-      expect(screen.getByPlaceholderText('email@example.com')).toBeInTheDocument();
-    });
-
-    it('UrlField uses default placeholder', () => {
-      render(
-        <UrlField
-          value=""
-          onChange={noop}
-          field={{ type: 'url' } as any}
-        />
-      );
-      expect(screen.getByPlaceholderText('https://example.com')).toBeInTheDocument();
-    });
-
-    it('PhoneField uses default placeholder', () => {
-      render(
-        <PhoneField
-          value=""
-          onChange={noop}
-          field={{ type: 'phone' } as any}
-        />
-      );
-      expect(screen.getByPlaceholderText('(555) 123-4567')).toBeInTheDocument();
-    });
-  });
-});