@object-ui/data-objectstack 17.5.0 → 17.6.0

package/src/httpFailureLogging.test.ts

@@ -1,109 +0,0 @@
-/**
- * objectui#4042 half 2 — a request failure must SAY which request failed.
- *
- * `@objectstack/client` reports every non-2xx as
- * `logger.error("HTTP request failed", undefined, { method, url, status, error })`.
- * The console's logger used to forward that verbatim, so the identifying
- * fields lived only in the third argument: anything that flattens a console
- * record to text rendered them `[object Object]` / `Object`, and a screenful of
- * failures told you nothing about which URL or which status. These tests pin
- * that the message string itself now carries method + url + status (+ code).
- */
-
-import { describe, it, expect, vi, afterEach } from 'vitest';
-import { formatHttpFailureMessage, createQuietHttpLogger } from './index';
-
-const META_401 = {
-  method: 'GET',
-  url: '/api/v1/meta/object',
-  status: 401,
-  error: { code: 'UNAUTHORIZED', message: 'Unauthorized' },
-};
-
-describe('formatHttpFailureMessage', () => {
-  it('folds method, url and status into the message', () => {
-    expect(formatHttpFailureMessage('HTTP request failed', META_401)).toBe(
-      'HTTP request failed: GET /api/v1/meta/object -> 401 [UNAUTHORIZED]',
-    );
-  });
-
-  it('omits the code when the body carries none', () => {
-    expect(
-      formatHttpFailureMessage('HTTP request failed', {
-        method: 'POST',
-        url: '/api/v1/data/task',
-        status: 500,
-      }),
-    ).toBe('HTTP request failed: POST /api/v1/data/task -> 500');
-  });
-
-  it('reads the `statusCode` spelling too', () => {
-    expect(
-      formatHttpFailureMessage('HTTP request failed', { url: '/api/v1/meta/app', statusCode: 403 }),
-    ).toBe('HTTP request failed: GET /api/v1/meta/app -> 403');
-  });
-
-  it('returns null — not a husk — when meta identifies nothing', () => {
-    expect(formatHttpFailureMessage('HTTP request failed', undefined)).toBeNull();
-    expect(formatHttpFailureMessage('HTTP request failed', {})).toBeNull();
-    expect(formatHttpFailureMessage('HTTP request failed', { error: { message: 'boom' } })).toBeNull();
-  });
-
-  it('never yields the un-diagnosable string the card reported', () => {
-    const line = formatHttpFailureMessage('HTTP request failed', META_401)!;
-    expect(line).not.toContain('[object Object]');
-    expect(line).toContain('/api/v1/meta/object');
-    expect(line).toContain('401');
-  });
-});
-
-describe('createQuietHttpLogger', () => {
-  afterEach(() => vi.restoreAllMocks());
-
-  it('logs a 401 as an error whose FIRST argument identifies the request', () => {
-    const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
-    createQuietHttpLogger().error('HTTP request failed', undefined, META_401);
-
-    expect(spy).toHaveBeenCalledTimes(1);
-    const [message, , meta] = spy.mock.calls[0];
-    expect(message).toBe('HTTP request failed: GET /api/v1/meta/object -> 401 [UNAUTHORIZED]');
-    // The structured bag is still handed over for DevTools to expand — the
-    // string is added alongside it, not instead of it.
-    expect(meta).toEqual(META_401);
-  });
-
-  it('keeps demoting an expected 404, and identifies it in the demoted line too', () => {
-    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-    const debugSpy = vi.spyOn(console, 'debug').mockImplementation(() => {});
-
-    createQuietHttpLogger().error('HTTP request failed', undefined, {
-      method: 'GET',
-      url: '/api/v1/data/sys_presence',
-      status: 404,
-      error: { code: 'OBJECT_NOT_FOUND' },
-    });
-
-    expect(errorSpy).not.toHaveBeenCalled();
-    expect(debugSpy).toHaveBeenCalledTimes(1);
-    expect(debugSpy.mock.calls[0][0]).toContain('/api/v1/data/sys_presence -> 404');
-  });
-
-  it('does NOT silence a 401 — only 404-on-an-optional-collection is demoted', () => {
-    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-    const debugSpy = vi.spyOn(console, 'debug').mockImplementation(() => {});
-
-    // Session expiry mid-use: the console gates doomed requests, it does not
-    // hide the ones that still fail.
-    createQuietHttpLogger().error('HTTP request failed', undefined, META_401);
-
-    expect(errorSpy).toHaveBeenCalledTimes(1);
-    expect(debugSpy).not.toHaveBeenCalled();
-  });
-
-  it('falls back to the bare message when there is nothing to identify', () => {
-    const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
-    createQuietHttpLogger().error('Something broke', undefined, undefined);
-
-    expect(spy.mock.calls[0][0]).toBe('Something broke');
-  });
-});

package/src/importJob.test.ts

@@ -1,71 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-import { describe, it, expect, vi } from 'vitest';
-import { ObjectStackAdapter } from './index';
-
-/**
- * Adapter over a mock client `data` namespace. The async import-job methods are
- * thin pass-throughs to the client SDK, so we assert delegation + argument
- * shaping, plus graceful degradation when the client lacks the job API.
- */
-function makeDS(stub: Record<string, any>) {
-  const ds: any = new ObjectStackAdapter({
-    baseUrl: 'http://test.local',
-    fetch: vi.fn(async () => new Response(JSON.stringify({ success: true, data: { capabilities: {}, routes: {} } }), {
-      status: 200,
-      headers: { 'Content-Type': 'application/json' },
-    })),
-  });
-  ds.connected = true;
-  ds.connectionState = 'connected';
-  ds.client = { data: stub };
-  return ds;
-}
-
-describe('ObjectStackAdapter async import jobs', () => {
-  it('createImportJob delegates to client.data.createImportJob', async () => {
-    const createImportJob = vi.fn().mockResolvedValue({ jobId: 'imp_1', object: 'task', status: 'pending', total: 2 });
-    const ds = makeDS({ createImportJob });
-    const req = { format: 'json' as const, rows: [{ a: 1 }, { a: 2 }], writeMode: 'upsert' as const, matchFields: ['a'] };
-    const res = await ds.createImportJob('task', req);
-    expect(createImportJob).toHaveBeenCalledTimes(1);
-    expect(createImportJob.mock.calls[0]).toEqual(['task', req]);
-    expect(res).toMatchObject({ jobId: 'imp_1', status: 'pending', total: 2 });
-  });
-
-  it('getImportJobProgress / getImportJobResults / cancelImportJob delegate by jobId', async () => {
-    const getImportJobProgress = vi.fn().mockResolvedValue({ jobId: 'imp_1', status: 'running', percentComplete: 50 });
-    const getImportJobResults = vi.fn().mockResolvedValue({ jobId: 'imp_1', status: 'succeeded', results: [], resultsTruncated: false });
-    const cancelImportJob = vi.fn().mockResolvedValue({ success: true });
-    const ds = makeDS({ createImportJob: vi.fn(), getImportJobProgress, getImportJobResults, cancelImportJob });
-
-    expect((await ds.getImportJobProgress('imp_1')).percentComplete).toBe(50);
-    expect(getImportJobProgress).toHaveBeenCalledWith('imp_1');
-
-    expect((await ds.getImportJobResults('imp_1')).resultsTruncated).toBe(false);
-    expect(getImportJobResults).toHaveBeenCalledWith('imp_1');
-
-    await ds.cancelImportJob('imp_1');
-    expect(cancelImportJob).toHaveBeenCalledWith('imp_1');
-  });
-
-  it('listImportJobs forwards filters and returns the jobs array', async () => {
-    const listImportJobs = vi.fn().mockResolvedValue([{ jobId: 'imp_1', object: 'task', status: 'succeeded' }]);
-    const ds = makeDS({ createImportJob: vi.fn(), listImportJobs });
-    const jobs = await ds.listImportJobs({ object: 'task', status: 'succeeded', limit: 10 });
-    expect(listImportJobs).toHaveBeenCalledWith({ object: 'task', status: 'succeeded', limit: 10 });
-    expect(jobs).toHaveLength(1);
-  });
-
-  it('throws UNSUPPORTED_OPERATION when the client lacks the job API', async () => {
-    const ds = makeDS({ import: vi.fn() }); // sync import only, no createImportJob
-    await expect(ds.createImportJob('task', { format: 'json', rows: [] })).rejects.toMatchObject({ code: 'UNSUPPORTED_OPERATION' });
-    await expect(ds.getImportJobProgress('imp_1')).rejects.toMatchObject({ code: 'UNSUPPORTED_OPERATION' });
-  });
-});