@object-ui/data-objectstack 17.3.0 → 17.6.0

package/src/onWriteWarning.test.ts

@@ -1,273 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-/**
- * ObjectStackAdapter must surface the framework's write-observability channel
- * (#3431/#3455): when a create/update response carries `droppedFields` — fields
- * the backend LEGALLY stripped (read-only / locked-by-state) — the adapter emits
- * a WriteWarningEvent so the app shell can toast the user instead of letting the
- * dropped value vanish silently. The write itself still succeeded.
- */
-import { describe, it, expect, vi } from 'vitest';
-import { ObjectStackAdapter } from './index';
-import type { WriteWarningEvent } from './index';
-
-function makeDS(stub: Record<string, any>) {
-  const ds: any = new ObjectStackAdapter({
-    baseUrl: 'http://test.local',
-    fetch: vi.fn(async () =>
-      new Response(JSON.stringify({ success: true, data: { capabilities: {}, routes: {} } }), {
-        status: 200,
-        headers: { 'Content-Type': 'application/json' },
-      }),
-    ),
-  });
-  ds.connected = true;
-  ds.connectionState = 'connected';
-  ds.client = { data: stub };
-  return ds;
-}
-
-const ONE_DROP = [{ object: 'approval_case', fields: ['approval_status'], reason: 'readonly' }];
-
-describe('ObjectStackAdapter.onWriteWarning', () => {
-  it('emits a create write-warning carrying the dropped fields and the new id', async () => {
-    const create = vi.fn().mockResolvedValue({ record: { id: 'r1', title: 'A' }, droppedFields: ONE_DROP });
-    const ds = makeDS({ create });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    const rec = await ds.create('approval_case', { title: 'A', approval_status: 'approved' });
-
-    // The write still returns the plain record (unchanged behaviour).
-    expect(rec).toEqual({ id: 'r1', title: 'A' });
-    expect(events).toEqual([
-      { operation: 'create', resource: 'approval_case', id: 'r1', droppedFields: ONE_DROP },
-    ]);
-  });
-
-  it('emits an update write-warning carrying the target id', async () => {
-    const update = vi.fn().mockResolvedValue({ record: { id: 'r1' }, droppedFields: ONE_DROP });
-    const ds = makeDS({ update });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.update('approval_case', 'r1', { approval_status: 'approved' });
-
-    expect(events).toEqual([
-      { operation: 'update', resource: 'approval_case', id: 'r1', droppedFields: ONE_DROP },
-    ]);
-  });
-
-  it('does NOT emit when the response carries no droppedFields (the common case)', async () => {
-    const create = vi.fn().mockResolvedValue({ record: { id: 'r1', title: 'A' } });
-    const update = vi.fn().mockResolvedValue({ record: { id: 'r1' } });
-    const ds = makeDS({ create, update });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.create('approval_case', { title: 'A' });
-    await ds.update('approval_case', 'r1', { title: 'B' });
-
-    expect(events).toEqual([]);
-  });
-
-  it('does NOT emit for an empty or malformed droppedFields payload', async () => {
-    const create = vi
-      .fn()
-      .mockResolvedValueOnce({ record: { id: 'r1' }, droppedFields: [] })
-      .mockResolvedValueOnce({ record: { id: 'r2' }, droppedFields: 'nope' })
-      .mockResolvedValueOnce({ record: { id: 'r3' }, droppedFields: [{ object: 'x', fields: [] }] });
-    const ds = makeDS({ create });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.create('x', {});
-    await ds.create('x', {});
-    await ds.create('x', {}); // event present but its fields[] is empty → filtered out
-
-    expect(events).toEqual([]);
-  });
-
-  // ── cross-object batch (framework #3794) ─────────────────────────────────
-  //
-  // `batchTransaction` is the console record form's save path for a
-  // master-detail record, so this is where a `readonlyWhen` strip actually
-  // reaches a user editing a form. Its response tags each event with the index
-  // of the operation that produced it.
-
-  it('emits a write-warning per event on a cross-object batch, resolving the op', async () => {
-    const batchTransaction = vi.fn().mockResolvedValue({
-      results: [{ id: 'acc1' }, { id: 'inv1' }],
-      droppedFields: [
-        { object: 'invoice', fields: ['tax_rate'], reason: 'readonly_when', index: 1 },
-      ],
-    });
-    const ds = makeDS({ batchTransaction });
-    ds.atomicBatchCapability = true;
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.batchTransaction([
-      { object: 'account', action: 'create', data: { name: 'Acme' } },
-      { object: 'invoice', action: 'update', id: 'inv1', data: { status: 'paid', tax_rate: 9 } },
-    ]);
-
-    expect(events).toEqual([
-      {
-        operation: 'update',
-        resource: 'invoice',
-        id: 'inv1',
-        droppedFields: [{ object: 'invoice', fields: ['tax_rate'], reason: 'readonly_when' }],
-      },
-    ]);
-  });
-
-  it('does NOT emit for a clean batch or a malformed droppedFields list', async () => {
-    const batchTransaction = vi
-      .fn()
-      .mockResolvedValueOnce({ results: [{ id: 'a' }] })
-      .mockResolvedValueOnce({ results: [{ id: 'a' }], droppedFields: [{ object: 'x', fields: [], index: 0 }] });
-    const ds = makeDS({ batchTransaction });
-    ds.atomicBatchCapability = true;
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.batchTransaction([{ object: 'x', action: 'create', data: {} }]);
-    await ds.batchTransaction([{ object: 'x', action: 'create', data: {} }]);
-
-    expect(events).toEqual([]);
-  });
-
-  it('stops delivering after unsubscribe', async () => {
-    const create = vi.fn().mockResolvedValue({ record: { id: 'r1' }, droppedFields: ONE_DROP });
-    const ds = makeDS({ create });
-    const events: WriteWarningEvent[] = [];
-    const unsub = ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.create('approval_case', {});
-    unsub();
-    await ds.create('approval_case', {});
-
-    expect(events).toHaveLength(1);
-  });
-
-  // ── no-op strips are not news (objectui#3484) ─────────────────────────────
-  //
-  // The server is right to report a strip — the client DID send the key. But
-  // "was not saved" is only worth a toast when something was LOST. The console
-  // edit form used to round-trip the whole record, so every save of a
-  // state-locked record warned about fields the user never touched whose values
-  // never changed. When the echoed record proves the stripped value equals what
-  // was sent, stay quiet.
-
-  it('suppresses the warning when every stripped value equals what the record already holds', async () => {
-    const update = vi.fn().mockResolvedValue({
-      record: { id: 'r1', type: 'quality_abnormal', source_method: 'qc_judgment', title: 'B' },
-      droppedFields: [
-        { object: 'andon', fields: ['type', 'source_method'], reason: 'readonly_when' },
-      ],
-    });
-    const ds = makeDS({ update });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.update('andon', 'r1', {
-      title: 'B',
-      type: 'quality_abnormal',
-      source_method: 'qc_judgment',
-    });
-
-    expect(events).toEqual([]);
-  });
-
-  it('still warns about the fields that really did change, and only those', async () => {
-    const update = vi.fn().mockResolvedValue({
-      record: { id: 'r1', type: 'quality_abnormal', source_method: 'qc_judgment' },
-      droppedFields: [
-        { object: 'andon', fields: ['type', 'source_method'], reason: 'readonly_when' },
-      ],
-    });
-    const ds = makeDS({ update });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    // The user really did try to change `type`; `source_method` round-tripped.
-    await ds.update('andon', 'r1', { type: 'equipment_fault', source_method: 'qc_judgment' });
-
-    expect(events).toEqual([
-      {
-        operation: 'update',
-        resource: 'andon',
-        id: 'r1',
-        droppedFields: [{ object: 'andon', fields: ['type'], reason: 'readonly_when' }],
-      },
-    ]);
-  });
-
-  it('keeps the warning when the no-op cannot be PROVEN (record echo lacks the key)', async () => {
-    const update = vi.fn().mockResolvedValue({
-      record: { id: 'r1' },
-      droppedFields: [{ object: 'andon', fields: ['type'], reason: 'readonly_when' }],
-    });
-    const ds = makeDS({ update });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.update('andon', 'r1', { type: 'quality_abnormal' });
-
-    expect(events).toHaveLength(1);
-  });
-
-  it('does not treat a type change as a no-op (1 is not "1")', async () => {
-    const update = vi.fn().mockResolvedValue({
-      record: { id: 'r1', tax_rate: '9' },
-      droppedFields: [{ object: 'invoice', fields: ['tax_rate'], reason: 'readonly_when' }],
-    });
-    const ds = makeDS({ update });
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.update('invoice', 'r1', { tax_rate: 9 });
-
-    expect(events).toHaveLength(1);
-  });
-
-  it('suppresses a no-op strip on the cross-object batch path too', async () => {
-    const batchTransaction = vi.fn().mockResolvedValue({
-      results: [{ id: 'acc1' }, { id: 'inv1', tax_rate: 9 }],
-      droppedFields: [
-        { object: 'invoice', fields: ['tax_rate'], reason: 'readonly_when', index: 1 },
-      ],
-    });
-    const ds = makeDS({ batchTransaction });
-    ds.atomicBatchCapability = true;
-    const events: WriteWarningEvent[] = [];
-    ds.onWriteWarning((e: WriteWarningEvent) => events.push(e));
-
-    await ds.batchTransaction([
-      { object: 'account', action: 'create', data: { name: 'Acme' } },
-      { object: 'invoice', action: 'update', id: 'inv1', data: { status: 'paid', tax_rate: 9 } },
-    ]);
-
-    expect(events).toEqual([]);
-  });
-
-  it('isolates a throwing listener so the write still resolves and other listeners fire', async () => {
-    const update = vi.fn().mockResolvedValue({ record: { id: 'r1' }, droppedFields: ONE_DROP });
-    const ds = makeDS({ update });
-    const good = vi.fn();
-    ds.onWriteWarning(() => { throw new Error('boom'); });
-    ds.onWriteWarning(good);
-    const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
-
-    await expect(ds.update('approval_case', 'r1', { approval_status: 'x' })).resolves.toBeTruthy();
-    expect(good).toHaveBeenCalledTimes(1);
-    warn.mockRestore();
-  });
-});

package/src/orderby-serialization.test.ts

@@ -1,115 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-/**
- * Every shape `QueryParams['$orderby']` declares reaches the wire as a sort.
- *
- * `find()` has TWO routes to the server — a plain read goes through
- * `convertQueryParams` and the client SDK, a read with `$expand`/`$search`
- * through `rawFindWithPopulate` — and each used to carry its own copy of the
- * "which `$orderby` shape is this?" fold. Both copies handled three of the four
- * declared shapes; both missed the bare string, and missed it the same
- * spectacular way: the string fell into the `Record<field, direction>` branch,
- * where `Object.entries('name asc')` enumerates character indices and the
- * request went out as `sort=0,1,2,3,4,5,6,7`.
- *
- * That is not a cosmetic mistranslation. Since objectstack#4226 the server
- * refuses a sort it cannot read (`400 INVALID_SORT`) rather than dropping it,
- * so the whole list fails to load — and `"${field} ${order}"` is exactly what a
- * standalone `ObjectGrid` builds from its view metadata's `sort`.
- *
- * Both routes are asserted for every shape, because "the two routes agree" is
- * the property that was actually missing; one serializer now backs both.
- */
-
-import { describe, it, expect, beforeEach, vi } from 'vitest';
-import { ObjectStackAdapter, clearSharedDiscoveryCache, serializeOrderBy } from './index';
-
-function makeAdapter() {
-  const calls: string[] = [];
-  const fetchImpl = vi.fn(async (url: any) => {
-    const u = String(url);
-    calls.push(u);
-    if (u.includes('/api/v1/discovery')) {
-      return {
-        ok: true, status: 200, statusText: 'OK',
-        json: async () => ({ success: true, data: { version: 'v1', routes: {} } }),
-      } as any;
-    }
-    return {
-      ok: true, status: 200, statusText: 'OK',
-      json: async () => ({ success: true, data: { object: 'account', records: [], total: 0 } }),
-    } as any;
-  });
-  const adapter = new ObjectStackAdapter({
-    baseUrl: 'http://localhost:3000', token: 't', autoReconnect: false, fetch: fetchImpl as any,
-  });
-  return { adapter, calls };
-}
-
-/** The `sort=` this `$orderby` produced on the wire, or `undefined` if none was sent. */
-async function sortOnWire($orderby: unknown, route: 'plain' | 'expand'): Promise<string | undefined> {
-  const { adapter, calls } = makeAdapter();
-  await adapter.find('account', {
-    $orderby,
-    ...(route === 'expand' ? { $expand: ['owner'] } : {}),
-  } as any);
-  const dataCall = calls.filter((u) => u.includes('/data/account')).pop();
-  const raw = dataCall ? new URL(dataCall).searchParams.get('sort') : null;
-  return raw === null ? undefined : raw;
-}
-
-/** Run one input down both `find()` routes and assert they agree. */
-function bothRoutes(name: string, $orderby: unknown, expected: string | undefined) {
-  for (const route of ['plain', 'expand'] as const) {
-    it(`${name} (${route} route)`, async () => {
-      expect(await sortOnWire($orderby, route)).toBe(expected);
-    });
-  }
-}
-
-describe('$orderby reaches the wire for every declared shape', () => {
-  beforeEach(() => clearSharedDiscoveryCache());
-
-  // The regression: ObjectGrid's own `"${field} ${order}"`.
-  bothRoutes('a bare "field order" string', 'name asc', 'name asc');
-  bothRoutes('a bare string with a descending key', 'created_at desc', 'created_at desc');
-  bothRoutes('a bare string already in `-field` shorthand', '-created_at', '-created_at');
-  bothRoutes('a bare multi-key string', 'status asc,-created_at', 'status asc,-created_at');
-
-  bothRoutes('a SortNode[]', [{ field: 'name', order: 'asc' }], 'name');
-  bothRoutes(
-    'a SortNode[] with a descending key',
-    [{ field: 'status', order: 'asc' }, { field: 'created_at', order: 'desc' }],
-    'status,-created_at',
-  );
-  bothRoutes('a string[]', ['name', '-age'], 'name,-age');
-  bothRoutes('a Record<field, direction>', { name: 'asc', age: 'desc' }, 'name,-age');
-
-  bothRoutes('no sort at all', undefined, undefined);
-  bothRoutes('an empty array', [], undefined);
-  bothRoutes('an empty object', {}, undefined);
-  bothRoutes('a whitespace-only string', '   ', undefined);
-});
-
-describe('serializeOrderBy', () => {
-  it('never enumerates a string as an object — the defect this replaced', () => {
-    // `Object.entries('name asc')` → [['0','n'],['1','a'],…]. The old fold
-    // reached that branch for every string input.
-    expect(serializeOrderBy('name asc')).toBe('name asc');
-    expect(serializeOrderBy('name asc')).not.toMatch(/^0,1,2/);
-  });
-
-  it('reads `order` case-insensitively', () => {
-    expect(serializeOrderBy([{ field: 'name', order: 'DESC' as any }])).toBe('-name');
-  });
-
-  it('defaults a missing direction to ascending', () => {
-    expect(serializeOrderBy([{ field: 'name' }])).toBe('name');
-  });
-});

package/src/queryDataset.test.ts

@@ -1,132 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-import { describe, it, expect, beforeEach, vi } from 'vitest';
-import {
-  ObjectStackAdapter,
-  clearSharedDiscoveryCache,
-  isAnalyticsNotInstalledError,
-} from './index';
-
-/** A fetch mock that answers discovery + records the dataset-query POST. */
-function makeFetch(datasetResponse: { ok: boolean; status?: number; body: unknown }) {
-  const calls: Array<{ url: string; init?: any }> = [];
-  const fetchImpl = vi.fn(async (url: any, init?: any) => {
-    const u = String(url);
-    calls.push({ url: u, init });
-    if (u.includes('/api/v1/discovery')) {
-      return { ok: true, status: 200, statusText: 'OK', json: async () => ({ success: true, data: { version: 'v1', routes: {} } }) } as any;
-    }
-    if (u.includes('/api/v1/analytics/dataset/query')) {
-      return {
-        ok: datasetResponse.ok,
-        status: datasetResponse.status ?? (datasetResponse.ok ? 200 : 400),
-        statusText: datasetResponse.ok ? 'OK' : 'Bad Request',
-        json: async () => datasetResponse.body,
-      } as any;
-    }
-    return { ok: true, status: 200, statusText: 'OK', json: async () => ({}) } as any;
-  });
-  return { fetchImpl, calls };
-}
-
-const inlineDataset = {
-  name: 'sales', label: 'Sales', object: 'opportunity', include: ['account'],
-  dimensions: [{ name: 'region', field: 'account.region', type: 'string' }],
-  measures: [{ name: 'revenue', aggregate: 'sum', field: 'amount' }],
-};
-const selection = { dimensions: ['region'], measures: ['revenue'] };
-
-describe('ObjectStackAdapter.queryDataset', () => {
-  beforeEach(() => clearSharedDiscoveryCache());
-
-  it('POSTs the inline dataset + selection and returns rows/fields', async () => {
-    const { fetchImpl, calls } = makeFetch({
-      ok: true,
-      body: { rows: [{ region: 'NA', revenue: 100 }], fields: [{ name: 'revenue', type: 'number' }] },
-    });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', token: 'tok_123', autoReconnect: false, fetch: fetchImpl as any });
-
-    const result = await adapter.queryDataset(inlineDataset as any, selection);
-
-    expect(result.rows).toEqual([{ region: 'NA', revenue: 100 }]);
-    expect(result.fields).toEqual([{ name: 'revenue', type: 'number' }]);
-
-    const post = calls.find((c) => c.url.includes('/analytics/dataset/query'))!;
-    expect(post.url).toBe('http://localhost:3000/api/v1/analytics/dataset/query');
-    expect(post.init.method).toBe('POST');
-    expect(post.init.headers.Authorization).toBe('Bearer tok_123');
-    expect(JSON.parse(post.init.body)).toEqual({ dataset: inlineDataset, selection });
-  });
-
-  it('sends datasetName when given a string', async () => {
-    const { fetchImpl, calls } = makeFetch({ ok: true, body: { rows: [], fields: [] } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    await adapter.queryDataset('sales', selection);
-    const post = calls.find((c) => c.url.includes('/analytics/dataset/query'))!;
-    expect(JSON.parse(post.init.body)).toEqual({ datasetName: 'sales', selection });
-  });
-
-  it('unwraps a { success, data } envelope', async () => {
-    const { fetchImpl } = makeFetch({ ok: true, body: { success: true, data: { rows: [{ x: 1 }], fields: [] } } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    const result = await adapter.queryDataset(inlineDataset as any, selection);
-    expect(result.rows).toEqual([{ x: 1 }]);
-  });
-
-  it('throws (no silent fallback) with the server message on a 4xx', async () => {
-    const { fetchImpl } = makeFetch({ ok: false, status: 400, body: { code: 'DATASET_INVALID', message: 'relationship not declared' } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    await expect(adapter.queryDataset(inlineDataset as any, selection)).rejects.toThrow(/relationship not declared/);
-  });
-
-  // framework#3891 retired the degraded in-kernel analytics fallback, so a
-  // deployment without @objectstack/service-analytics answers 501 (REST route
-  // present, no service) or 404 (framework#4019 stopped mounting the routes).
-  // Neither is an authoring mistake — the caller gets a typed, readable error
-  // instead of `Dataset query failed: 501 Not Implemented — …`.
-  describe('analytics capability absent', () => {
-    it('maps 501 NOT_IMPLEMENTED to a readable ANALYTICS_NOT_INSTALLED error', async () => {
-      const { fetchImpl } = makeFetch({
-        ok: false,
-        status: 501,
-        body: {
-          code: 'NOT_IMPLEMENTED',
-          message: 'Analytics dataset query is not available on this deployment (no analytics service with queryDataset).',
-        },
-      });
-      const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-
-      const err = await adapter.queryDataset(inlineDataset as any, selection).catch((e) => e);
-
-      expect(isAnalyticsNotInstalledError(err)).toBe(true);
-      expect(err.code).toBe('ANALYTICS_NOT_INSTALLED');
-      expect(err.message).toContain('Analytics capability is not installed');
-      expect(err.message).toContain('@objectstack/service-analytics');
-    });
-
-    it('maps a 404 (routes not mounted) the same way', async () => {
-      const { fetchImpl } = makeFetch({ ok: false, status: 404, body: { error: 'Not found' } });
-      const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-
-      const err = await adapter.queryDataset(inlineDataset as any, selection).catch((e) => e);
-
-      expect(isAnalyticsNotInstalledError(err)).toBe(true);
-    });
-
-    it('leaves a real compile error alone (it is NOT a missing capability)', async () => {
-      const { fetchImpl } = makeFetch({ ok: false, status: 400, body: { message: 'relationship not declared in include' } });
-      const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-
-      const err = await adapter.queryDataset(inlineDataset as any, selection).catch((e) => e);
-
-      expect(isAnalyticsNotInstalledError(err)).toBe(false);
-      expect(String(err.message)).toContain('relationship not declared');
-    });
-  });
-});

package/src/searchAll.test.ts

@@ -1,120 +0,0 @@
-/**
- * ObjectUI
- * Copyright (c) 2024-present ObjectStack Inc.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-import { describe, it, expect, beforeEach, vi } from 'vitest';
-import { ObjectStackAdapter, clearSharedDiscoveryCache } from './index';
-
-/** A fetch mock that answers discovery + records the global-search GET. */
-function makeFetch(searchResponse: { ok: boolean; status?: number; body: unknown }) {
-  const calls: Array<{ url: string; init?: any }> = [];
-  const fetchImpl = vi.fn(async (url: any, init?: any) => {
-    const u = String(url);
-    calls.push({ url: u, init });
-    if (u.includes('/api/v1/discovery')) {
-      return { ok: true, status: 200, statusText: 'OK', json: async () => ({ success: true, data: { version: 'v1', routes: {} } }) } as any;
-    }
-    if (u.includes('/api/v1/search')) {
-      return {
-        ok: searchResponse.ok,
-        status: searchResponse.status ?? (searchResponse.ok ? 200 : 400),
-        statusText: searchResponse.ok ? 'OK' : 'Error',
-        json: async () => searchResponse.body,
-      } as any;
-    }
-    return { ok: true, status: 200, statusText: 'OK', json: async () => ({}) } as any;
-  });
-  return { fetchImpl, calls };
-}
-
-const WAYNE_HITS = {
-  query: 'Wayne',
-  hits: [
-    { object: 'crm_account', id: 'a1', title: 'Wayne Enterprises', snippet: 'Wayne Enterprises', record: { id: 'a1', account_number: 'ACC-000005' } },
-    { object: 'crm_opportunity', id: 'o1', title: 'Wayne Q1 Expansion', record: { id: 'o1' } },
-  ],
-};
-
-describe('ObjectStackAdapter.searchAll', () => {
-  beforeEach(() => clearSharedDiscoveryCache());
-
-  it('GETs /api/v1/search?q= and returns normalized ranked hits', async () => {
-    const { fetchImpl, calls } = makeFetch({ ok: true, body: WAYNE_HITS });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', token: 'tok_123', autoReconnect: false, fetch: fetchImpl as any });
-
-    const result = await adapter.searchAll('Wayne');
-
-    expect(result.query).toBe('Wayne');
-    expect(result.hits.map((h) => `${h.object}:${h.id}`)).toEqual(['crm_account:a1', 'crm_opportunity:o1']);
-    expect(result.hits[0].title).toBe('Wayne Enterprises');
-    expect(result.hits[0].record).toEqual({ id: 'a1', account_number: 'ACC-000005' });
-
-    const get = calls.find((c) => c.url.includes('/api/v1/search'))!;
-    const url = new URL(get.url);
-    expect(url.pathname).toBe('/api/v1/search');
-    expect(url.searchParams.get('q')).toBe('Wayne');
-    expect(get.init.method).toBe('GET');
-    expect(get.init.headers.Authorization).toBe('Bearer tok_123');
-  });
-
-  it('trims the query and forwards limit + objects scoping', async () => {
-    const { fetchImpl, calls } = makeFetch({ ok: true, body: { query: 'Wayne', hits: [] } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-
-    await adapter.searchAll('  Wayne  ', { limit: 12, objects: ['crm_account', 'crm_opportunity'] });
-
-    const url = new URL(calls.find((c) => c.url.includes('/api/v1/search'))!.url);
-    expect(url.searchParams.get('q')).toBe('Wayne');
-    expect(url.searchParams.get('limit')).toBe('12');
-    expect(url.searchParams.get('objects')).toBe('crm_account,crm_opportunity');
-  });
-
-  it('short-circuits an empty query without hitting the network', async () => {
-    const { fetchImpl, calls } = makeFetch({ ok: true, body: { query: '', hits: [] } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-
-    const result = await adapter.searchAll('   ');
-
-    expect(result).toEqual({ query: '', hits: [] });
-    expect(calls.some((c) => c.url.includes('/api/v1/search'))).toBe(false);
-  });
-
-  it('unwraps a { success, data } envelope', async () => {
-    const { fetchImpl } = makeFetch({ ok: true, body: { success: true, data: WAYNE_HITS } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    const result = await adapter.searchAll('Wayne');
-    expect(result.hits).toHaveLength(2);
-  });
-
-  it('treats a 404 (search plugin absent) as an empty result, not an error', async () => {
-    const { fetchImpl } = makeFetch({ ok: false, status: 404, body: { message: 'not found' } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    await expect(adapter.searchAll('Wayne')).resolves.toEqual({ query: 'Wayne', hits: [] });
-  });
-
-  it('throws with the server message on a non-404 error', async () => {
-    const { fetchImpl } = makeFetch({ ok: false, status: 500, body: { error: { message: 'index unavailable' } } });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    await expect(adapter.searchAll('Wayne')).rejects.toThrow(/index unavailable/);
-  });
-
-  it('drops malformed hits (missing object or id)', async () => {
-    const { fetchImpl } = makeFetch({
-      ok: true,
-      body: { query: 'x', hits: [
-        { object: 'crm_account', id: 'a1', title: 'Keep' },
-        { id: 'no_object' },
-        { object: 'crm_lead' },
-        null,
-        { object: 'crm_contact', record: { id: 'c9' } },
-      ] },
-    });
-    const adapter = new ObjectStackAdapter({ baseUrl: 'http://localhost:3000', autoReconnect: false, fetch: fetchImpl as any });
-    const result = await adapter.searchAll('x');
-    expect(result.hits.map((h) => `${h.object}:${h.id}`)).toEqual(['crm_account:a1', 'crm_contact:c9']);
-  });
-});