@object-ui/app-shell 4.7.0 → 5.0.0

package/dist/views/RecordDetailView.js

@@ -8,11 +8,11 @@ import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
  */
 import { useState, useEffect, useCallback, useMemo, useRef } from 'react';
 import { useParams, useNavigate } from 'react-router-dom';
-import { DetailView, RecordChatterPanel } from '@object-ui/plugin-detail';
+import { DetailView, RecordChatterPanel, buildDefaultPageSchema } from '@object-ui/plugin-detail';
 import { Empty, EmptyTitle, EmptyDescription } from '@object-ui/components';
 import { PresenceAvatars } from '@object-ui/collaboration';
 import { useAuth, createAuthenticatedFetch } from '@object-ui/auth';
-import { ActionProvider, useObjectTranslation, useObjectLabel, usePageAssignment, RecordContextProvider, SchemaRenderer } from '@object-ui/react';
+import { ActionProvider, useObjectTranslation, useObjectLabel, usePageAssignment, RecordContextProvider, SchemaRenderer, DiscussionContextProvider, HighlightFieldsProvider } from '@object-ui/react';
 import { buildExpandFields } from '@object-ui/core';
 import { toast } from 'sonner';
 import { Database, Users } from 'lucide-react';
@@ -20,6 +20,7 @@ import { MetadataPanel, useMetadataInspector } from './MetadataInspector';
 import { SkeletonDetail } from '../skeletons';
 import { ManagedByBadge } from '../components/ManagedByBadge';
 import { resolveCrudAffordances } from '../utils/crudAffordances';
+import { hasExplicitDiscussion } from '../utils/pageSchemaIntrospect';
 import { ActionConfirmDialog } from './ActionConfirmDialog';
 import { ActionParamDialog } from './ActionParamDialog';
 import { resolveActionParams } from '../utils/resolveActionParams';
@@ -79,11 +80,50 @@ export function RecordDetailView({ dataSource, objects, onEdit, objectNameOverri
     // it via SchemaRenderer (which dispatches to the registered 'record'
     // PageRenderer in @object-ui/components). Otherwise we fall through to
     // the legacy auto-generated DetailView path below.
-    const { page: assignedPage } = usePageAssignment(objectName);
+    //
+    // Track 3 Phase G slice 6 — `renderViaSchema` is now default-on. The
+    // no-assignedPage branch synthesizes a canonical Page via
+    // `buildDefaultPageSchema(objectDef)` so the default detail page rides
+    // the same SchemaRenderer pipeline as custom pages. Kill-switches:
+    //   1) URL query param `?renderViaSchema=0` (per-request fallback to
+    //      the legacy DetailView monolith — useful for debugging regressions)
+    //   2) `objectDef.detail?.renderViaSchema === false` (per-object opt-out)
+    const { page: assignedPage, slots: assignedSlots } = usePageAssignment(objectName);
+    const renderViaSchemaFlag = useMemo(() => {
+        if (typeof window !== 'undefined') {
+            try {
+                const qp = new URLSearchParams(window.location.search).get('renderViaSchema');
+                if (qp === '0' || qp === 'false')
+                    return false;
+                if (qp === '1' || qp === 'true')
+                    return true;
+            }
+            catch { }
+        }
+        if (objectDef?.detail?.renderViaSchema === false)
+            return false;
+        return true;
+    }, [objectDef]);
+    const synthesizedPage = useMemo(() => {
+        // Synthesizer drives two cases:
+        //   1) no assignedPage at all → pure default detail page
+        //   2) assignedSlots (slotted page) → synth with slot overrides
+        // In either case the page-record load effect below only needs
+        // "is there a page?"; the fully-detailed schema is rebuilt at
+        // render time once `detailSchema.sections` are known.
+        if (assignedPage)
+            return null;
+        if (!objectDef)
+            return null;
+        if (!renderViaSchemaFlag && !assignedSlots)
+            return null;
+        return buildDefaultPageSchema(objectDef, assignedSlots ? { slots: assignedSlots } : undefined);
+    }, [renderViaSchemaFlag, assignedPage, assignedSlots, objectDef]);
+    const effectivePage = assignedPage || synthesizedPage;
     const [pageRecord, setPageRecord] = useState(null);
     useEffect(() => {
         let cancelled = false;
-        if (!assignedPage || !pureRecordId || !objectName || !dataSource?.findOne) {
+        if (!effectivePage || !pureRecordId || !objectName || !dataSource?.findOne) {
             setPageRecord(null);
             return;
         }
@@ -107,7 +147,7 @@ export function RecordDetailView({ dataSource, objects, onEdit, objectNameOverri
         return () => {
             cancelled = true;
         };
-    }, [assignedPage, objectName, pureRecordId, dataSource, objectDef]);
+    }, [effectivePage, objectName, pureRecordId, dataSource, objectDef]);
     // ─── Action Provider Handlers ───────────────────────────────────────
     // Confirm dialog state (promise-based)
     const [confirmState, setConfirmState] = useState({ open: false, message: '' });
@@ -1006,8 +1046,158 @@ export function RecordDetailView({ dataSource, objects, onEdit, objectNameOverri
     if (!objectDef) {
         return (_jsx("div", { className: "flex h-full items-center justify-center p-4", children: _jsxs(Empty, { children: [_jsx("div", { className: "mx-auto mb-4 flex h-12 w-12 items-center justify-center rounded-full bg-muted", children: _jsx(Database, { className: "h-6 w-6 text-muted-foreground" }) }), _jsx(EmptyTitle, { children: t('empty.objectNotFound') }), _jsx(EmptyDescription, { children: t('empty.objectNotFoundDescription', { name: objectName }) })] }) }));
     }
-    if (assignedPage) {
-        return (_jsx(RecordContextProvider, { objectName: objectName, recordId: pureRecordId, data: pageRecord, objectSchema: objectDef, dataSource: dataSource, embedded: embedded, children: _jsx(ActionProvider, { context: { record: pageRecord || {}, objectName, user: currentUser }, onConfirm: confirmHandler, onToast: toastHandler, onNavigate: navigateHandler, onParamCollection: paramCollectionHandler, handlers: { api: apiHandler, flow: flowHandler, script: serverActionHandler, modal: serverActionHandler, approval: approvalHandler }, children: _jsx("div", { className: "bg-background p-3 sm:p-4 lg:p-6", children: _jsx(SchemaRenderer, { schema: assignedPage }) }) }) }));
+    if (effectivePage) {
+        const disableDiscussion = effectivePage?.disableDiscussion === true;
+        // When the page schema embeds an explicit `record:discussion` /
+        // `record:chatter` slot, skip the bottom auto-append so the
+        // author placement (or synth default) wins. The walker recurses
+        // into `regions[]` so `buildDefaultPageSchema` output and
+        // full-Lightning authored pages are both detected.
+        const hasDiscussion = hasExplicitDiscussion(effectivePage);
+        const showAutoDiscussion = !disableDiscussion && !hasDiscussion;
+        // Slice 2 — when we're synthesizing (no author assignedPage), rebuild
+        // the schema with the actual detailSchema.sections + highlight fields
+        // so record:details renders the same field layout the legacy
+        // DetailView would have produced.
+        // Slice 4 — also forward header actions, related lists, activities,
+        // and history so the synthesized page reaches parity with the
+        // monolithic DetailView (tabs strip + record_header quick actions).
+        // Business / custom actions authored on objectDef and routed to the
+        // record_header location (e.g. Lead.convert, Contact.set_primary).
+        const synthBusinessActions = (() => {
+            const acts = detailSchema.actions;
+            if (!Array.isArray(acts))
+                return [];
+            // detailSchema wraps actions in a `{type:'action:bar', actions:[]}`
+            // shape; unwrap to the flat ActionDef[] the renderer expects.
+            const bar = acts.find((a) => Array.isArray(a?.actions));
+            const flat = bar?.actions ?? acts;
+            return Array.isArray(flat) ? flat : [];
+        })();
+        // System actions (Edit / Share / Delete) — the legacy DetailView
+        // monolith always synthesized these. The synth-path replacement
+        // (Phase G slice 6) initially dropped them, leaving objects without
+        // authored record_header actions with a bare header. Re-inject here
+        // so every record page surfaces the basic affordances.
+        const synthSystemActions = (() => {
+            const affordances = resolveCrudAffordances(objectDef);
+            const items = [];
+            if (affordances.edit) {
+                items.push({
+                    name: 'sys_edit',
+                    label: t('detail.edit', { defaultValue: 'Edit' }),
+                    type: 'script',
+                    locations: ['record_header'],
+                    variant: 'default',
+                    onClick: () => onEdit({ id: pureRecordId }),
+                });
+            }
+            items.push({
+                name: 'sys_share',
+                label: t('detail.share', { defaultValue: 'Share' }),
+                type: 'script',
+                locations: ['record_header'],
+                variant: 'outline',
+                onClick: async () => {
+                    try {
+                        if (navigator.share) {
+                            await navigator.share({
+                                title: document.title,
+                                url: window.location.href,
+                            });
+                        }
+                        else {
+                            await navigator.clipboard.writeText(window.location.href);
+                            toast.success(t('detail.linkCopied', { defaultValue: 'Link copied' }));
+                        }
+                    }
+                    catch {
+                        // user dismissed share sheet — no-op
+                    }
+                },
+            });
+            if (affordances.delete) {
+                items.push({
+                    name: 'sys_delete',
+                    label: t('detail.delete', { defaultValue: 'Delete' }),
+                    type: 'script',
+                    locations: ['record_header'],
+                    variant: 'outline',
+                    onClick: async () => {
+                        const msg = t('detail.deleteConfirmation', {
+                            defaultValue: 'Are you sure you want to delete this record?',
+                        });
+                        if (!window.confirm(msg))
+                            return;
+                        try {
+                            await dataSource.delete(objectName, pureRecordId);
+                            toast.success(t('detail.deleted', { defaultValue: 'Record deleted' }));
+                            const baseAppUrl = appName ? `/apps/${appName}` : '';
+                            navigate(`${baseAppUrl}/${objectName}`, { replace: true });
+                        }
+                        catch (err) {
+                            toast.error(err?.message || 'Delete failed');
+                        }
+                    },
+                });
+            }
+            return items;
+        })();
+        // The synth path now hands ONLY business actions to the page schema.
+        // System actions (Edit / Share / Delete) ride through
+        // `RecordContext.headerSystemActions` instead, so they reach both
+        // synth/slotted pages AND authored full-Lightning pages without
+        // mutating the assignedPage tree. `PageHeaderRenderer` dedupes by
+        // name so authored business actions still win on collision.
+        const synthHeaderActions = synthBusinessActions.length > 0 ? synthBusinessActions : undefined;
+        const synthRelated = Array.isArray(detailSchema.related)
+            ? detailSchema.related
+                .filter((r) => r?.api && r?.referenceField)
+                .map((r) => ({
+                title: r.title,
+                objectName: r.api,
+                relationshipField: r.referenceField,
+                ...(Array.isArray(r.columns) ? { columns: r.columns } : {}),
+                ...(typeof r.pageSize === 'number' ? { limit: r.pageSize } : {}),
+                ...(r.icon ? { icon: r.icon } : {}),
+            }))
+            : undefined;
+        const synthHistory = detailSchema.history
+            ? {
+                entries: detailSchema.history.entries ?? [],
+                loading: !!detailSchema.history.loading,
+                emptyText: detailSchema.history.emptyText,
+            }
+            : undefined;
+        const renderedPage = assignedPage
+            ? effectivePage
+            : buildDefaultPageSchema(objectDef, {
+                sections: detailSchema.sections,
+                highlightFields: Array.isArray(detailSchema.highlightFields)
+                    ? detailSchema.highlightFields
+                        .map((f) => (typeof f === 'string' ? f : f?.name))
+                        .filter((n) => !!n)
+                    : undefined,
+                headerActions: synthHeaderActions,
+                related: synthRelated,
+                history: synthHistory,
+                ...(assignedSlots ? { slots: assignedSlots } : {}),
+            });
+        return (_jsxs("div", { className: "h-full bg-background overflow-hidden flex flex-col relative", children: [_jsxs("div", { className: "absolute top-2 sm:top-4 right-2 sm:right-4 z-50 flex items-center gap-2", children: [_jsx(ManagedByBadge, { managedBy: objectDef?.managedBy }), recordViewers.length > 0 && (_jsxs("div", { className: "flex items-center gap-1.5", title: t('recordDetail.viewersTooltip'), children: [_jsx(Users, { className: "h-3.5 w-3.5 text-muted-foreground" }), _jsx(PresenceAvatars, { users: recordViewers, size: "sm", maxVisible: 4, showStatus: true })] }))] }), _jsx(RecordContextProvider, { objectName: objectName, recordId: pureRecordId, data: pageRecord, objectSchema: objectDef, dataSource: dataSource, embedded: embedded, headerSystemActions: synthSystemActions, children: _jsx(HighlightFieldsProvider, { children: _jsx(DiscussionContextProvider, { items: feedItems, onAddComment: handleAddComment, onAddReply: handleAddReply, onToggleReaction: handleToggleReaction, children: _jsx(ActionProvider, { context: { record: pageRecord || {}, objectName, user: currentUser }, onConfirm: confirmHandler, onToast: toastHandler, onNavigate: navigateHandler, onParamCollection: paramCollectionHandler, handlers: { api: apiHandler, flow: flowHandler, script: serverActionHandler, modal: serverActionHandler, approval: approvalHandler }, children: _jsxs("div", { className: "flex-1 overflow-hidden flex flex-row", children: [_jsxs("div", { className: "flex-1 overflow-auto p-3 sm:p-4 lg:p-6 scroll-pb-48", children: [_jsx(SchemaRenderer, { schema: renderedPage }), showAutoDiscussion && (_jsx("div", { className: "mt-6", children: _jsx(RecordChatterPanel, { config: {
+                                                            position: 'bottom',
+                                                            collapsible: false,
+                                                            feed: {
+                                                                enableReactions: true,
+                                                                enableThreading: true,
+                                                                showCommentInput: true,
+                                                            },
+                                                        }, items: feedItems, onAddComment: handleAddComment, onAddReply: handleAddReply, onToggleReaction: handleToggleReaction }) }))] }), _jsx(MetadataPanel, { open: showDebug, sections: [{ title: 'Page Schema', data: renderedPage }] })] }) }) }) }) }), _jsx(ActionConfirmDialog, { state: confirmState, onOpenChange: (open) => {
+                        if (!open)
+                            setConfirmState(s => ({ ...s, open: false }));
+                    } }), _jsx(ActionParamDialog, { state: paramState, onOpenChange: (open) => {
+                        if (!open)
+                            setParamState(s => ({ ...s, open: false }));
+                    } })] }));
     }
     return (_jsxs("div", { className: "h-full bg-background overflow-hidden flex flex-col relative", children: [_jsxs("div", { className: "absolute top-2 sm:top-4 right-2 sm:right-4 z-50 flex items-center gap-2", children: [_jsx(ManagedByBadge, { managedBy: objectDef?.managedBy }), recordViewers.length > 0 && (_jsxs("div", { className: "flex items-center gap-1.5", title: t('recordDetail.viewersTooltip'), children: [_jsx(Users, { className: "h-3.5 w-3.5 text-muted-foreground" }), _jsx(PresenceAvatars, { users: recordViewers, size: "sm", maxVisible: 4, showStatus: true })] }))] }), _jsxs("div", { className: "flex-1 overflow-hidden flex flex-row", children: [_jsx("div", { className: "flex-1 overflow-auto p-3 sm:p-4 lg:p-6 scroll-pb-48", children: _jsx(ActionProvider, { context: { record: {}, objectName, user: currentUser }, onConfirm: confirmHandler, onToast: toastHandler, onNavigate: navigateHandler, onParamCollection: paramCollectionHandler, handlers: { api: apiHandler, flow: flowHandler, script: serverActionHandler, modal: serverActionHandler, approval: approvalHandler }, children: _jsx(DetailView, { schema: detailSchema, dataSource: dataSource, objectLabel: objectLabel({ name: objectDef.name, label: objectDef.label }), onDataLoaded: (record) => {
                                     if (!record || typeof record !== 'object')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@object-ui/app-shell",
-  "version": "4.7.0",
+  "version": "5.0.0",
   "type": "module",
   "license": "MIT",
   "description": "Minimal application shell for ObjectUI - framework-agnostic rendering engine",
@@ -27,34 +27,34 @@
   "dependencies": {
     "lucide-react": "^1.16.0",
     "sonner": "^2.0.7",
-    "@object-ui/auth": "4.7.0",
-    "@object-ui/collaboration": "4.7.0",
-    "@object-ui/components": "4.7.0",
-    "@object-ui/core": "4.7.0",
-    "@object-ui/data-objectstack": "4.7.0",
-    "@object-ui/fields": "4.7.0",
-    "@object-ui/i18n": "4.7.0",
-    "@object-ui/layout": "4.7.0",
-    "@object-ui/permissions": "4.7.0",
-    "@object-ui/react": "4.7.0",
-    "@object-ui/types": "4.7.0"
+    "@object-ui/auth": "5.0.0",
+    "@object-ui/collaboration": "5.0.0",
+    "@object-ui/components": "5.0.0",
+    "@object-ui/core": "5.0.0",
+    "@object-ui/data-objectstack": "5.0.0",
+    "@object-ui/fields": "5.0.0",
+    "@object-ui/i18n": "5.0.0",
+    "@object-ui/layout": "5.0.0",
+    "@object-ui/permissions": "5.0.0",
+    "@object-ui/react": "5.0.0",
+    "@object-ui/types": "5.0.0"
   },
   "peerDependencies": {
     "react": "^18.0.0 || ^19.0.0",
     "react-dom": "^18.0.0 || ^19.0.0",
     "react-router-dom": "^6.0.0 || ^7.0.0",
-    "@object-ui/plugin-calendar": "^4.7.0",
-    "@object-ui/plugin-charts": "^4.7.0",
-    "@object-ui/plugin-chatbot": "^4.7.0",
-    "@object-ui/plugin-dashboard": "^4.7.0",
-    "@object-ui/plugin-designer": "^4.7.0",
-    "@object-ui/plugin-detail": "^4.7.0",
-    "@object-ui/plugin-form": "^4.7.0",
-    "@object-ui/plugin-grid": "^4.7.0",
-    "@object-ui/plugin-kanban": "^4.7.0",
-    "@object-ui/plugin-list": "^4.7.0",
-    "@object-ui/plugin-report": "^4.7.0",
-    "@object-ui/plugin-view": "^4.7.0"
+    "@object-ui/plugin-calendar": "^5.0.0",
+    "@object-ui/plugin-charts": "^5.0.0",
+    "@object-ui/plugin-chatbot": "^5.0.0",
+    "@object-ui/plugin-dashboard": "^5.0.0",
+    "@object-ui/plugin-designer": "^5.0.0",
+    "@object-ui/plugin-detail": "^5.0.0",
+    "@object-ui/plugin-form": "^5.0.0",
+    "@object-ui/plugin-grid": "^5.0.0",
+    "@object-ui/plugin-kanban": "^5.0.0",
+    "@object-ui/plugin-list": "^5.0.0",
+    "@object-ui/plugin-report": "^5.0.0",
+    "@object-ui/plugin-view": "^5.0.0"
   },
   "devDependencies": {
     "@types/node": "^25.9.0",