@object-ui/app-shell 11.3.0 → 11.5.0

package/dist/views/ObjectView.js

@@ -15,7 +15,8 @@ import { parseUserFilterParams, applyUserFilterParams } from './userFilterUrlSta
 const ObjectChart = lazy(() => import('@object-ui/plugin-charts').then((m) => ({ default: m.ObjectChart })));
 const ImportWizard = lazy(() => import('@object-ui/plugin-grid').then((m) => ({ default: m.ImportWizard })));
 import { ListView } from '@object-ui/plugin-list';
-import { ObjectView as PluginObjectView, ViewTabBar, ManageViewsDialog } from '@object-ui/plugin-view';
+import { ObjectView as PluginObjectView, ViewTabBar, ManageViewsDialog, deriveRecordSurface, overlayWidthFor } from '@object-ui/plugin-view';
+import { RECORD_DRAWER_PARAM } from '../urlParams';
 // Plugin registration is handled by the host app (e.g. apps/console/src/main.tsx
 // uses ComponentRegistry.registerLazy so heavy plugins stay code-split).
 // Do NOT add eager `import '@object-ui/plugin-*'` side-effect imports here.
@@ -34,6 +35,8 @@ import { ManagedByBadge } from '../components/ManagedByBadge';
 import { RecordDetailView } from './RecordDetailView';
 import { resolveCrudAffordances } from '../utils/crudAffordances';
 import { resolveManagedByEmptyState } from '../utils/managedByEmptyState';
+import { resolveViewId } from '../utils/resolveViewId';
+import { warnSuppressedListNav } from '../utils/warnSuppressedListNav';
 import { useObjectActions } from '../hooks/useObjectActions';
 import { useObjectTranslation, useObjectLabel } from '@object-ui/i18n';
 import { usePermissions } from '@object-ui/permissions';
@@ -190,8 +193,9 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
                     'updated_by', 'updatedBy', '_version', '_rev',
                 ]);
                 let defaultColumns = [];
-                if (Array.isArray(objectDef?.compactLayout) && objectDef.compactLayout.length > 0) {
-                    defaultColumns = objectDef.compactLayout.filter((n) => objectDef.fields?.[n]);
+                const curated = objectDef?.highlightFields;
+                if (Array.isArray(curated) && curated.length > 0) {
+                    defaultColumns = curated.filter((n) => objectDef.fields?.[n]);
                 }
                 else if (objectDef?.fields) {
                     defaultColumns = Object.entries(objectDef.fields)
@@ -430,7 +434,7 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
     // Resolve Views from objectDef.listViews (camelCase per @objectstack/spec)
     const views = useMemo(() => {
         // Default column resolution priority:
-        //   1. `compactLayout` (curated primary business fields).
+        //   1. The `highlightFields` semantic role (ADR-0085).
         //   2. Business fields only — exclude system-managed identifiers/audit
         //      columns (id, created_at, updated_at, …) and fields explicitly
         //      marked hidden/readonly on the schema. First 5 kept for compactness.
@@ -440,8 +444,9 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
             'updated_by', 'updatedBy', '_version', '_rev',
         ]);
         const resolveDefaultColumns = () => {
-            if (Array.isArray(objectDef.compactLayout) && objectDef.compactLayout.length > 0) {
-                return objectDef.compactLayout.filter((n) => objectDef.fields?.[n]);
+            const curated = objectDef.highlightFields;
+            if (Array.isArray(curated) && curated.length > 0) {
+                return curated.filter((n) => objectDef.fields?.[n]);
             }
             if (objectDef.fields) {
                 return Object.entries(objectDef.fields)
@@ -606,7 +611,20 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
         const def = views.find((v) => v.isDefault);
         return def?.id;
     }, [views]);
-    const activeViewId = viewId || searchParams.get('view') || defaultViewId || views[0]?.id;
+    // Canonical view ids are fully qualified (`<object>.<viewKind>`, see
+    // MetadataProvider), but nav items emit `viewName` verbatim — usually
+    // the short form — and legacy embedded listViews carry bare keys (incl.
+    // the `'all'` fallback). Resolve the URL-requested name in both
+    // directions, and never swallow a miss silently (#2217).
+    const requestedViewId = viewId || searchParams.get('view') || undefined;
+    const resolvedViewId = useMemo(() => resolveViewId(requestedViewId, views.map((v) => v.id), objectDef.name), [requestedViewId, views, objectDef.name]);
+    useEffect(() => {
+        if (requestedViewId && !resolvedViewId) {
+            console.warn(`[ObjectView] Requested view "${requestedViewId}" not found on object "${objectDef.name}"; ` +
+                `falling back to the default view. Known views: ${views.map((v) => v.id).join(', ')}`);
+        }
+    }, [requestedViewId, resolvedViewId, objectDef.name, views]);
+    const activeViewId = resolvedViewId || defaultViewId || views[0]?.id;
     const baseView = views.find((v) => v.id === activeViewId) || views[0];
     const activeView = viewDraft && viewDraft.id === baseView?.id
         ? { ...baseView, ...viewDraft }
@@ -874,9 +892,27 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
     // RecordDetailView owns its own route — only same-page click navigation
     // is drawer-by-default. Per-view config can still override (e.g. a heavy
     // detail object can set `navigation.mode = 'page'`).
-    const detailNavigation = useMemo(() => activeView?.navigation ??
-        objectDef.navigation ?? { mode: 'drawer', width: 'min(92vw, 1280px)' }, [activeView?.navigation, objectDef.navigation]);
-    const drawerRecordId = searchParams.get('recordId');
+    const detailNavigation = useMemo(() => {
+        const authored = activeView?.navigation ?? objectDef.navigation;
+        if (authored) {
+            // Authored config wins. For an overlay, resolve the `size`
+            // bucket (or 'auto') to a viewport-clamped width when no explicit
+            // width was given — #2578: a pixel width can't be authored blind.
+            if (authored.mode === 'page')
+                return authored;
+            return {
+                ...authored,
+                width: authored.width ?? overlayWidthFor(authored.size, objectDef),
+            };
+        }
+        // #2578: derive surface + width from FIELD COUNT. Field-heavy → full
+        // page (cramped in a drawer); light → a drawer sized to the content
+        // and clamped to the viewport. Mobile always pages (in deriveRecordSurface).
+        return deriveRecordSurface(objectDef) === 'page'
+            ? { mode: 'page' }
+            : { mode: 'drawer', width: overlayWidthFor('auto', objectDef) };
+    }, [activeView?.navigation, objectDef]);
+    const drawerRecordId = searchParams.get(RECORD_DRAWER_PARAM);
     /**
      * URL-derived equality filters in the form `?filter[<field>]=<value>`.
      * Used by related-list "View All" buttons to scope the destination list
@@ -945,7 +981,7 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
     const handleDrawerClose = () => {
         navOverlay.close();
         const newParams = new URLSearchParams(searchParams);
-        newParams.delete('recordId');
+        newParams.delete(RECORD_DRAWER_PARAM);
         setSearchParams(newParams);
     };
     /**
@@ -969,7 +1005,7 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
             const id = (record?.id ?? record?._id);
             if (id != null) {
                 const next = new URLSearchParams(searchParams);
-                next.set('recordId', String(id));
+                next.set(RECORD_DRAWER_PARAM, String(id));
                 setSearchParams(next);
                 return;
             }
@@ -1066,6 +1102,11 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
                         className: 'h-[400px] w-full',
                     } }) }, key));
         }
+        // ADR-0053 wrong-context authoring: userFilters/quickFilters on an
+        // object list view are suppressed below — say so instead of letting
+        // the author stare at a toolbar with nothing where their filter
+        // controls should be (#2219).
+        warnSuppressedListNav(objectDef.name, viewDef.id || viewDef.name || '', viewDef, listSchema);
         const fullSchema = {
             ...listSchema,
             // Propagate appearance/view-config properties for live preview
@@ -1369,11 +1410,22 @@ function ObjectViewInner({ dataSource, objects, onEdit, externalRefreshKey }) {
                                             // Import buttons stay visible without pushing the page
                                             // title off-screen.
                                             mobileMaxVisible: 0,
-                                        } })))] }) }) }), affordances.create && can(objectDef.name, 'create') && (_jsx("button", { type: "button", onClick: actions.create, className: "sm:hidden fixed right-4 bottom-36 z-40 h-12 w-12 rounded-full bg-primary text-primary-foreground shadow-lg active:scale-95 transition-transform inline-flex items-center justify-center", "aria-label": t('console.objectView.new'), "data-testid": "mobile-fab-create", children: _jsx(Plus, { className: "h-5 w-5" }) })), showImport && (_jsx(Suspense, { fallback: null, children: _jsx(ImportWizard, { open: showImport, onOpenChange: setShowImport, objectName: objectDef.name, objectLabel: objectLabel(objectDef), fields: Object.entries(objectDef.fields || {}).map(([name, def]) => ({
+                                        } })))] }) }) }), affordances.create && can(objectDef.name, 'create') && (_jsx("button", { type: "button", onClick: actions.create, className: "sm:hidden fixed right-4 bottom-36 z-40 h-12 w-12 rounded-full bg-primary text-primary-foreground shadow-lg active:scale-95 transition-transform inline-flex items-center justify-center", "aria-label": t('console.objectView.new'), "data-testid": "mobile-fab-create", children: _jsx(Plus, { className: "h-5 w-5" }) })), showImport && (_jsx(Suspense, { fallback: null, children: _jsx(ImportWizard, { open: showImport, onOpenChange: setShowImport, objectName: objectDef.name, objectLabel: objectLabel(objectDef), fields: Object.entries(objectDef.fields || {})
+                                // Only writable fields are importable targets. Computed
+                                // types (formula/summary/autonumber) and fields flagged
+                                // readonly / write:false are server-rejected, so we omit
+                                // them from the mapping step rather than let a user map to
+                                // a column the import will silently drop.
+                                .filter(([, def]) => !['formula', 'summary', 'autonumber'].includes(def?.type) &&
+                                !def?.readonly &&
+                                def?.permissions?.write !== false)
+                                .map(([name, def]) => ({
                                 name,
                                 label: def?.label || name,
                                 type: def?.type || 'text',
                                 required: !!def?.required,
+                                // Enum options seed the downloadable template's example row.
+                                ...(def?.options ? { options: def.options } : {}),
                             })), dataSource: dataSource, onComplete: (result) => {
                                 setRefreshKey(k => k + 1);
                                 const ok = result.importedRows;