@nyx-intelligence/val-mcp 0.5.0 → 0.5.4

package/dist/index.js

@@ -66,7 +66,7 @@ async function runServer() {
     const { StdioServerTransport } = await import("@modelcontextprotocol/sdk/server/stdio.js");
     const { chromium } = await import("playwright");
     const { z } = await import("zod");
-    const server = new McpServer({ name: "val", version: "0.5.0" });
+    const server = new McpServer({ name: "val", version: "0.5.4" });
     const text = (t) => ({ content: [{ type: "text", text: t }] });
     // ── Passive crawl ──
     server.registerTool("val_scan", {

package/dist/session.js

@@ -153,9 +153,41 @@ class ValSession {
                 const r = el.getBoundingClientRect();
                 return r.width > 0 && r.height > 0;
             };
-            const els = Array.from(document.querySelectorAll("button, [role=button]")).filter(isVisible);
+            // Skip buttons that are toggles / segmented-control items / already-active
+            // controls — clicking them is a legitimate no-op, not a dead control.
+            const TOGGLE_ROLES = ["tab", "switch", "radio", "option", "menuitemradio", "menuitemcheckbox"];
+            const CONTAINER_ROLES = ["tablist", "radiogroup", "listbox", "menu", "tabs"];
+            const ACTIVE_CLASS = /(^|\s|-)(active|selected|is-active|is-selected|current|is-current)(\s|$|-)/i;
+            const isToggleLike = (el) => {
+                if (el.hasAttribute("disabled") || el.getAttribute("aria-disabled") === "true")
+                    return true;
+                if (el.hasAttribute("aria-pressed") || el.hasAttribute("aria-selected"))
+                    return true;
+                const ac = el.getAttribute("aria-current");
+                if (ac && ac !== "false")
+                    return true;
+                const role = el.getAttribute("role");
+                if (role && TOGGLE_ROLES.indexOf(role) >= 0)
+                    return true;
+                if (ACTIVE_CLASS.test(el.getAttribute("class") || ""))
+                    return true;
+                let p = el.parentElement;
+                while (p) {
+                    const r = p.getAttribute("role");
+                    if (r && CONTAINER_ROLES.indexOf(r) >= 0)
+                        return true;
+                    p = p.parentElement;
+                }
+                return false;
+            };
+            const els = Array.from(document.querySelectorAll("button, [role=button]"))
+                .filter(isVisible)
+                .filter((el) => !isToggleLike(el));
             els.forEach((el, i) => el.setAttribute("data-val-ex", `e${i}`));
-            return els.map((el, i) => ({ ref: `e${i}`, text: (el.innerText || el.getAttribute("aria-label") || "").trim().slice(0, 40) }));
+            return els.map((el, i) => ({
+                ref: `e${i}`,
+                text: (el.innerText || el.getAttribute("aria-label") || "").trim().slice(0, 40),
+            }));
         });
         const buttons = await tag();
         const dead = [];
@@ -163,13 +195,41 @@ class ValSession {
         const startUrl = page.url();
         for (const b of buttons) {
             this.drain();
-            const before = await this.sig();
             try {
+                const before = await this.sig();
                 const loc = page.locator(`[data-val-ex="${b.ref}"]`);
                 if ((await loc.count()) === 0)
                     continue;
+                // Install mutation watcher BEFORE the click. The handler can mutate
+                // the DOM synchronously and finish before we start observing — we'd
+                // then wait 800ms for nothing and falsely flag the button dead.
+                // Watch ANY mutation: node added/removed (modal, dropdown), attribute
+                // changed (`value=`, `style`, `aria-*` — React preset buttons), or
+                // text changed (counters, totals). Anything = the click did something.
+                await page.evaluate(() => {
+                    const w = window;
+                    w.__valMut = false;
+                    const obs = new MutationObserver(() => {
+                        w.__valMut = true;
+                    });
+                    obs.observe(document.body, {
+                        childList: true,
+                        subtree: true,
+                        attributes: true,
+                        characterData: true,
+                    });
+                    w.__valObs = obs;
+                });
                 await loc.click({ timeout: 4000 });
-                await page.waitForTimeout(400);
+                await page.waitForTimeout(800);
+                const mutated = await page
+                    .evaluate(() => {
+                    const w = window;
+                    const m = !!w.__valMut;
+                    w.__valObs?.disconnect();
+                    return m;
+                })
+                    .catch(() => false);
                 if (page.url() !== startUrl) {
                     await page.goBack({ waitUntil: "load" }).catch(() => { });
                     await page.waitForTimeout(300);
@@ -179,14 +239,35 @@ class ValSession {
                 const after = await this.sig();
                 const errs = this.drain();
                 const label = b.text || b.ref;
-                const moved = after.nodes !== before.nodes || Math.abs(after.text - before.text) > 3;
+                const sigChanged = after.nodes !== before.nodes || Math.abs(after.text - before.text) > 3;
+                const moved = mutated || sigChanged;
                 if (errs.newPageErrors.length)
                     errored.push({ el: label, error: errs.newPageErrors[0] });
                 else if (!moved && errs.newConsoleErrors.length === 0 && errs.newNetworkErrors.length === 0)
                     dead.push(label);
             }
             catch (e) {
-                errored.push({ el: b.text || b.ref, error: e instanceof Error ? e.message : String(e) });
+                const msg = e instanceof Error ? e.message : String(e);
+                // SPA navigations can destroy our eval context mid-probe — recover silently,
+                // don't flag the click as an error of the page under test.
+                if (/Execution context was destroyed|Target closed|frame got detached|Navigation/i.test(msg)) {
+                    try {
+                        if (page.url() !== startUrl) {
+                            await page.goBack({ waitUntil: "load" }).catch(() => { });
+                            await page.waitForTimeout(300);
+                        }
+                        else {
+                            await page.waitForLoadState("load", { timeout: 2000 }).catch(() => { });
+                        }
+                        await tag();
+                    }
+                    catch {
+                        /* nothing more we can do */
+                    }
+                }
+                else {
+                    errored.push({ el: b.text || b.ref, error: msg });
+                }
             }
         }
         return { tested: buttons.length, dead, errored };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nyx-intelligence/val-mcp",
-  "version": "0.5.0",
+  "version": "0.5.4",
   "description": "Val — a 100% MCP QA agent for vibecoders. Drives a real browser to catch UX bugs (broken links, 404s, console errors, broken images) so your coding agent can fix them.",
   "type": "module",
   "license": "UNLICENSED",