@nyssance/codex-acp-v2 0.7.13 → 0.7.14

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 0.7.14 — 2026-10-16
+
+### Added
+
+- Sub-agent activity carries `model` and `reasoningEffort` in `rawInput` and `_meta.codex.subagent`.
+
+### Changed
+
+- Generated against Codex 0.163.0 (`@openai/codex` ^0.163.0); the version floor follows.
+  `generate-types` clears `src/app-server` first, so types Codex removed no longer linger.
+- Command approvals offer exactly the `availableDecisions` Codex sends; a missing list, or one naming
+  an amendment Codex did not propose, is cancelled. The adapter no longer builds its own decision set.
+- Review exits produce no update: Codex follows every exit with an assistant message carrying the
+  conclusion, and the adapter maps that message. Exit buffering and deduplication are removed.
+- Fast mode availability reads `serviceTiers` only; the deprecated `additionalSpeedTiers` is ignored.
+- `codexErrorInfo` values Codex has no name for classify as `unknown`.
+
 ## 0.7.13 — 2026-10-13
 
 ### Fixed

package/README.md

@@ -59,7 +59,7 @@ See [`docs/protocol.md`](docs/protocol.md) for the exact wire contract.
 
 ## Requirements
 
-- Codex CLI **0.158.0 or newer** — the app-server types under `src/app-server` are generated
+- Codex CLI **0.163.0 or newer** — the app-server types under `src/app-server` are generated
   from the `@openai/codex` release named in `optionalDependencies`, and the agent checks
   `codex --version` before starting the server; an older Codex fails at startup with an
   upgrade hint.

package/dist/index.js

@@ -22168,7 +22168,7 @@ var package_default = {
   publishConfig: {
     access: "public"
   },
-  version: "0.7.13",
+  version: "0.7.14",
   description: "Native ACP v2 agent for the OpenAI Codex app-server",
   packageManager: "bun@1.4.0",
   engines: {
@@ -22203,7 +22203,7 @@ var package_default = {
     "package:win-x64": "cd dist/bin && zip codex-acp-v2-x64-windows.zip codex-acp-v2-x64-windows.exe",
     "package:win-arm64": "cd dist/bin && zip codex-acp-v2-arm64-windows.zip codex-acp-v2-arm64-windows.exe",
     start: "bun src/index.ts",
-    "generate-types": "codex app-server generate-ts --experimental --out src/app-server",
+    "generate-types": "rm -rf src/app-server && codex app-server generate-ts --experimental --out src/app-server",
     test: "vitest run --exclude src/__tests__/e2e.test.ts",
     "test:watch": "vitest",
     typecheck: "tsc --noEmit",
@@ -22241,7 +22241,7 @@ var package_default = {
     "vscode-jsonrpc": "^9.0.2"
   },
   optionalDependencies: {
-    "@openai/codex": "^0.159.2"
+    "@openai/codex": "^0.163.0"
   }
 };
 
@@ -22385,6 +22385,7 @@ class ClientTools {
 }
 
 // src/agent/turnErrors.ts
+var CONNECTION_FAILURES = ["httpConnectionFailed", "responseStreamConnectionFailed", "responseStreamDisconnected", "responseTooManyFailedAttempts"];
 function classifyTurnError(info) {
   const failure2 = (category, retryable = false, stopReason = "error") => ({ category, retryable, stopReason });
   if (info === null)
@@ -22392,7 +22393,9 @@ function classifyTurnError(info) {
   if (typeof info === "object") {
     if ("activeTurnNotSteerable" in info)
       return failure2("turn_not_steerable");
-    const status = "httpConnectionFailed" in info ? info.httpConnectionFailed.httpStatusCode : ("responseStreamConnectionFailed" in info) ? info.responseStreamConnectionFailed.httpStatusCode : ("responseStreamDisconnected" in info) ? info.responseStreamDisconnected.httpStatusCode : info.responseTooManyFailedAttempts.httpStatusCode;
+    const status = connectionStatus(info);
+    if (status === undefined)
+      return failure2("unknown");
     return failure2("connection", status === null || status === 408 || status === 429 || status >= 500);
   }
   switch (info) {
@@ -22426,6 +22429,14 @@ function classifyTurnError(info) {
     case "other":
       return failure2("unknown");
   }
+  return failure2("unknown");
+}
+function connectionStatus(info) {
+  for (const key of CONNECTION_FAILURES) {
+    if (key in info)
+      return info[key].httpStatusCode;
+  }
+  return;
 }
 
 // src/agent/CodexAgent.ts
@@ -23672,8 +23683,8 @@ function subAgentActivity(item, status, create) {
     toolCallId: item.id,
     ...create ? { name: ToolName.SubAgent, title: titles[item.kind], kind: "other" } : {},
     status,
-    rawInput: { agentThreadId: item.agentThreadId, agentPath: item.agentPath, activity: item.kind },
-    _meta: { codex: { subagent: { threadId: item.agentThreadId, path: item.agentPath, activity: item.kind } } }
+    rawInput: { model: item.model, reasoningEffort: item.reasoningEffort, agentThreadId: item.agentThreadId, agentPath: item.agentPath, activity: item.kind },
+    _meta: { codex: { subagent: { model: item.model, reasoningEffort: item.reasoningEffort, threadId: item.agentThreadId, path: item.agentPath, activity: item.kind } } }
   });
 }
 function collabToolCall(item, create) {
@@ -24263,23 +24274,14 @@ function itemSnapshot(item, command) {
     case "contextCompaction":
       return [compactionUpdate(item.id, "completed")];
     case "enteredReviewMode":
+    case "exitedReviewMode":
       return [];
-    case "exitedReviewMode": {
-      const text = item.review.trim();
-      return text.length > 0 ? [{ sessionUpdate: "agent_message", messageId: item.id, content: [{ type: "text", text }] }] : [];
-    }
     case "hookPrompt":
     case "functionCallOutput":
     case "sleep":
       return [];
   }
 }
-function isDuplicateReview(item, items) {
-  if (item.type !== "exitedReviewMode")
-    return false;
-  const text = item.review.trim();
-  return text.length > 0 && Array.from(items).some((candidate) => candidate.type === "agentMessage" && candidate.phase !== "commentary" && candidate.text.trim() === text);
-}
 
 // src/bridge/turnMetadata.ts
 function withTurnId(update, turnId, startedAt) {
@@ -24321,8 +24323,6 @@ class EventBridge {
   turnPrompt = null;
   openToolCalls = new Set;
   announcedTools = new Set;
-  pendingReviews = new Map;
-  reviewMessages = new Map;
   messagePhases = new Map;
   promptMeta = new Map;
   reasoningWithDeltas = new Set;
@@ -24386,8 +24386,6 @@ class EventBridge {
     this.openToolCalls.clear();
     this.announcedTools.clear();
     this.messagePhases.clear();
-    this.reviewMessages.clear();
-    this.pendingReviews.clear();
     this.reasoningWithDeltas.clear();
     this.terminalItems.clear();
     this.imageGenerations.clear();
@@ -24410,8 +24408,6 @@ class EventBridge {
     for (const item of items) {
       if (item.type === "userMessage")
         this.unresolvedUserItems.add(item.id);
-      if (item.type === "agentMessage")
-        this.reviewMessages.set(item.id, item);
       if (!replay && itemSnapshot(item).some((update) => update.sessionUpdate === "tool_call_update")) {
         this.unannouncedItems.set(item.id, { item, turnId });
       }
@@ -24424,12 +24420,8 @@ class EventBridge {
       if (receipt)
         this.restoredCommands.set(item.id, receipt);
       this.unresolvedUserItems.delete(item.id);
-      if (!replay || isDuplicateReview(item, this.reviewMessages.values()))
-        continue;
-      if (item.type === "exitedReviewMode") {
-        this.pendingReviews.set(item.id, { item, turnId });
+      if (!replay)
         continue;
-      }
       if (item.type === "commandExecution" && item.status === "inProgress" && usesTerminal(item))
         this.terminalItems.add(item.id);
       for (const update of itemSnapshot(item, receipt ?? undefined)) {
@@ -24549,7 +24541,6 @@ class EventBridge {
     }
   }
   async finishOpenToolCalls(status) {
-    await this.flushReviews();
     this.unannouncedItems.clear();
     const ids = [...this.openToolCalls];
     const terminals = [...this.terminalItems];
@@ -24574,18 +24565,6 @@ class EventBridge {
   }
   async flush() {
     await this.flushPlans();
-    await this.flushReviews();
-  }
-  async flushReviews() {
-    const pending = [...this.pendingReviews.values()];
-    this.pendingReviews.clear();
-    for (const { item, turnId } of pending) {
-      if (isDuplicateReview(item, this.reviewMessages.values()))
-        continue;
-      for (const update of itemSnapshot(item)) {
-        await this.client.update(this.withTiming(withTurnId(update, turnId, this.turnTime?.startedAt), turnId));
-      }
-    }
   }
   dispose() {
     this.beginTurn();
@@ -24709,6 +24688,8 @@ ${details}` : summary)];
       case "thread/settings/updated":
       case "thread/goal/updated":
       case "thread/goal/cleared":
+      case "thread/readState/changed":
+      case "thread/prediction/updated":
       case "thread/project/updated":
       case "thread/environment/connected":
       case "thread/environment/disconnected":
@@ -24825,7 +24806,6 @@ ${details}` : summary)];
   async itemCompleted(item, turnId) {
     switch (item.type) {
       case "agentMessage":
-        this.reviewMessages.set(item.id, item);
         this.messagePhases.delete(item.id);
         return itemSnapshot(item);
       case "reasoning": {
@@ -24864,15 +24844,12 @@ ${details}` : summary)];
         return [compactionUpdate(item.id, "completed")];
       case "plan":
         return await this.planCompleted(item);
-      case "exitedReviewMode": {
-        this.pendingReviews.set(item.id, { item, turnId });
-        return [];
-      }
       case "userMessage":
       case "hookPrompt":
       case "functionCallOutput":
       case "sleep":
       case "enteredReviewMode":
+      case "exitedReviewMode":
         return [];
     }
   }
@@ -25224,6 +25201,7 @@ class AppServerClient {
       threadId,
       turn: {
         id: turnId,
+        rootTurnId: null,
         items: [],
         itemsView: "notLoaded",
         status: "interrupted",
@@ -25237,7 +25215,7 @@ class AppServerClient {
   failTurn(threadId, turnId, error40) {
     this.recordTurnCompleted({
       threadId,
-      turn: { id: turnId, items: [], itemsView: "notLoaded", status: "failed", error: error40, startedAt: null, completedAt: null, durationMs: null }
+      turn: { id: turnId, rootTurnId: null, items: [], itemsView: "notLoaded", status: "failed", error: error40, startedAt: null, completedAt: null, durationMs: null }
     });
   }
   recordTurnCompleted(event) {
@@ -25975,9 +25953,7 @@ function coerceEffort(model, effort) {
   return model?.defaultReasoningEffort ?? options[0].reasoningEffort;
 }
 function modelSupportsFast(model) {
-  if (!model)
-    return false;
-  return model.serviceTiers.some((tier) => tier.id === FAST_SERVICE_TIER) || model.additionalSpeedTiers.includes(FAST_SERVICE_TIER);
+  return model?.serviceTiers.some((tier) => tier.id === FAST_SERVICE_TIER) ?? false;
 }
 function modelSupportsImages(model) {
   return model?.inputModalities.includes("image") ?? true;
@@ -26077,81 +26053,20 @@ function capitalize(value) {
 
 // src/permissions/commandDecisions.ts
 function availableCommandDecisions(params) {
-  if (params.availableDecisions === undefined || params.availableDecisions === null) {
-    return defaultDecisions(params);
-  }
-  if (!Array.isArray(params.availableDecisions) || params.availableDecisions.length === 0)
+  const decisions = params.availableDecisions;
+  if (!decisions || decisions.length === 0)
     return;
-  const decisions = [];
-  for (const candidate of params.availableDecisions) {
-    const decision = parseDecision(candidate, params);
-    if (!decision)
-      return;
-    decisions.push(decision);
-  }
-  return decisions;
-}
-function defaultDecisions(params) {
-  if (params.networkApprovalContext) {
-    const decisions2 = ["accept", "acceptForSession"];
-    for (const amendment of params.proposedNetworkPolicyAmendments ?? []) {
-      decisions2.push({ applyNetworkPolicyAmendment: { network_policy_amendment: amendment } });
-    }
-    decisions2.push("decline", "cancel");
-    return decisions2;
-  }
-  if (params.additionalPermissions)
-    return ["accept", "cancel"];
-  const decisions = ["accept", "acceptForSession"];
-  if (params.proposedExecpolicyAmendment && params.proposedExecpolicyAmendment.length > 0) {
-    decisions.push({ acceptWithExecpolicyAmendment: { execpolicy_amendment: params.proposedExecpolicyAmendment } });
-  }
-  decisions.push("decline", "cancel");
-  return decisions;
+  return decisions.every((decision) => proposed(decision, params)) ? decisions : undefined;
 }
-function parseDecision(candidate, params) {
-  if (candidate === "accept" || candidate === "acceptForSession" || candidate === "decline" || candidate === "cancel") {
-    return candidate;
-  }
-  if (!isRecord2(candidate))
-    return;
-  if ("acceptWithExecpolicyAmendment" in candidate) {
-    const value = candidate["acceptWithExecpolicyAmendment"];
-    if (!isRecord2(value))
-      return;
-    const amendment = value["execpolicy_amendment"];
-    if (!isStringArray(amendment) || amendment.length === 0)
-      return;
-    if (!sameStrings(amendment, params.proposedExecpolicyAmendment))
-      return;
-    return { acceptWithExecpolicyAmendment: { execpolicy_amendment: [...amendment] } };
-  }
-  if ("applyNetworkPolicyAmendment" in candidate) {
-    const value = candidate["applyNetworkPolicyAmendment"];
-    if (!isRecord2(value))
-      return;
-    const amendment = parseNetworkAmendment(value["network_policy_amendment"]);
-    if (!amendment || !params.networkApprovalContext)
-      return;
-    if (amendment.host !== params.networkApprovalContext.host)
-      return;
-    const proposed = params.proposedNetworkPolicyAmendments ?? [];
-    if (!proposed.some((entry) => entry.host === amendment.host && entry.action === amendment.action))
-      return;
-    return { applyNetworkPolicyAmendment: { network_policy_amendment: amendment } };
+function proposed(decision, params) {
+  if (typeof decision === "string")
+    return true;
+  if ("acceptWithExecpolicyAmendment" in decision) {
+    const amendment2 = decision.acceptWithExecpolicyAmendment.execpolicy_amendment;
+    return amendment2.length > 0 && sameStrings(amendment2, params.proposedExecpolicyAmendment);
   }
-  return;
-}
-function parseNetworkAmendment(value) {
-  if (!isRecord2(value) || typeof value["host"] !== "string")
-    return;
-  const action = value["action"];
-  if (action !== "allow" && action !== "deny")
-    return;
-  return { host: value["host"], action };
-}
-function isStringArray(value) {
-  return Array.isArray(value) && value.every((entry) => typeof entry === "string");
+  const amendment = decision.applyNetworkPolicyAmendment.network_policy_amendment;
+  return amendment.host === params.networkApprovalContext?.host && (params.proposedNetworkPolicyAmendments ?? []).some((entry) => entry.host === amendment.host && entry.action === amendment.action);
 }
 function sameStrings(left, right) {
   return !!right && left.length === right.length && left.every((value, index) => value === right[index]);
@@ -26394,8 +26309,7 @@ class CodexApprovalHandler {
     this.signal = signal;
   }
   async handleCommandExecution(params) {
-    const approvalParams = params;
-    const decisions = commandDecisionOptions(approvalParams);
+    const decisions = commandDecisionOptions(params);
     if (!decisions) {
       logger.log("cancelling command approval: no complete decision set", { itemId: params.itemId });
       return { decision: "cancel" };
@@ -26404,7 +26318,7 @@ class CodexApprovalHandler {
       const response = await this.client.requestPermission({
         title: params.networkApprovalContext ? NETWORK_TITLE : COMMAND_TITLE,
         description: nonBlank(params.reason),
-        subject: { type: "tool_call", toolCall: commandSubject(approvalParams) },
+        subject: { type: "tool_call", toolCall: commandSubject(params) },
         options: decisions.map(({ option }) => option)
       }, this.signal());
       return { decision: selectedDecision(response, decisions) ?? "cancel" };
@@ -28037,8 +27951,6 @@ function historyUpdates(turns, commandReceipts = new Map) {
   for (const turn of turns) {
     const openingUser = turn.items.find((item) => item.type === "userMessage");
     for (const item of turn.items) {
-      if (isDuplicateReview(item, turn.items))
-        continue;
       const command = item.type === "userMessage" ? commandReceipts.get(item.id) : undefined;
       updates.push(...itemSnapshot(item, command).map((update) => {
         const replay = withTurnId(update, turn.id, turn.startedAt);
@@ -28302,7 +28214,7 @@ async function readSessionHistory(codex, raw, signal, commandReceipts) {
   if (view === "full")
     await read.call(() => assertCommandHistory(codex, start.thread, commandReceipts, signal));
   const turns = await read.call(() => Promise.all(page.data.map(async (turn) => {
-    const projections = view === "full" ? await Promise.all(turn.items.filter((item) => !isDuplicateReview(item, turn.items)).map(async (item) => projectHistoryItem(item, turn.id, turn.startedAt, item.type === "userMessage" ? await commandReceipts?.read(item.id) : null))) : [];
+    const projections = view === "full" ? await Promise.all(turn.items.map(async (item) => projectHistoryItem(item, turn.id, turn.startedAt, item.type === "userMessage" ? await commandReceipts?.read(item.id) : null))) : [];
     return {
       turnId: turn.id,
       status: turn.status,
@@ -30091,7 +30003,7 @@ function usageOf(session) {
 function interruptedTurn(threadId) {
   return {
     threadId,
-    turn: { id: "", items: [], itemsView: "notLoaded", status: "interrupted", error: null, startedAt: null, completedAt: null, durationMs: null }
+    turn: { id: "", rootTurnId: null, items: [], itemsView: "notLoaded", status: "interrupted", error: null, startedAt: null, completedAt: null, durationMs: null }
   };
 }
 function parseSessionListParams(raw) {

package/docs/protocol.md

@@ -490,7 +490,7 @@ to status `cancelled`, and a cancelled turn marks every still-open tool call
 | `web_search` | `fetch` | web search |
 | `view_image` | `read` | image view |
 | `image_generation` | `other` | image generation; result as image content |
-| `subagent`, `collab` | `other` | sub-agent activity and collaboration calls; `_meta.codex.subagent` / `_meta.codex.collaboration` |
+| `subagent`, `collab` | `other` | sub-agent activity and collaboration calls; `_meta.codex.subagent` (`model`, `reasoningEffort`, `threadId`, `path`, `activity`) / `_meta.codex.collaboration` |
 | `fuzzy_file_search` | `search` | Codex fuzzy file search sessions |
 | `guardian_review` | `think` | auto-approval reviews |
 | `mcp_startup` | `other` | failed MCP server startups (status `failed`) |
@@ -505,7 +505,7 @@ unknown ids, and transport errors fail closed.
 
 | Title | Options (`optionId` → Codex decision) |
 | --- | --- |
-| `Run command?` / `Allow network access?` | `allow_once` → accept, `allow_for_session` → acceptForSession, `accept_execpolicy_amendment` → acceptWithExecpolicyAmendment, `apply_network_policy_amendment:<n>` → applyNetworkPolicyAmendment, `decline`, `cancel`. When Codex sends `availableDecisions` that list is authoritative. |
+| `Run command?` / `Allow network access?` | `allow_once` → accept, `allow_for_session` → acceptForSession, `accept_execpolicy_amendment` → acceptWithExecpolicyAmendment, `apply_network_policy_amendment:<n>` → applyNetworkPolicyAmendment, `decline`, `cancel`. Codex always sends `availableDecisions` and that list is authoritative; a missing list, or one naming an amendment Codex did not propose, fails closed with `cancel`. |
 | `Make edits?` | `allow_once` → accept, `allow_for_session` → acceptForSession, `cancel` |
 | `Grant permissions?` | `allow_permissions_turn`, `allow_permissions_turn_strict_auto_review`, `allow_permissions_session`, `reject_permissions` |
 | MCP approvals | `allow_once` / `accept`, `allow_session`, `allow_always` (only when Codex advertises `persist`), `decline`, `cancel` |
@@ -777,11 +777,9 @@ also contains ordered `{text, question?}` display parts. Receipt-adopting client
 that retain optimistic prompt content use these parts for display and copying;
 this does not alter the original input sent to Codex.
 
-Review results: when `exitedReviewMode.review` repeats a non-commentary agent message
-in the same turn, live updates and full-turn history omit the duplicate exit message.
-Review exits are buffered until the terminal drain to cover either native event order.
-A standalone or different review result remains visible. Item-level history retains
-its per-item projection because the matching answer may be outside the requested page.
+Review results: Codex follows every `exitedReviewMode` item with an assistant message
+carrying the same conclusion, including the notice for an interrupted review. The adapter
+maps only that message; review entry and exit markers produce no updates, live or in history.
 
 ### Plugin enablement
 

package/package.json

@@ -3,7 +3,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "0.7.13",
+  "version": "0.7.14",
   "description": "Native ACP v2 agent for the OpenAI Codex app-server",
   "packageManager": "bun@1.4.0",
   "engines": {
@@ -38,7 +38,7 @@
     "package:win-x64": "cd dist/bin && zip codex-acp-v2-x64-windows.zip codex-acp-v2-x64-windows.exe",
     "package:win-arm64": "cd dist/bin && zip codex-acp-v2-arm64-windows.zip codex-acp-v2-arm64-windows.exe",
     "start": "bun src/index.ts",
-    "generate-types": "codex app-server generate-ts --experimental --out src/app-server",
+    "generate-types": "rm -rf src/app-server && codex app-server generate-ts --experimental --out src/app-server",
     "test": "vitest run --exclude src/__tests__/e2e.test.ts",
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit",
@@ -76,6 +76,6 @@
     "vscode-jsonrpc": "^9.0.2"
   },
   "optionalDependencies": {
-    "@openai/codex": "^0.159.2"
+    "@openai/codex": "^0.163.0"
   }
 }