@nypl/design-system-react-components 0.25.0 → 0.25.4

package/src/components/Pagination/Pagination.stories.tsx

@@ -1,17 +1,19 @@
-import React, { useEffect, useState } from "react";
+import React from "react";
 import { Story } from "@storybook/react/types-6-0";
 
 import Pagination, { PaginationProps } from "./Pagination";
 
 /**
  * PaginationGetPageHref will refresh the browser as a new page is selected.
+ * In this example, `getPageHref` creates the `href` attribute for each
+ * page URL.
  */
 export const PaginationGetPageHref: Story<PaginationProps> = (args) => {
   // This uses the `addon-queryparams` Storybook addon.
   const urlParams = new URLSearchParams(document.location.search);
   const pageParam = urlParams.get("page");
   const getPageNumber = (page: number, pageCount: number) => {
-    return page > 0 && page < pageCount ? page : 1;
+    return page > 0 && page <= pageCount ? page : 1;
   };
   const computedCurrentPage =
     pageParam &&
@@ -20,15 +22,14 @@ export const PaginationGetPageHref: Story<PaginationProps> = (args) => {
   const location = window.location;
   // Passing this function into `Pagination` makes the URL to change
   // and refreshes the page.
-  const getPageHref = (page) => {
-    const currentStoryId = urlParams.get("id");
-    return `${location.origin}?path=/story/${currentStoryId}&page=${page}`;
+  const getPageHref = (selectedPage) => {
+    return `${location.href}&page=${selectedPage}`;
   };
 
   return (
     <Pagination
       pageCount={args.pageCount}
-      currentPage={computedCurrentPage || args.currentPage}
+      initialPage={computedCurrentPage || args.initialPage}
       getPageHref={getPageHref}
     />
   );
@@ -39,20 +40,14 @@ export const PaginationGetPageHref: Story<PaginationProps> = (args) => {
  * selected but will not change the URL or refresh the page.
  */
 export const PaginationOnPageChange: Story<PaginationProps> = (args) => {
-  const [computedCurrentPage, setComputedCurrentPage] = useState(
-    args.currentPage
-  );
-  const onPageChange = (page: number) => setComputedCurrentPage(page);
-
-  // Allows storybook controls to control `currentPage` prop.
-  useEffect(() => {
-    setComputedCurrentPage(args.currentPage);
-  }, [args.currentPage]);
+  const onPageChange = (currentPage: number) => {
+    console.log(`Current page: ${currentPage}`);
+  };
 
   return (
     <Pagination
       pageCount={args.pageCount}
-      currentPage={computedCurrentPage}
+      initialPage={args.initialPage}
       onPageChange={onPageChange}
     />
   );

package/src/components/Pagination/Pagination.test.tsx

@@ -1,172 +1,308 @@
 import * as React from "react";
-import { render, screen } from "@testing-library/react";
+import { render, screen, within } from "@testing-library/react";
 import { axe } from "jest-axe";
 import userEvent from "@testing-library/user-event";
+import renderer from "react-test-renderer";
 
 import Pagination from "./Pagination";
 
 describe("Pagination Accessibility", () => {
-  it("passes axe accessibility test", async () => {
-    const getPageHref = (page: number) => `page=${page}`;
+  const getPageHref = (page: number) => `page=${page}`;
+
+  it("passes axe accessibility on the first page", async () => {
     const { container } = render(
-      <Pagination pageCount={20} currentPage={6} getPageHref={getPageHref} />
+      <Pagination pageCount={20} initialPage={1} getPageHref={getPageHref} />
+    );
+    expect(await axe(container)).toHaveNoViolations();
+  });
+  it("passes axe accessibility on a middle page", async () => {
+    const { container } = render(
+      <Pagination pageCount={20} initialPage={10} getPageHref={getPageHref} />
+    );
+    expect(await axe(container)).toHaveNoViolations();
+  });
+  it("passes axe accessibility on the last page", async () => {
+    const { container } = render(
+      <Pagination pageCount={20} initialPage={20} getPageHref={getPageHref} />
     );
     expect(await axe(container)).toHaveNoViolations();
   });
 });
 
-describe("Pagination with getPageHref", () => {
+describe("Pagination", () => {
   const getPageHref = (page: number) => `page=${page}`;
 
-  it("Renders a nav element with items and links", () => {
-    render(
-      <Pagination pageCount={20} currentPage={6} getPageHref={getPageHref} />
-    );
+  describe("Rendering", () => {
+    it("renders a nav element with an unordered list and links", () => {
+      render(
+        <Pagination pageCount={5} initialPage={3} getPageHref={getPageHref} />
+      );
+      const nav = screen.getByRole("navigation");
 
-    expect(screen.getByRole("navigation")).toBeInTheDocument();
-    expect(screen.getByRole("list")).toBeInTheDocument();
-    // Previous/Next buttons + truncated item list = 11 total items
-    expect(screen.getAllByRole("listitem")).toHaveLength(11);
-    // Each element links to anotherpage.
-    // Each link has a `role="button"` attribute.
-    const links = screen.getAllByRole("button");
-
-    // Pagination should show
-    // Previous 1 ... 4 5 6 7 8 ... 20 Next
-    expect(links).toHaveLength(9);
-    // Previous Page
-    expect(links[0]).toHaveAttribute("href", "page=5");
-    expect(links[1]).toHaveAttribute("href", "page=1");
-    expect(links[2]).toHaveAttribute("href", "page=4");
-    expect(links[3]).toHaveAttribute("href", "page=5");
-    expect(links[4]).toHaveAttribute("href", "page=6");
-    expect(links[5]).toHaveAttribute("href", "page=7");
-    expect(links[6]).toHaveAttribute("href", "page=8");
-    expect(links[7]).toHaveAttribute("href", "page=20");
-    // Next Page
-    expect(links[8]).toHaveAttribute("href", "page=7");
-  });
+      expect(nav).toBeInTheDocument();
+      expect(nav).toHaveAttribute("aria-label", "Pagination");
+      // Chakra renders other lists so we only want the list we
+      // created within the nav element.
+      const { getByRole } = within(nav);
+      expect(getByRole("list")).toBeInTheDocument();
+      // Previous/Next links + truncated item list = 7 total items
+      expect(screen.getAllByRole("listitem")).toHaveLength(7);
+      // Pagination should show:
+      // Previous 1 2 3 4 5 Next
+      expect(screen.getAllByRole("link")).toHaveLength(7);
+    });
 
-  it("Previous link is disabled when on the first page item", () => {
-    render(
-      <Pagination pageCount={11} currentPage={1} getPageHref={getPageHref} />
-    );
-    const links = screen.getAllByRole("button");
-    expect(links[0]).toHaveAttribute("aria-disabled");
-    expect(links[0]).toHaveAttribute("class", "link pagination__link disabled");
-  });
+    it("does not render the Previous link on the first page", () => {
+      render(
+        <Pagination pageCount={5} initialPage={1} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // 1 2 3 4 5 Next
+      const links = screen.getAllByRole("link");
 
-  it("Next link is disabled when on the last page item", () => {
-    render(
-      <Pagination pageCount={11} currentPage={11} getPageHref={getPageHref} />
-    );
-    const links = screen.getAllByRole("button");
-    expect(links[9]).toHaveAttribute("aria-disabled");
-    expect(links[9]).toHaveAttribute("class", "link pagination__link disabled");
-  });
+      expect(links).toHaveLength(6);
+      expect(screen.queryByText("Previous")).not.toBeInTheDocument();
+      expect(screen.getByText("Next")).toBeInTheDocument();
+    });
 
-  it("Current page item has active class", () => {
-    render(
-      <Pagination pageCount={11} currentPage={5} getPageHref={getPageHref} />
-    );
-    const links = screen.getAllByRole("button");
-    expect(links[5]).toHaveAttribute("class", "link pagination__link selected");
-  });
+    it("does not render the Next link on the last page", () => {
+      render(
+        <Pagination pageCount={5} initialPage={5} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // Previous 1 2 3 4 5
+      const links = screen.getAllByRole("link");
 
-  it("When pagination has 1 element, pagination is not shown", () => {
-    render(
-      <Pagination pageCount={1} currentPage={1} getPageHref={getPageHref} />
-    );
-    expect(screen.queryByRole("navigation")).not.toBeInTheDocument();
-  });
+      expect(links).toHaveLength(6);
+      expect(screen.getByText("Previous")).toBeInTheDocument();
+      expect(screen.queryByText("Next")).not.toBeInTheDocument();
+    });
 
-  it("When pagination has 0 elements, pagination is not shown", () => {
-    render(
-      <Pagination pageCount={0} currentPage={1} getPageHref={getPageHref} />
-    );
-    expect(screen.queryByRole("navigation")).not.toBeInTheDocument();
-  });
-});
+    it("renders an ellipsis at the end of the list", () => {
+      render(
+        <Pagination pageCount={10} initialPage={1} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // 1 2 3 4 5 ... 10 Next
+      const listitem = screen.getAllByRole("listitem");
 
-describe("Pagination with changeCallback", () => {
-  const changeCallback = jest.fn();
+      expect(listitem).toHaveLength(8);
+      // The ellipsis is not a link
+      expect(screen.getAllByRole("link")).toHaveLength(7);
+      expect(listitem[4].textContent).toEqual("5");
+      expect(listitem[5].textContent).toEqual("...");
+      expect(listitem[6].textContent).toEqual("10");
+      expect(screen.getByText("...")).toBeInTheDocument();
+    });
 
-  it("Renders a nav element with an unordered list of items", () => {
-    render(
-      <Pagination
-        pageCount={11}
-        currentPage={6}
-        onPageChange={changeCallback}
-      />
-    );
-    expect(screen.getByRole("navigation")).toBeInTheDocument();
-    expect(screen.getByRole("list")).toBeInTheDocument();
-    expect(screen.getAllByRole("listitem")).toHaveLength(11);
-  });
+    it("renders an ellipsis at the start of the list", () => {
+      render(
+        <Pagination pageCount={10} initialPage={10} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // Previous 1 ... 6 7 8 9 10
+      const listitem = screen.getAllByRole("listitem");
 
-  it("Previous link is disabled when on the first page item", () => {
-    render(
-      <Pagination
-        pageCount={11}
-        currentPage={1}
-        onPageChange={changeCallback}
-      />
-    );
-    const links = screen.getAllByRole("button");
-    expect(links[0]).toHaveAttribute("aria-disabled");
-    expect(links[0]).toHaveAttribute("class", "link pagination__link disabled");
-  });
+      expect(listitem).toHaveLength(8);
+      // The ellipsis is not a link
+      expect(screen.getAllByRole("link")).toHaveLength(7);
+      expect(listitem[1].textContent).toEqual("1");
+      expect(listitem[2].textContent).toEqual("...");
+      expect(listitem[3].textContent).toEqual("6");
+      expect(screen.getByText("...")).toBeInTheDocument();
+    });
 
-  it("Next link is disabled when on the last page item", () => {
-    render(
-      <Pagination
-        pageCount={11}
-        currentPage={11}
-        onPageChange={changeCallback}
-      />
-    );
-    const links = screen.getAllByRole("button");
-    expect(links[9]).toHaveAttribute("aria-disabled");
-    expect(links[9]).toHaveAttribute("class", "link pagination__link disabled");
-  });
+    it("renders two ellipsis when the current page is in the middle", () => {
+      render(
+        <Pagination pageCount={10} initialPage={5} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // Previous 1 ... 4 5 6 ... 10 Next
+      const listitem = screen.getAllByRole("listitem");
 
-  it("Current page item has active class", () => {
-    render(
-      <Pagination
-        pageCount={11}
-        currentPage={5}
-        onPageChange={changeCallback}
-      />
-    );
-    const links = screen.getAllByRole("button");
-    expect(links[5]).toHaveAttribute("class", "link pagination__link selected");
-  });
+      expect(listitem).toHaveLength(9);
+      // The ellipses are not links
+      expect(screen.getAllByRole("link")).toHaveLength(7);
+      expect(listitem[0].textContent).toEqual("Previous");
+      expect(listitem[1].textContent).toEqual("1");
+      expect(listitem[2].textContent).toEqual("...");
+      expect(listitem[3].textContent).toEqual("4");
+      expect(listitem[4].textContent).toEqual("5");
+      expect(listitem[5].textContent).toEqual("6");
+      expect(listitem[6].textContent).toEqual("...");
+      expect(listitem[7].textContent).toEqual("10");
+      expect(listitem[8].textContent).toEqual("Next");
+      expect(screen.getAllByText("...")).toHaveLength(2);
+    });
 
-  it("When page item is selected, runs the onPageChange callback", () => {
-    render(
-      <Pagination
-        pageCount={11}
-        currentPage={5}
-        onPageChange={changeCallback}
-      />
-    );
-    const links = screen.getAllByRole("button");
-    expect(changeCallback).toHaveBeenCalledTimes(0);
-    userEvent.click(links[2]);
-    expect(changeCallback).toHaveBeenCalledTimes(1);
-  });
+    it("adds aria-current to the active page", () => {
+      render(
+        <Pagination pageCount={5} initialPage={3} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // Previous 1 2 3 4 5 Next
+      const links = screen.getAllByRole("link");
+      const page2 = links[2].getAttribute("aria-current");
+      const page3 = links[3].getAttribute("aria-current");
+      const page4 = links[4].getAttribute("aria-current");
 
-  it("When pagination has 1 element, pagination is not shown", () => {
-    render(
-      <Pagination pageCount={1} currentPage={1} onPageChange={changeCallback} />
-    );
-    expect(screen.queryByRole("navigation")).not.toBeInTheDocument();
+      expect(page2).toEqual(null);
+      // Only the current page has `aria-current="page"` for accessibility.
+      expect(page3).toEqual("page");
+      expect(page4).toEqual(null);
+    });
+
+    it("When pagination has 1 element, pagination is not shown", () => {
+      render(
+        <Pagination pageCount={1} initialPage={1} getPageHref={getPageHref} />
+      );
+      expect(screen.queryByRole("navigation")).not.toBeInTheDocument();
+    });
+
+    it("When pagination has 0 elements, pagination is not shown", () => {
+      render(
+        <Pagination pageCount={0} initialPage={1} getPageHref={getPageHref} />
+      );
+      expect(screen.queryByRole("navigation")).not.toBeInTheDocument();
+    });
+
+    it("Renders the UI snapshot correctly", () => {
+      const firstPage = renderer
+        .create(
+          <Pagination
+            id="firstPage"
+            pageCount={10}
+            initialPage={1}
+            getPageHref={getPageHref}
+          />
+        )
+        .toJSON();
+      const lastPage = renderer
+        .create(
+          <Pagination
+            id="lastPage"
+            pageCount={10}
+            initialPage={10}
+            getPageHref={getPageHref}
+          />
+        )
+        .toJSON();
+      const middlePage = renderer
+        .create(
+          <Pagination
+            id="middlePage"
+            pageCount={10}
+            initialPage={5}
+            getPageHref={getPageHref}
+          />
+        )
+        .toJSON();
+
+      expect(firstPage).toMatchSnapshot();
+      expect(lastPage).toMatchSnapshot();
+      expect(middlePage).toMatchSnapshot();
+    });
   });
 
-  it("When pagination has 0 elements, pagination is not shown", () => {
-    render(
-      <Pagination pageCount={0} currentPage={1} onPageChange={changeCallback} />
-    );
-    expect(screen.queryByRole("navigation")).not.toBeInTheDocument();
+  describe("Behavior", () => {
+    it("updates the links href value when getPageHref is used", () => {
+      const getPageHref = (page: number) => `?page=${page}`;
+      render(
+        <Pagination pageCount={10} initialPage={5} getPageHref={getPageHref} />
+      );
+      // Pagination should show:
+      // Previous 1 ... 4 5 6 ... 10 Next
+      const links = screen.getAllByRole("link");
+
+      expect(screen.getByText("Previous")).toBeInTheDocument();
+      expect(screen.getByText("Next")).toBeInTheDocument();
+
+      // Previous link
+      expect(links[0].getAttribute("href")).toEqual("?page=4");
+      expect(links[1].getAttribute("href")).toEqual("?page=1");
+      expect(links[2].getAttribute("href")).toEqual("?page=4");
+      expect(links[3].getAttribute("href")).toEqual("?page=5");
+      expect(links[4].getAttribute("href")).toEqual("?page=6");
+      expect(links[5].getAttribute("href")).toEqual("?page=10");
+      // Next link
+      expect(links[6].getAttribute("href")).toEqual("?page=6");
+    });
+
+    // In this scenario, we need to update the current page ourselves
+    // since we stay on the same page.
+    it("When page item is selected, runs the onPageChange callback", () => {
+      const onPageChange = (page: number) => (currentPage = page);
+      let currentPage = 5;
+      const { rerender } = render(
+        <Pagination
+          pageCount={10}
+          initialPage={currentPage}
+          onPageChange={onPageChange}
+        />
+      );
+      // Pagination should show:
+      // Previous 1 ... 4 5 6 ... 10 Next
+      let links = screen.getAllByRole("link");
+
+      // Links all have "#" for their href value.
+      // Previous link
+      expect(links[0].getAttribute("href")).toEqual("#");
+      expect(links[1].getAttribute("href")).toEqual("#");
+      expect(links[2].getAttribute("href")).toEqual("#");
+      expect(links[3].getAttribute("href")).toEqual("#");
+      expect(links[4].getAttribute("href")).toEqual("#");
+      expect(links[5].getAttribute("href")).toEqual("#");
+      // Next link
+      expect(links[6].getAttribute("href")).toEqual("#");
+
+      // Page 4
+      userEvent.click(links[2]);
+      expect(currentPage).toEqual(4);
+
+      rerender(
+        <Pagination
+          pageCount={10}
+          initialPage={currentPage}
+          onPageChange={onPageChange}
+        />
+      );
+      // Pagination should show:
+      // Previous 1 2 3 4 5 ... 10 Next
+      links = screen.getAllByRole("link");
+
+      // Previous link
+      userEvent.click(links[0]);
+      expect(currentPage).toEqual(3);
+
+      rerender(
+        <Pagination
+          pageCount={10}
+          initialPage={currentPage}
+          onPageChange={onPageChange}
+        />
+      );
+      // Pagination should show:
+      // Previous 1 2 3 4 5 ... 10 Next
+      links = screen.getAllByRole("link");
+
+      // Page 10
+      userEvent.click(links[6]);
+      expect(currentPage).toEqual(10);
+
+      rerender(
+        <Pagination
+          pageCount={10}
+          initialPage={currentPage}
+          onPageChange={onPageChange}
+        />
+      );
+      // Pagination should show:
+      // Previous 1 ... 6 7 8 9 10
+      links = screen.getAllByRole("link");
+
+      // Page 6
+      userEvent.click(links[2]);
+      expect(currentPage).toEqual(6);
+    });
   });
 });