@nymphjs/tilmeld 1.0.0-beta.9 → 1.0.0-beta.90

package/src/Group.ts

@@ -1,24 +1,27 @@
-import {
+import crypto from 'node:crypto';
+import type {
+  Nymph,
   EntityData,
-  EntityInterface,
   EntityJson,
   EntityPatch,
   Options,
   Selector,
   SerializedEntityData,
 } from '@nymphjs/nymph';
-import md5 from 'crypto-js/md5';
-import { difference } from 'lodash';
+import { difference, xor } from 'lodash-es';
+import { splitn } from '@sciactive/splitn';
 
-import type Tilmeld from './Tilmeld';
-import AbleObject from './AbleObject';
+import { enforceTilmeld } from './enforceTilmeld.js';
+import AbleObject from './AbleObject.js';
 import {
+  AccessControlError,
   BadDataError,
   BadEmailError,
   BadUsernameError,
   CouldNotChangeDefaultPrimaryGroupError,
-} from './errors';
-import User, { UserData } from './User';
+} from './errors/index.js';
+import UserClass from './User.js';
+import type { UserData } from './User.js';
 
 export type GroupData = {
   /**
@@ -52,7 +55,7 @@ export type GroupData = {
   /**
    * If generatePrimary is on, this will be the user who generated this group.
    */
-  user?: (User & UserData) | null;
+  user?: (UserClass & UserData) | null;
 
   /**
    * Whether the group can be used.
@@ -85,7 +88,6 @@ export default class Group extends AbleObject<GroupData> {
   /**
    * The instance of Tilmeld to use for queries.
    */
-  static tilmeld: Tilmeld;
   static ETYPE = 'tilmeld_group';
   static class = 'Group';
 
@@ -112,16 +114,20 @@ export default class Group extends AbleObject<GroupData> {
   protected $allowlistTags?: string[] = [];
 
   /**
-   * This is explicitly used only during the registration proccess.
+   * This should only be used by the backend.
    */
   private $skipAcWhenSaving = false;
-
-  static async factory(guid?: string): Promise<Group & GroupData> {
-    return (await super.factory(guid)) as Group & GroupData;
-  }
+  /**
+   * This should only be used by the backend.
+   */
+  private $skipAcWhenDeleting = false;
+  /**
+   * Used to save the current groupname for domain admin permissions.
+   */
+  public $originalGroupname?: string;
 
   static async factoryGroupname(
-    groupname?: string
+    groupname?: string,
   ): Promise<Group & GroupData> {
     const entity = new this();
     if (groupname != null) {
@@ -132,7 +138,7 @@ export default class Group extends AbleObject<GroupData> {
         {
           type: '&',
           ilike: ['groupname', groupname.replace(/([\\%_])/g, (s) => `\\${s}`)],
-        }
+        },
       );
       if (entity != null) {
         return entity;
@@ -141,21 +147,6 @@ export default class Group extends AbleObject<GroupData> {
     return entity;
   }
 
-  static factorySync(guid?: string): Group & GroupData {
-    return super.factorySync(guid) as Group & GroupData;
-  }
-
-  constructor(guid?: string) {
-    super(guid);
-
-    if (this.guid == null) {
-      // Defaults.
-      this.$data.enabled = true;
-      this.$data.abilities = [];
-      this.$updateDataProtection();
-    }
-  }
-
   /**
    * Get all the groups that can be assigned as primary groups.
    *
@@ -165,16 +156,17 @@ export default class Group extends AbleObject<GroupData> {
    */
   public static async getPrimaryGroups(
     options?: Options,
-    selectors?: Selector[]
+    selectors?: Selector[],
   ) {
-    if (!this.tilmeld.gatekeeper('tilmeld/admin')) {
+    const tilmeld = enforceTilmeld(this);
+    if (!tilmeld.gatekeeper('tilmeld/admin')) {
       throw new Error("You don't have permission to do that.");
     }
 
     return await this.getAssignableGroups(
-      this.tilmeld.config.highestPrimary,
-      { ...options, class: this.tilmeld.Group, return: 'entity' },
-      [...(selectors ?? [])]
+      tilmeld.config.highestPrimary,
+      { ...options, class: tilmeld.Group, return: 'entity' },
+      [...(selectors ?? [])],
     );
   }
 
@@ -187,24 +179,26 @@ export default class Group extends AbleObject<GroupData> {
    */
   public static async getSecondaryGroups(
     options?: Options,
-    selectors?: Selector[]
+    selectors?: Selector[],
   ) {
-    if (!this.tilmeld.gatekeeper('tilmeld/admin')) {
+    const tilmeld = enforceTilmeld(this);
+    if (!tilmeld.gatekeeper('tilmeld/admin')) {
       throw new Error("You don't have permission to do that.");
     }
 
     return await this.getAssignableGroups(
-      this.tilmeld.config.highestSecondary,
-      { ...options, class: this.tilmeld.Group, return: 'entity' },
-      [...(selectors ?? [])]
+      tilmeld.config.highestSecondary,
+      { ...options, class: tilmeld.Group, return: 'entity' },
+      [...(selectors ?? [])],
     );
   }
 
   private static async getAssignableGroups(
     highestParent: string | boolean,
     options: Options<typeof Group>,
-    selectors: Selector[]
+    selectors: Selector[],
   ) {
+    const tilmeld = enforceTilmeld(this);
     let assignableGroups: (Group & GroupData)[] = [];
 
     if (highestParent === false) {
@@ -212,24 +206,68 @@ export default class Group extends AbleObject<GroupData> {
     }
 
     assignableGroups = await this.nymph.getEntities(
-      { ...options, class: this.tilmeld.Group },
-      ...selectors
+      { ...options, class: tilmeld.Group },
+      ...selectors,
     );
     if (highestParent !== true) {
-      assignableGroups = assignableGroups.filter((group) => {
-        let curGroup = group;
-        while (curGroup.parent != null && curGroup.parent.cdate != null) {
-          if (curGroup.parent.guid === highestParent) {
-            return true;
-          }
-          curGroup = curGroup.parent;
-        }
-        return false;
-      });
+      assignableGroups = (
+        await Promise.all(
+          assignableGroups.map(async (group) => {
+            let curGroup = group;
+            let parent = curGroup.parent;
+            await parent?.$wake();
+            while (parent != null && parent?.cdate != null) {
+              if (parent?.guid === highestParent) {
+                return group;
+              }
+              curGroup = parent;
+              parent = curGroup.parent;
+              await parent?.$wake();
+            }
+            return null;
+          }),
+        )
+      ).filter((group) => group != null) as (Group & GroupData)[];
     }
     return assignableGroups;
   }
 
+  constructor() {
+    super();
+
+    // Defaults.
+    this.$data.enabled = true;
+    this.$data.abilities = [];
+    this.$updateDataProtection();
+  }
+
+  $setNymph(nymph: Nymph) {
+    this.$nymph = nymph;
+    if (!this.$asleep()) {
+      if (this.$data.user && this.$data.user.$nymph !== nymph) {
+        this.$data.user.$setNymph(nymph);
+      }
+      if (this.$data.parent && this.$data.parent.$nymph !== nymph) {
+        this.$data.parent.$setNymph(nymph);
+      }
+    }
+  }
+
+  async $getUniques(): Promise<string[]> {
+    const tilmeld = enforceTilmeld(this);
+    const uniques = [`u:${this.$data.groupname}`];
+    if (
+      !tilmeld.config.emailUsernames &&
+      tilmeld.config.userFields.includes('email')
+    ) {
+      uniques.push(`e:${this.$data.email}`);
+    }
+    if (this.$data.defaultPrimary) {
+      uniques.push(`o:default-primary`);
+    }
+    return uniques;
+  }
+
   public $getAvatar() {
     if (this.$data.avatar != null && this.$data.avatar !== '') {
       return this.$data.avatar;
@@ -239,49 +277,104 @@ export default class Group extends AbleObject<GroupData> {
     }
     return (
       'https://secure.gravatar.com/avatar/' +
-      md5(this.$data.email.trim().toLowerCase()).toString() +
+      crypto
+        .createHash('sha256')
+        .update(this.$data.email.trim().toLowerCase())
+        .digest('hex')
+        .toLowerCase() +
       '?d=identicon&s=40'
     );
   }
 
   public $jsonAcceptData(input: EntityJson, allowConflict = false) {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
-    this.$referenceWake();
+    this.$check();
 
-    if (
-      input.data.abilities?.indexOf('system/admin') !== -1 &&
-      this.$data.abilities?.indexOf('system/admin') === -1 &&
-      tilmeld.gatekeeper('tilmeld/admin') &&
-      !tilmeld.gatekeeper('system/admin')
-    ) {
-      throw new BadDataError(
-        "You don't have the authority to make this group a system admin."
-      );
+    if ('abilities' in input.data) {
+      this.$checkIncomingAbilities(input.data.abilities);
     }
 
     super.$jsonAcceptData(input, allowConflict);
   }
 
   public $jsonAcceptPatch(patch: EntityPatch, allowConflict = false) {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
-    this.$referenceWake();
+    this.$check();
+
+    if ('abilities' in patch.set) {
+      this.$checkIncomingAbilities(patch.set.abilities);
+    }
+
+    super.$jsonAcceptPatch(patch, allowConflict);
+  }
+
+  private $checkIncomingAbilities(incoming: any) {
+    const tilmeld = enforceTilmeld(this);
 
     if (
-      patch.set.abilities?.indexOf('system/admin') !== -1 &&
-      this.$data.abilities?.indexOf('system/admin') === -1 &&
-      tilmeld.gatekeeper('tilmeld/admin') &&
-      !tilmeld.gatekeeper('system/admin')
+      !Array.isArray(incoming) ||
+      incoming.find((ability) => typeof ability !== 'string')
+    ) {
+      throw new BadDataError('Abilities must be an array of strings.');
+    }
+
+    if (
+      incoming.includes('system/admin') !==
+        this.$data.abilities?.includes('system/admin') &&
+      (!tilmeld.currentUser ||
+        !tilmeld.currentUser.abilities?.includes('system/admin'))
     ) {
       throw new BadDataError(
-        "You don't have the authority to make this group a system admin."
+        "You don't have the authority to grant or revoke system/admin.",
       );
     }
 
-    super.$jsonAcceptPatch(patch, allowConflict);
+    if (
+      incoming.includes('tilmeld/admin') !==
+        this.$data.abilities?.includes('tilmeld/admin') &&
+      (!tilmeld.currentUser ||
+        !tilmeld.currentUser.abilities?.includes('system/admin'))
+    ) {
+      throw new BadDataError(
+        "You don't have the authority to grant or revoke tilmeld/admin.",
+      );
+    }
+
+    if (
+      incoming.includes('tilmeld/switch') !==
+        this.$data.abilities?.includes('tilmeld/switch') &&
+      (!tilmeld.currentUser ||
+        !tilmeld.currentUser.abilities?.includes('system/admin'))
+    ) {
+      throw new BadDataError(
+        "You don't have the authority to grant or revoke tilmeld/switch.",
+      );
+    }
+
+    if (
+      xor(
+        incoming.filter((ability: string) => ability.startsWith('tilmeld/')),
+        this.$data.abilities?.filter((ability: string) =>
+          ability.startsWith('tilmeld/'),
+        ) ?? [],
+      ).length &&
+      (!tilmeld.currentUser ||
+        (!tilmeld.currentUser.abilities?.includes('system/admin') &&
+          !tilmeld.currentUser.abilities?.includes('tilmeld/admin')))
+    ) {
+      throw new BadDataError(
+        "You don't have the authority to grant or revoke Tilmeld abilities.",
+      );
+    }
   }
 
-  public $putData(data: EntityData, sdata?: SerializedEntityData) {
-    super.$putData(data, sdata);
+  public $putData(
+    data: EntityData,
+    sdata?: SerializedEntityData,
+    source?: 'server',
+  ) {
+    super.$putData(data, sdata, source);
+    if (source === 'server') {
+      this.$originalGroupname = this.$data.groupname;
+    }
     this.$updateDataProtection();
   }
 
@@ -290,9 +383,16 @@ export default class Group extends AbleObject<GroupData> {
    *
    * @param givenUser User to update protection for. If undefined, will use the currently logged in user.
    */
-  public $updateDataProtection(givenUser?: User & UserData) {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+  public $updateDataProtection(givenUser?: UserClass & UserData) {
+    const tilmeld = enforceTilmeld(this);
     let user = givenUser ?? tilmeld.User.current();
+    let [_groupname, domain] = tilmeld.config.domainSupport
+      ? splitn(this.$data.groupname ?? '', '@', 2)
+      : [this.$data.groupname, null];
+    // Lowercase the domain part.
+    if (domain) {
+      domain = domain.toLowerCase();
+    }
 
     this.$privateData = [...Group.DEFAULT_PRIVATE_DATA];
     this.$allowlistData = [...Group.DEFAULT_ALLOWLIST_DATA];
@@ -303,8 +403,8 @@ export default class Group extends AbleObject<GroupData> {
 
     if (
       user != null &&
-      ((user.abilities?.indexOf('tilmeld/admin') ?? -1) !== -1 ||
-        (user.abilities?.indexOf('system/admin') ?? -1) !== -1)
+      (user.abilities?.includes('tilmeld/admin') ||
+        user.abilities?.includes('system/admin'))
     ) {
       // Users who can edit groups can see their data.
       this.$privateData = [];
@@ -312,10 +412,18 @@ export default class Group extends AbleObject<GroupData> {
     } else if (
       this.$data.user != null &&
       user != null &&
-      this.$data.user.$is(user)
+      this.$data.user.guid === user.guid
     ) {
       // Users can see their group's data.
       this.$privateData = [];
+    } else if (
+      user != null &&
+      tilmeld.config.domainSupport &&
+      domain &&
+      user.abilities?.includes(`tilmeld/domain/${domain}/admin`)
+    ) {
+      // Domain admins can see their groups' data.
+      this.$privateData = [];
     }
   }
 
@@ -325,11 +433,13 @@ export default class Group extends AbleObject<GroupData> {
    * @param group The group, or the group's GUID.
    * @returns True or false.
    */
-  public $isDescendant(givenGroup: (Group & GroupData) | string): boolean {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+  public async $isDescendant(
+    givenGroup: (Group & GroupData) | string,
+  ): Promise<boolean> {
+    const tilmeld = enforceTilmeld(this);
     let group: Group & GroupData;
     if (typeof givenGroup === 'string') {
-      group = tilmeld.Group.factorySync(givenGroup);
+      group = await tilmeld.Group.factory(givenGroup);
     } else {
       group = givenGroup;
     }
@@ -337,13 +447,15 @@ export default class Group extends AbleObject<GroupData> {
       return false;
     }
     // Check to see if the group is a descendant of the given group.
-    if (this.$data.parent == null) {
+    const parent = this.$data.parent;
+    await parent?.$wake();
+    if (parent == null) {
       return false;
     }
-    if (this.$data.parent.$is(group)) {
+    if (parent.$is(group)) {
       return true;
     }
-    if (this.$data.parent.$isDescendant(group)) {
+    if (await parent.$isDescendant(group)) {
       return true;
     }
     return false;
@@ -355,14 +467,14 @@ export default class Group extends AbleObject<GroupData> {
    * @returns An array of groups.
    */
   public async $getChildren() {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+    const tilmeld = enforceTilmeld(this);
     return await this.$nymph.getEntities(
       { class: tilmeld.Group },
       {
         type: '&',
         equal: ['enabled', true],
         ref: ['parent', this],
-      }
+      },
     );
   }
 
@@ -373,9 +485,9 @@ export default class Group extends AbleObject<GroupData> {
    * @returns An array of groups.
    */
   public async $getDescendants(
-    andSelf = false
+    andSelf = false,
   ): Promise<(Group & GroupData)[]> {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+    const tilmeld = enforceTilmeld(this);
     let groups: (Group & GroupData)[] = [];
     const entities = await this.$nymph.getEntities(
       { class: tilmeld.Group },
@@ -383,7 +495,7 @@ export default class Group extends AbleObject<GroupData> {
         type: '&',
         equal: ['enabled', true],
         ref: ['parent', this],
-      }
+      },
     );
     for (let entity of entities) {
       groups = (await entity.$getDescendants(true)).concat(groups);
@@ -394,37 +506,6 @@ export default class Group extends AbleObject<GroupData> {
     return groups;
   }
 
-  /**
-   * Gets an array of the group's descendant groups.
-   *
-   * @param andSelf Include this group in the returned array.
-   * @returns An array of groups.
-   */
-  public $getDescendantsSync(andSelf = false): (Group & GroupData)[] {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
-    let groups: (Group & GroupData)[] = [];
-    let entity: EntityInterface | null;
-    let offset = 0;
-    do {
-      entity = this.$nymph.driver.getEntitySync(
-        { class: tilmeld.Group, offset },
-        {
-          type: '&',
-          equal: ['enabled', true],
-          ref: ['parent', this],
-        }
-      );
-      if (entity != null) {
-        groups = entity.$getDescendantsSync(true).concat(groups);
-      }
-      offset++;
-    } while (entity != null);
-    if (andSelf) {
-      groups.push(this);
-    }
-    return groups;
-  }
-
   /**
    * Get the number of parents the group has.
    *
@@ -436,13 +517,17 @@ export default class Group extends AbleObject<GroupData> {
    *
    * @returns The level of the group.
    */
-  public $getLevel() {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
-    let group = tilmeld.Group.factorySync(this.guid ?? undefined);
+  public async $getLevel() {
+    const tilmeld = enforceTilmeld(this);
+    let group = await tilmeld.Group.factory(this.guid ?? undefined);
+    let parent = group.parent;
+    await parent?.$wake();
     let level = 0;
-    while (group.parent != null && group.parent.cdate != null && level < 1024) {
+    while (parent != null && parent.cdate != null && level < 1024) {
       level++;
-      group = group.parent;
+      group = parent;
+      parent = group.parent;
+      await parent?.$wake();
     }
     return level;
   }
@@ -458,9 +543,9 @@ export default class Group extends AbleObject<GroupData> {
   public async $getUsers(
     descendants = false,
     limit?: number,
-    offset?: number
-  ): Promise<(User & UserData)[]> {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+    offset?: number,
+  ): Promise<(UserClass & UserData)[]> {
+    const tilmeld = enforceTilmeld(this);
     let groups: (Group & GroupData)[] = [];
     if (descendants) {
       groups = await this.$getDescendants();
@@ -489,7 +574,7 @@ export default class Group extends AbleObject<GroupData> {
             group,
           ]),
         ],
-      }
+      },
     );
   }
 
@@ -502,15 +587,36 @@ export default class Group extends AbleObject<GroupData> {
     result: boolean;
     message: string;
   }> {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+    const tilmeld = enforceTilmeld(this);
     if (!tilmeld.config.emailUsernames) {
-      if (this.$data.groupname == null || !this.$data.groupname.length) {
-        return { result: false, message: 'Please specify a groupname.' };
+      let [groupname, domain] = tilmeld.config.domainSupport
+        ? splitn(this.$data.groupname ?? '', '@', 2)
+        : [this.$data.groupname, null];
+
+      // Lowercase the domain part.
+      if (domain) {
+        domain = domain.toLowerCase();
+        this.$data.groupname = `${groupname}@${domain}`;
       }
+
       if (
-        tilmeld.config.maxUsernameLength > 0 &&
-        this.$data.groupname.length > tilmeld.config.maxUsernameLength
+        this.$data.groupname == null ||
+        !this.$data.groupname.length ||
+        groupname == null ||
+        !groupname.length
       ) {
+        return { result: false, message: 'Please specify a groupname.' };
+      }
+      if (groupname.length < tilmeld.config.minUsernameLength) {
+        return {
+          result: false,
+          message:
+            'Groupnames must be at least ' +
+            tilmeld.config.minUsernameLength +
+            ' characters.',
+        };
+      }
+      if (groupname.length > tilmeld.config.maxUsernameLength) {
         return {
           result: false,
           message:
@@ -520,22 +626,38 @@ export default class Group extends AbleObject<GroupData> {
         };
       }
       if (
-        difference(
-          this.$data.groupname.split(''),
-          tilmeld.config.validChars.split('')
-        ).length
+        difference(groupname.split(''), tilmeld.config.validChars.split(''))
+          .length
       ) {
         return {
           result: false,
           message: tilmeld.config.validCharsNotice,
         };
       }
-      if (!tilmeld.config.validRegex.test(this.$data.groupname)) {
+      if (!tilmeld.config.validRegex.test(groupname)) {
         return {
           result: false,
           message: tilmeld.config.validRegexNotice,
         };
       }
+      if (domain != null) {
+        if (!tilmeld.config.validDomainRegex.test(domain)) {
+          return {
+            result: false,
+            message: tilmeld.config.validDomainRegexNotice,
+          };
+        }
+        if (
+          !this.$is(tilmeld.currentUser?.group) &&
+          !tilmeld.gatekeeper(`tilmeld/domain/${domain}/admin`)
+        ) {
+          return {
+            result: false,
+            message:
+              "You don't have the authority to manage groups on this domain.",
+          };
+        }
+      }
 
       const selector: Selector = {
         type: '&',
@@ -549,7 +671,7 @@ export default class Group extends AbleObject<GroupData> {
       }
       const test = await this.$nymph.getEntity(
         { class: tilmeld.Group, skipAc: true },
-        selector
+        selector,
       );
       if (test != null) {
         return { result: false, message: 'That groupname is taken.' };
@@ -565,10 +687,16 @@ export default class Group extends AbleObject<GroupData> {
       if (this.$data.groupname == null || !this.$data.groupname.length) {
         return { result: false, message: 'Please specify an email.' };
       }
-      if (
-        tilmeld.config.maxUsernameLength > 0 &&
-        this.$data.groupname.length > tilmeld.config.maxUsernameLength
-      ) {
+      if (this.$data.groupname.length < tilmeld.config.minUsernameLength) {
+        return {
+          result: false,
+          message:
+            'Emails must be at least ' +
+            tilmeld.config.minUsernameLength +
+            ' characters.',
+        };
+      }
+      if (this.$data.groupname.length > tilmeld.config.maxUsernameLength) {
         return {
           result: false,
           message:
@@ -588,7 +716,7 @@ export default class Group extends AbleObject<GroupData> {
    * @returns An object with a boolean 'result' entry and a 'message' entry.
    */
   public async $checkEmail(): Promise<{ result: boolean; message: string }> {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+    const tilmeld = enforceTilmeld(this);
     if (this.$data.email === '') {
       return { result: true, message: '' };
     }
@@ -610,7 +738,7 @@ export default class Group extends AbleObject<GroupData> {
     }
     const test = await this.$nymph.getEntity(
       { class: tilmeld.Group, skipAc: true },
-      selector
+      selector,
     );
     if (test != null) {
       return {
@@ -627,11 +755,64 @@ export default class Group extends AbleObject<GroupData> {
   }
 
   public async $save() {
-    const tilmeld = this.$nymph.tilmeld as Tilmeld;
+    const tilmeld = enforceTilmeld(this);
     if (this.$data.groupname == null || !this.$data.groupname.trim().length) {
       return false;
     }
 
+    // Lowercase the domain part.
+    if (tilmeld.config.domainSupport) {
+      const [groupname, domain] = splitn(this.$data.groupname ?? '', '@', 2);
+      if (domain) {
+        this.$data.groupname = `${groupname}@${domain.toLowerCase()}`;
+      }
+    }
+
+    if (tilmeld.config.domainSupport) {
+      const [_groupname, domain] = splitn(this.$data.groupname ?? '', '@', 2);
+      const [_originalGroupname, originalDomain] = splitn(
+        this.$originalGroupname ?? '',
+        '@',
+        2,
+      );
+
+      if (
+        this.guid != null &&
+        ((originalDomain == null && domain != null) ||
+          (domain == null && originalDomain != null))
+      ) {
+        throw new AccessControlError(
+          "Groups can't switch to or from having a domain once created.",
+        );
+      }
+
+      if (
+        !this.$skipAcWhenSaving &&
+        !tilmeld.gatekeeper('tilmeld/admin') &&
+        !tilmeld.gatekeeper('system/admin')
+      ) {
+        if (
+          domain != null &&
+          !this.$is(tilmeld.currentUser) &&
+          !tilmeld.gatekeeper(`tilmeld/domain/${domain}/admin`)
+        ) {
+          throw new AccessControlError(
+            "You don't have the authority to modify groups on this domain.",
+          );
+        }
+        if (
+          originalDomain != null &&
+          originalDomain !== domain &&
+          (!tilmeld.gatekeeper(`tilmeld/domain/${domain}/admin`) ||
+            !tilmeld.gatekeeper(`tilmeld/domain/${originalDomain}/admin`))
+        ) {
+          throw new AccessControlError(
+            "You don't have the authority to modify groups on this domain.",
+          );
+        }
+      }
+    }
+
     // Formatting.
     this.$data.groupname = this.$data.groupname.trim();
     if (tilmeld.config.emailUsernames) {
@@ -643,16 +824,22 @@ export default class Group extends AbleObject<GroupData> {
     this.$data.enabled = !!this.$data.enabled;
 
     // Clear empty values.
-    if (this.$data.name === '') {
+    if (this.$data.name === '' || !tilmeld.config.userFields.includes('name')) {
       delete this.$data.name;
     }
-    if (this.$data.email === '') {
+    if (
+      this.$data.email === '' ||
+      !tilmeld.config.userFields.includes('email')
+    ) {
       delete this.$data.email;
     }
     if (this.$data.avatar === '') {
       delete this.$data.avatar;
     }
-    if (this.$data.phone === '') {
+    if (
+      this.$data.phone === '' ||
+      !tilmeld.config.userFields.includes('phone')
+    ) {
       delete this.$data.phone;
     }
     if (this.$data.parent == null) {
@@ -671,20 +858,33 @@ export default class Group extends AbleObject<GroupData> {
       delete this.$data.unverifiedSecondary;
     }
 
-    // Groups should never have 'system/admin' or 'tilmeld/admin' abilities.
-    this.$data.abilities = difference(this.$data.abilities ?? [], [
-      'system/admin',
-      'tilmeld/admin',
-      null,
-      undefined,
-    ]) as string[];
+    // Groups should never have 'system/admin', 'tilmeld/admin',
+    // 'tilmeld/switch', or domain admin abilities.
+    this.$data.abilities = (this.$data.abilities ?? []).filter((ability) => {
+      if (
+        ['system/admin', 'tilmeld/admin', 'tilmeld/switch'].indexOf(ability) !==
+        -1
+      ) {
+        return false;
+      }
+      if (ability == null) {
+        return false;
+      }
+      if (ability.startsWith('tilmeld/domain/') && ability.endsWith('/admin')) {
+        return false;
+      }
+      return true;
+    }) as string[];
 
     // Verification.
     const unCheck = await this.$checkGroupname();
     if (!unCheck.result) {
       throw new BadUsernameError(unCheck.message);
     }
-    if (!tilmeld.config.emailUsernames) {
+    if (
+      !tilmeld.config.emailUsernames &&
+      tilmeld.config.userFields.includes('email')
+    ) {
       const emCheck = await this.$checkEmail();
       if (!emCheck.result) {
         throw new BadEmailError(emCheck.message);
@@ -692,19 +892,21 @@ export default class Group extends AbleObject<GroupData> {
     }
 
     // Validate group parent. Make sure it's not a descendant of this group.
+    const parent = this.$data.parent;
+    await parent?.$wake();
     if (
-      this.$data.parent &&
-      (this.$data.parent.cdate == null ||
-        this.$is(this.$data.parent) ||
-        this.$data.parent.$isDescendant(this))
+      parent &&
+      (parent.cdate == null ||
+        this.$is(parent) ||
+        (await parent.$isDescendant(this)))
     ) {
       throw new BadDataError(
-        "Group parent can't be itself or descendant of itself."
+        "Group parent can't be itself or descendant of itself.",
       );
     }
 
     try {
-      tilmeld.config.validatorGroup(this);
+      tilmeld.config.validatorGroup(tilmeld, this);
     } catch (e: any) {
       throw new BadDataError(e?.message);
     }
@@ -713,20 +915,28 @@ export default class Group extends AbleObject<GroupData> {
     if (this.$data.defaultPrimary) {
       const currentPrimary = await this.$nymph.getEntity(
         { class: tilmeld.Group },
-        { type: '&', truthy: 'defaultPrimary' }
+        { type: '&', truthy: 'defaultPrimary' },
       );
       if (currentPrimary != null && !this.$is(currentPrimary)) {
         currentPrimary.defaultPrimary = false;
-        if (!(await currentPrimary.$save())) {
+        if (
+          this.$skipAcWhenSaving
+            ? !(await currentPrimary.$saveSkipAC())
+            : !(await currentPrimary.$save())
+        ) {
           throw new CouldNotChangeDefaultPrimaryGroupError(
             'Could not change new user primary group from ' +
-              `${currentPrimary.groupname}.`
+              `${currentPrimary.groupname}.`,
           );
         }
       }
     }
 
-    return await super.$save();
+    const ret = await super.$save();
+    if (ret) {
+      this.$originalGroupname = this.$data.groupname;
+    }
+    return ret;
   }
 
   /*
@@ -746,76 +956,118 @@ export default class Group extends AbleObject<GroupData> {
   }
 
   public async $delete() {
-    let tilmeld = this.$nymph.tilmeld as Tilmeld;
-    if (!tilmeld.gatekeeper('tilmeld/admin')) {
-      throw new BadDataError("You don't have the authority to delete groups.");
+    let tilmeld = enforceTilmeld(this);
+    if (!this.$skipAcWhenDeleting && !tilmeld.gatekeeper('tilmeld/admin')) {
+      throw new AccessControlError(
+        "You don't have the authority to delete groups.",
+      );
+    }
+    if (this.$data.groupname !== this.$originalGroupname) {
+      throw new AccessControlError(
+        "You can't delete a group while switching its groupname.",
+      );
     }
 
     const transaction = 'tilmeld-delete-' + this.guid;
     const nymph = this.$nymph;
     const tnymph = await nymph.startTransaction(transaction);
-    this.$nymph = tnymph;
-    tilmeld = this.$nymph.tilmeld as Tilmeld;
-
-    // Delete descendants.
-    const descendants = await this.$getDescendants();
-    if (descendants.length) {
-      for (let curGroup of descendants) {
-        if (!(await curGroup.$delete())) {
+    this.$setNymph(tnymph);
+    tilmeld = enforceTilmeld(this);
+    const User = tnymph.getEntityClass(UserClass);
+
+    try {
+      // Delete descendants.
+      const descendants = await this.$getDescendants();
+      if (descendants.length) {
+        for (let curGroup of descendants) {
+          if (
+            this.$skipAcWhenDeleting
+              ? !(await curGroup.$deleteSkipAC())
+              : !(await curGroup.$delete())
+          ) {
+            await tnymph.rollback(transaction);
+            this.$setNymph(nymph);
+            return false;
+          }
+        }
+      }
+
+      // Remove users from this primary group.
+      const primaryUsers = await tnymph.getEntities(
+        {
+          class: User,
+          skipAc: true,
+        },
+        {
+          type: '&',
+          ref: ['group', this],
+        },
+      );
+      for (let user of primaryUsers) {
+        delete user.group;
+        if (
+          this.$skipAcWhenDeleting
+            ? !(await user.$saveSkipAC())
+            : !(await user.$save())
+        ) {
           await tnymph.rollback(transaction);
-          this.$nymph = nymph;
+          this.$setNymph(nymph);
           return false;
         }
       }
-    }
 
-    // Remove users from this primary group.
-    const primaryUsers = await tnymph.getEntities(
-      {
-        class: tilmeld.User,
-        skipAc: true,
-      },
-      {
-        type: '&',
-        ref: ['group', this],
-      }
-    );
-    for (let user of primaryUsers) {
-      delete user.group;
-      if (!(await user.$save())) {
-        await tnymph.rollback(transaction);
-        this.$nymph = nymph;
-        return false;
+      // Remove users from this secondary group.
+      const secondaryUsers = await tnymph.getEntities(
+        {
+          class: User,
+          skipAc: true,
+        },
+        {
+          type: '&',
+          ref: ['groups', this],
+        },
+      );
+      for (let user of secondaryUsers) {
+        user.$delGroup(this);
+        if (
+          this.$skipAcWhenDeleting
+            ? !(await user.$saveSkipAC())
+            : !(await user.$save())
+        ) {
+          await tnymph.rollback(transaction);
+          return false;
+        }
       }
-    }
 
-    // Remove users from this secondary group.
-    const secondaryUsers = await tnymph.getEntities(
-      {
-        class: tilmeld.User,
-        skipAc: true,
-      },
-      {
-        type: '&',
-        ref: ['groups', this],
-      }
-    );
-    for (let user of secondaryUsers) {
-      user.$delGroup(this);
-      if (!(await user.$save())) {
+      // Delete the group.
+      let success = await super.$delete();
+      if (success) {
+        success = await tnymph.commit(transaction);
+      } else {
         await tnymph.rollback(transaction);
-        return false;
       }
+      this.$setNymph(nymph);
+      return success;
+    } catch (e: any) {
+      await tnymph.rollback(transaction);
+      this.$setNymph(nymph);
+      throw e;
     }
+  }
 
-    // Delete the group.
-    const success = await super.$delete();
-    if (success) {
-      await tnymph.commit(transaction);
-    } else {
-      await tnymph.rollback(transaction);
+  /*
+   * This should *never* be accessible on the client.
+   */
+  async $deleteSkipAC() {
+    this.$skipAcWhenDeleting = true;
+    return await this.$delete();
+  }
+
+  $tilmeldDeleteSkipAC() {
+    if (this.$skipAcWhenDeleting) {
+      this.$skipAcWhenDeleting = false;
+      return true;
     }
-    this.$nymph = nymph;
-    return success;
+    return false;
   }
 }