@nyaruka/temba-components 0.129.3 → 0.129.5

package/.eslintrc.js

@@ -16,6 +16,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
+    '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     'import/named': 'off',
     'import/no-unresolved': 'off',
     // Block console.log statements unless explicitly disabled

package/.github/workflows/build.yml

@@ -1,9 +1,10 @@
 name: 'build'
 
-on: [push]
+on: [push, pull_request]
 
 permissions:
   contents: write
+  pull-requests: write
 
 jobs:
   build:
@@ -20,17 +21,148 @@ jobs:
           fetch-depth: 0
       - run: docker network create --driver bridge textit_default
       - name: Build and run dev container task
+        id: validate
         uses: devcontainers/ci@v0.3
+        continue-on-error: true
         with:
-          runCmd: yarn validate
+          runCmd: |
+            yarn validate 2>&1 | tee validate_output.log
+            exit ${PIPESTATUS[0]}
           push: never
           env: |
             CI=true
 
+      - name: Extract coverage stats
+        if: always()
+        run: |
+          if [ -f validate_output.log ]; then
+            echo "Extracting coverage information from validate output..."
+            
+            # Extract coverage report section
+            COVERAGE_REPORT=$(grep -A 10 "📊 Coverage Report" validate_output.log | head -15 || echo "Coverage report not found")
+            
+            # Save coverage to environment file for PR comment
+            echo "COVERAGE_REPORT<<EOF" >> $GITHUB_ENV
+            echo "$COVERAGE_REPORT" >> $GITHUB_ENV
+            echo "EOF" >> $GITHUB_ENV
+            
+            # Also save individual metrics for easier parsing
+            LINES_COVERAGE=$(grep "Lines:" validate_output.log | grep -o '[0-9.]*%' | tail -1 || echo "N/A")
+            FUNCTIONS_COVERAGE=$(grep "Functions:" validate_output.log | grep -o '[0-9.]*%' | tail -1 || echo "N/A")
+            BRANCHES_COVERAGE=$(grep "Branches:" validate_output.log | grep -o '[0-9.]*%' | tail -1 || echo "N/A")
+            
+            echo "LINES_COVERAGE=$LINES_COVERAGE" >> $GITHUB_ENV
+            echo "FUNCTIONS_COVERAGE=$FUNCTIONS_COVERAGE" >> $GITHUB_ENV
+            echo "BRANCHES_COVERAGE=$BRANCHES_COVERAGE" >> $GITHUB_ENV
+            
+            echo "Coverage extracted:"
+            echo "Lines: $LINES_COVERAGE"
+            echo "Functions: $FUNCTIONS_COVERAGE" 
+            echo "Branches: $BRANCHES_COVERAGE"
+            
+            # Debug: show what coverage files we have
+            echo "Available coverage files:"
+            find . -name "coverage" -type d 2>/dev/null || echo "No coverage directories found"
+            find . -name "lcov-report" -type d 2>/dev/null || echo "No lcov-report directories found"
+          else
+            echo "No validate output found"
+          fi
+
+      - name: Comment coverage on PR
+        if: github.event_name == 'pull_request' && always()
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const coverageReport = process.env.COVERAGE_REPORT;
+            const linesCoverage = process.env.LINES_COVERAGE;
+            const functionsCoverage = process.env.FUNCTIONS_COVERAGE;
+            const branchesCoverage = process.env.BRANCHES_COVERAGE;
+
+            const body = `## 📊 Coverage Report
+
+            \`\`\`
+            ${coverageReport}
+            \`\`\`
+
+            ### Summary
+            - **Lines:** ${linesCoverage}
+            - **Functions:** ${functionsCoverage}
+            - **Branches:** ${branchesCoverage}
+
+            [Coverage Report](https://s3.us-east-1.amazonaws.com/dev.temba.io/coverage/temba-components/pr-${context.payload.number}/index.html)
+            `;
+
+            // Find existing coverage comment
+            const comments = await github.rest.issues.listComments({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.payload.number,
+            });
+
+            const existingComment = comments.data.find(comment => 
+              comment.user.login === 'github-actions[bot]' && 
+              comment.body.includes('📊 Coverage Report')
+            );
+
+            if (existingComment) {
+              // Update existing comment
+              await github.rest.issues.updateComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                comment_id: existingComment.id,
+                body: body
+              });
+            } else {
+              // Create new comment
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.payload.number,
+                body: body
+              });
+            }
+
+      - name: Configure AWS credentials
+        if: always()
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          aws-region: us-east-1
+
+      - name: Upload coverage report to S3
+        if: always()
+        run: |
+          # Check if coverage directory exists
+          if [ -d "coverage/lcov-report" ]; then
+            echo "Uploading coverage report to S3..."
+            
+            if [ "${{ github.event_name }}" == "pull_request" ]; then
+              # For PRs, upload to a PR-specific folder
+              S3_PATH="s3://dev.temba.io/coverage/temba-components/pr-${{ github.event.number }}/"
+            else
+              # For main branch, upload to main folder
+              S3_PATH="s3://dev.temba.io/coverage/temba-components/main/"
+            fi
+            
+            aws s3 sync coverage/lcov-report/ "$S3_PATH" --delete
+            echo "Coverage report uploaded to: $S3_PATH"
+          else
+            echo "No coverage report found to upload"
+          fi
+
+      - name: Check validation result
+        run: |
+          if [ "${{ steps.validate.outcome }}" != "success" ]; then
+            echo "❌ Validation failed"
+            exit 1
+          else
+            echo "✅ Validation passed"
+          fi
+
       - name: Upload artifacts
         if: failure()
         uses: actions/upload-artifact@v4
         with:
           name: screenshots
           path: screenshots/
-

package/CHANGELOG.md

@@ -4,8 +4,27 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v0.129.5](https://github.com/nyaruka/temba-components/compare/v0.129.3...v0.129.5)
+
+- Don't trigger ref change on internal values change for Select [`#648`](https://github.com/nyaruka/temba-components/pull/648)
+- Cleanup unused chat event types and remove some unused properties on other types [`#647`](https://github.com/nyaruka/temba-components/pull/647)
+- Nestable form layouts [`#644`](https://github.com/nyaruka/temba-components/pull/644)
+- Add KeyValueEditor and field config abstraction [`#643`](https://github.com/nyaruka/temba-components/pull/643)
+- Add send_email test [`#642`](https://github.com/nyaruka/temba-components/pull/642)
+- Add better action tests [`#641`](https://github.com/nyaruka/temba-components/pull/641)
+- Change coverage user and path [`#640`](https://github.com/nyaruka/temba-components/pull/640)
+- Update coverage storage for build [`#639`](https://github.com/nyaruka/temba-components/pull/639)
+- Add NodeConfig [`#638`](https://github.com/nyaruka/temba-components/pull/638)
+- Simplify ActionEditor form configuration by removing properties support and renaming transformations [`#637`](https://github.com/nyaruka/temba-components/pull/637)
+- Action editor [`#635`](https://github.com/nyaruka/temba-components/pull/635)
+- Introduce NodeConfig to complement ActionConfig [`3144a8b`](https://github.com/nyaruka/temba-components/commit/3144a8ba2ece77c35fe1610cc6b2fd2378874845)
+- Reorg flow config [`cb64d1f`](https://github.com/nyaruka/temba-components/commit/cb64d1fc24d8502442f854e612cf7d3b8723e5e8)
+- Add KeyValueEditor [`a138f41`](https://github.com/nyaruka/temba-components/commit/a138f41d9d62de3df79e82b0907cefac1997c0cf)
+
 #### [v0.129.3](https://github.com/nyaruka/temba-components/compare/v0.129.2...v0.129.3)
 
+> 29 July 2025
+
 - Don't attempt to show select items if loading [`#634`](https://github.com/nyaruka/temba-components/pull/634)
 - Fix sticky selection intersection [`#633`](https://github.com/nyaruka/temba-components/pull/633)
 - Flow Editor: Add missing action descriptions for flow rendering [`#632`](https://github.com/nyaruka/temba-components/pull/632)

package/demo/data/flows/sample-flow.json

@@ -16,9 +16,9 @@
             "text": "What is your favorite color?",
             "type": "send_msg",
             "quick_replies": [
-              "red",
-              "green",
-              "blue"
+              "Red",
+              "Green",
+              "Blue"
             ],
             "uuid": "3d56e4cf-1e88-499a-b0b4-ff48385fc9a5"
           }
@@ -75,7 +75,7 @@
             },
             {
               "uuid": "ee972b45-3bfe-4e93-9d4e-e9c8f8ffc587",
-              "name": "Blue",
+              "name": "Blue but longer so it hits the max width for categories in nodes",
               "exit_uuid": "3dfd68c4-0184-49d8-b2a4-0bbb62425f33"
             },
             {
@@ -127,13 +127,15 @@
         "actions": [
           {
             "uuid": "cb497975-a8fb-4d28-a662-277eb7a699f9",
-            "headers": {
-              "Accept": "application/json"
-            },
             "type": "call_webhook",
             "url": "http://google.com",
-            "body": "",
-            "method": "GET"
+            "method": "POST",
+            "headers": {
+              "Accepts": "application/json",
+              "Content-Type": "application/json",
+              "Authorization": "Bearer token here"
+            },
+            "body": "@(json(object(\n  \"contact\", object(\n    \"uuid\", contact.uuid, \n    \"name\", contact.name, \n    \"urn\", contact.urn\n  ),\n  \"flow\", object(\n    \"uuid\", run.flow.uuid, \n    \"name\", run.flow.name\n  ),\n  \"results\", foreach_value(results, extract_object, \"value\", \"category\")\n)))"
           }
         ],
         "router": {
@@ -152,14 +154,14 @@
           ],
           "categories": [
             {
-              "uuid": "0bb08076-45e2-4ca1-b321-1506f1779198",
+              "uuid": "1b9100a4-f3f0-410e-8b6f-d339bf58a13a",
               "name": "Success",
-              "exit_uuid": "4f1f8e3b-887c-42f5-bf59-fa59c5245dc2"
+              "exit_uuid": "e6d66511-f532-44c5-acbe-bede3963e677"
             },
             {
-              "uuid": "67fc0e41-eeb2-4f54-9f71-abdd64c097f4",
+              "uuid": "13915377-5eb1-46c5-8955-78646b75b8ef",
               "name": "Failure",
-              "exit_uuid": "4929ff2a-35cf-43a5-8353-dfede604add7"
+              "exit_uuid": "8087c747-eebc-4f35-8032-33490ba390d6"
             }
           ],
           "default_category_uuid": "67fc0e41-eeb2-4f54-9f71-abdd64c097f4",
@@ -167,12 +169,12 @@
         },
         "exits": [
           {
-            "uuid": "4f1f8e3b-887c-42f5-bf59-fa59c5245dc2",
+            "uuid": "e6d66511-f532-44c5-acbe-bede3963e677",
             "destination_uuid": "b85000c4-1990-4d86-807a-1318ea512708"
           },
           {
-            "uuid": "4929ff2a-35cf-43a5-8353-dfede604add7",
-            "destination_uuid": "8ecec688-f154-4b80-a0b3-3cbff0fac892"
+            "uuid": "8087c747-eebc-4f35-8032-33490ba390d6",
+            "destination_uuid": "b85000c4-1990-4d86-807a-1318ea512708"
           }
         ]
       },
@@ -180,42 +182,71 @@
         "uuid": "4efc49e0-ebfe-454d-a1a0-900a911dd5ef",
         "actions": [
           {
-            "attachments": [],
-            "text": "Excellent choice!",
+            "uuid": "9963160a-a007-4c7b-8c9e-7325e1b69ed8",
             "type": "send_msg",
-            "quick_replies": [],
-            "uuid": "9963160a-a007-4c7b-8c9e-7325e1b69ed8"
+            "text": "Excellent choices.",
+            "quick_replies": [
+              "blooooop",
+              "bleep"
+            ]
           },
           {
-            "type": "add_contact_groups",
+            "uuid": "ffe1c2d3-4e5f-6a7b-8c9d-e0f1a2b3c4d5",
+            "type": "remove_contact_groups",
             "groups": [
               {
-                "uuid": "269e8abf-e81b-404c-82ce-45ff42d13769",
-                "name": "Empty",
+                "uuid": "f80ed7b6-5e6a-49eb-94b6-4631a9677cd8",
+                "name": "Reporters",
                 "query": null,
                 "status": "ready",
-                "system": false,
                 "count": 0
               },
               {
-                "uuid": "58a6a3cd-20c0-4791-82da-ce9f319ab91b",
-                "name": "Farmers",
+                "uuid": "a3f2990b-4096-452e-a586-dc06a9434dde",
+                "name": "Empty",
                 "query": null,
                 "status": "ready",
-                "system": false,
-                "count": 2414
+                "count": 0
+              },
+              {
+                "uuid": "76e7a094-22ea-441d-91c4-283d8168e8e3",
+                "name": "Some Really Long Group Name",
+                "count": 2028
+              },
+              {
+                "uuid": "66e7a094-22ea-441d-91c4-283d8168e8e4",
+                "name": "The Poots",
+                "query": "name ~ \"poots\" OR name ~ \"dave\"",
+                "status": "ready",
+                "count": 1028
+              },
+              {
+                "uuid": "94e3ff12-9206-4ce8-87ab-934a864a1819",
+                "name": "Youth",
+                "query": "age <= 18",
+                "status": "ready",
+                "count": 174
               }
             ],
-            "uuid": "d1ca86da-f321-4e09-8bb2-981de03f5a90"
+            "all_groups": false
           },
           {
-            "addresses": [
-              "name@domain.com"
-            ],
-            "subject": "Did you get this?",
-            "body": "I hope it arrived!",
-            "type": "send_email",
-            "uuid": "a0f3f1f2-1869-4ad6-9fb0-e610a3e00ae7"
+            "uuid": "d1ca86da-f321-4e09-8bb2-981de03f5a90",
+            "type": "add_contact_groups",
+            "groups": [
+              {
+                "uuid": "a3f2990b-4096-452e-a586-dc06a9434dde",
+                "name": "Empty",
+                "query": null,
+                "status": "ready",
+                "count": 0
+              },
+              {
+                "uuid": "76e7a094-22ea-441d-91c4-283d8168e8e3",
+                "name": "Some Really Long Group Name",
+                "count": 2028
+              }
+            ]
           },
           {
             "type": "set_run_result",
@@ -249,39 +280,31 @@
             "language": "eng"
           },
           {
-            "type": "remove_contact_groups",
-            "groups": [
+            "uuid": "773fa48f-7341-4f57-bf74-2afed2e4b763",
+            "actions": [
               {
-                "uuid": "269e8abf-e81b-404c-82ce-45ff42d13769",
-                "name": "Empty"
-              },
-              {
-                "uuid": "2f81d414-47b7-446d-b8c7-6662f611cb3d",
-                "name": "Testers"
-              },
-              {
-                "uuid": "90c0dc52-ddd8-466d-8333-a96fdd67195a",
-                "name": "Teachers"
-              },
-              {
-                "uuid": "58a6a3cd-20c0-4791-82da-ce9f319ab91b",
-                "name": "Farmers"
-              },
-              {
-                "uuid": "3b9caef9-e701-4475-a0c3-ef346704f71e",
-                "name": "Reporters"
-              },
-              {
-                "uuid": "f4f46e03-3d7c-4840-8ed3-8c6c5677a2f2",
-                "name": "Doctors"
-              },
+                "type": "remove_contact_groups",
+                "groups": [],
+                "all_groups": true,
+                "uuid": "4f6a8bbb-5563-4bdb-8b53-e23490596fcd"
+              }
+            ],
+            "exits": [
               {
-                "uuid": "4b4ad0a2-0be6-4edd-8d6f-f6fa40ce695c",
-                "name": "Drivers"
+                "uuid": "f2265a88-4568-4105-8a0c-c698d32ff18f",
+                "destination_uuid": null
               }
+            ]
+          },
+          {
+            "uuid": "a0f3f1f2-1869-4ad6-9fb0-e610a3e00ae7",
+            "type": "send_email",
+            "addresses": [
+              "mistermeowface@whiskers.com",
+              "name@domain.com"
             ],
-            "all_groups": false,
-            "uuid": "6ec87721-6ec2-43fa-b7d2-930bf1f0574d"
+            "subject": "Did you get this?",
+            "body": "I hope it arrived! But this message is a bit longer."
           },
           {
             "type": "add_contact_urn",
@@ -515,7 +538,7 @@
           },
           {
             "uuid": "5ef3425c-f015-46a5-9975-046879eba986",
-            "destination_uuid": "e780a7ef-9dad-45a3-abda-11200a9afbf4"
+            "destination_uuid": "8ecec688-f154-4b80-a0b3-3cbff0fac892"
           }
         ]
       },
@@ -775,7 +798,7 @@
       "nodes": {
         "a229fa3c-16bb-440b-9ae8-b7ee7a723f44": {
           "position": {
-            "left": 280,
+            "left": 260,
             "top": 0
           },
           "type": "execute_actions"
@@ -793,30 +816,30 @@
         "e1f22e97-a170-44b4-a79b-98ab916f4c34": {
           "type": "split_by_webhook",
           "position": {
-            "left": 1020,
-            "top": 100
+            "left": 800,
+            "top": 0
           },
           "config": {}
         },
         "4efc49e0-ebfe-454d-a1a0-900a911dd5ef": {
           "position": {
             "left": 240,
-            "top": 380
+            "top": 340
           },
           "type": "execute_actions"
         },
         "2c60c381-487d-42cd-80be-a31f44c36fd9": {
           "type": "split_by_subflow",
           "position": {
-            "left": 580,
-            "top": 600
+            "left": 520,
+            "top": 680
           },
           "config": {}
         },
         "f115fdb0-d92d-47a2-96f3-e03e36767b14": {
           "type": "split_by_contact_field",
           "position": {
-            "left": 800,
+            "left": 1020,
             "top": 220
           },
           "config": {
@@ -831,8 +854,8 @@
         "b85000c4-1990-4d86-807a-1318ea512708": {
           "type": "split_by_expression",
           "position": {
-            "left": 1020,
-            "top": 440
+            "left": 720,
+            "top": 240
           },
           "config": {
             "cases": {}
@@ -841,16 +864,16 @@
         "8ecec688-f154-4b80-a0b3-3cbff0fac892": {
           "type": "split_by_random",
           "position": {
-            "left": 780,
-            "top": 380
+            "left": 940,
+            "top": 360
           },
           "config": null
         },
         "66171418-2368-44b9-95db-fdf7cd5cf4fe": {
           "type": "split_by_run_result",
           "position": {
-            "left": 900,
-            "top": 560
+            "left": 800,
+            "top": 600
           },
           "config": {
             "operand": {
@@ -865,7 +888,7 @@
           "type": "split_by_groups",
           "position": {
             "left": 500,
-            "top": 340
+            "top": 360
           },
           "config": {
             "cases": {}
@@ -874,8 +897,8 @@
         "e780a7ef-9dad-45a3-abda-11200a9afbf4": {
           "type": "split_by_scheme",
           "position": {
-            "left": 580,
-            "top": 480
+            "left": 480,
+            "top": 560
           },
           "config": {
             "cases": {}
@@ -885,22 +908,22 @@
           "type": "split_by_llm",
           "position": {
             "left": 580,
-            "top": 880
+            "top": 1040
           },
           "config": {}
         },
         "425c4757-bead-440f-92aa-a1cc3fcd7d35": {
           "position": {
-            "left": 900,
-            "top": 740
+            "left": 620,
+            "top": 840
           },
           "type": "execute_actions"
         },
         "21ff86c2-5276-4448-afb6-54d1f832ba0c": {
           "type": "split_by_ticket",
           "position": {
-            "left": 900,
-            "top": 860
+            "left": 920,
+            "top": 900
           },
           "config": {}
         }