@nxtedition/scheduler 3.0.4 → 3.0.5

package/lib/index.js

@@ -1,15 +1,8 @@
-import os from 'node:os'
-
 const RUNNING_INDEX = 0
 const CONCURRENCY_INDEX = 1
 
 const maxInt = 2147483647
 
-// On x86/x64, aligned 32-bit reads do not tear, so a plain array access is safe
-// and avoids the overhead of Atomics.load() in V8. On other architectures (e.g. ARM),
-// use Atomics.load() to prevent tearing.
-const useAtomicLoad = os.arch() !== 'x64' && os.arch() !== 'ia32'
-
 class FastQueue {
   idx = 0
   cnt = 0
@@ -152,22 +145,21 @@ export class Scheduler {
     const queue = this.#queues[p + 3]
 
     if (this.#stateView) {
-      // NOTE: The read of stateView followed by Atomics.add is a TOCTOU race. Multiple
-      // workers may simultaneously read a value below the concurrency limit and all
-      // proceed, briefly exceeding it by up to N-1 (where N is the number of workers).
-      // This is by design — the concurrency limit is a soft / best-effort constraint.
-      // Small, transient over-subscriptions are acceptable and self-correcting on the
-      // next release() cycle.
-      // Plain array read on x86 (aligned 32-bit reads don't tear); Atomics.load elsewhere.
-      const running = useAtomicLoad
-        ? Atomics.load(this.#stateView, RUNNING_INDEX)
-        : this.#stateView[RUNNING_INDEX]
-      if (this.#running < 1 || running < this.#concurrency) {
+      // Make sure we are always running at least one local job even if we might globally over subscribe.
+      if (this.#running < 1) {
         Atomics.add(this.#stateView, RUNNING_INDEX, 1)
         this.#running += 1
         fn(opaque)
         return
       }
+
+      if (Atomics.add(this.#stateView, RUNNING_INDEX, 1) >= this.#concurrency) {
+        Atomics.sub(this.#stateView, RUNNING_INDEX, 1)
+      } else {
+        this.#running += 1
+        fn(opaque)
+        return
+      }
     } else if ((this.#running < 1 && this.#concurrency > 0) || this.#running < this.#concurrency) {
       this.#running += 1
       fn(opaque)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/scheduler",
-  "version": "3.0.4",
+  "version": "3.0.5",
   "type": "module",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -27,5 +27,5 @@
     "rimraf": "^6.1.2",
     "typescript": "^5.9.3"
   },
-  "gitHead": "17807cefcac092e20ebf99befddf0e742e5fc0e2"
+  "gitHead": "6174bfadecfd6232d4fd5c526fecf17d24528ff3"
 }