@nxtedition/rocksdb 7.1.13 → 7.1.14

package/binding.cc

@@ -696,6 +696,7 @@ NAPI_METHOD(db_open) {
   NAPI_STATUS_THROWS(GetProperty(env, options, "createIfMissing", dbOptions.create_if_missing));
   NAPI_STATUS_THROWS(GetProperty(env, options, "errorIfExists", dbOptions.error_if_exists));
   NAPI_STATUS_THROWS(GetProperty(env, options, "unorderedWrite", dbOptions.unordered_write));
+  NAPI_STATUS_THROWS(GetProperty(env, options, "pipelinedWrite", dbOptions.enable_pipelined_write));
 
   // TODO (feat): dbOptions.listeners
 

package/index.js

@@ -311,7 +311,9 @@ class RocksLevel extends AbstractLevel {
     options = {
       since: options?.since ?? 0,
       keys: options?.keys ?? true,
+      keyEncoding: options?.keyEncoding,
       values: options?.values ?? true,
+      valueEncoding: options?.valueEncoding,
       data: options?.data ?? true,
       live: options?.live ?? false,
       column: options?.column ?? null,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "7.1.13",
+  "version": "7.1.14",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",

package/util.h

@@ -231,6 +231,17 @@ static napi_status GetProperty(napi_env env,
                                const std::string_view& key,
                                T& result,
                                bool required = false) {
+  napi_valuetype objType;
+  NAPI_STATUS_RETURN(napi_typeof(env, obj, &objType));
+
+  if (objType == napi_undefined || objType == napi_null) {
+    return napi_ok;
+  }
+
+  if (objType != napi_object) {
+    return napi_invalid_arg;
+  }
+
   bool has = false;
   NAPI_STATUS_RETURN(napi_has_named_property(env, obj, key.data(), &has));
 
@@ -241,19 +252,10 @@ static napi_status GetProperty(napi_env env,
   napi_value value;
   NAPI_STATUS_RETURN(napi_get_named_property(env, obj, key.data(), &value));
 
-  bool nully = false;
-
-  napi_value nullVal;
-  NAPI_STATUS_RETURN(napi_get_null(env, &nullVal));
-  NAPI_STATUS_RETURN(napi_strict_equals(env, nullVal, value, &nully));
-  if (nully) {
-    return required ? napi_invalid_arg : napi_ok;
-  }
+  napi_valuetype valueType;
+  NAPI_STATUS_RETURN(napi_typeof(env, value, &valueType));
 
-  napi_value undefinedVal;
-  NAPI_STATUS_RETURN(napi_get_undefined(env, &undefinedVal));
-  NAPI_STATUS_RETURN(napi_strict_equals(env, undefinedVal, value, &nully));
-  if (nully) {
+  if (valueType == napi_null || valueType == napi_undefined) {
     return required ? napi_invalid_arg : napi_ok;
   }