@nxtedition/rocksdb 7.0.7 → 7.0.8

package/binding.cc

@@ -6,10 +6,12 @@
 
 #include <rocksdb/cache.h>
 #include <rocksdb/comparator.h>
+#include <rocksdb/convenience.h>
 #include <rocksdb/db.h>
 #include <rocksdb/env.h>
 #include <rocksdb/filter_policy.h>
 #include <rocksdb/options.h>
+#include <rocksdb/slice_transform.h>
 #include <rocksdb/table.h>
 #include <rocksdb/write_batch.h>
 
@@ -40,6 +42,14 @@ struct Updates;
     }                            \
   }
 
+#define ROCKS_STATUS_RETURN(call) \
+  {                               \
+    auto _status = (call);        \
+    if (!_status.ok()) {          \
+      return _status;             \
+    }                             \
+  }
+
 #define ROCKS_STATUS_THROWS(call)             \
   {                                           \
     auto _status = (call);                    \
@@ -676,7 +686,7 @@ struct OpenWorker final : public Worker {
 };
 
 template <typename T, typename U>
-napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
+rocksdb::Status InitOptions(napi_env env, T& columnOptions, const U& options) {
   const auto memtable_memory_budget = Uint32Property(env, options, "memtableMemoryBudget").value_or(256 * 1024 * 1024);
 
   const auto compaction = StringProperty(env, options, "compaction").value_or("level");
@@ -720,6 +730,20 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
     // TODO (perf): compression_opts.parallel_threads
   }
 
+  const auto prefixExtractorOpt = StringProperty(env, options, "prefixExtractor");
+  if (prefixExtractorOpt) {
+    rocksdb::ConfigOptions configOptions;
+    ROCKS_STATUS_RETURN(
+        rocksdb::SliceTransform::CreateFromString(configOptions, *prefixExtractorOpt, &columnOptions.prefix_extractor));
+  }
+
+  const auto comparatorOpt = StringProperty(env, options, "comparator");
+  if (comparatorOpt) {
+    rocksdb::ConfigOptions configOptions;
+    ROCKS_STATUS_RETURN(
+        rocksdb::Comparator::CreateFromString(configOptions, *comparatorOpt, &columnOptions.comparator));
+  }
+
   const auto cacheSize = Uint32Property(env, options, "cacheSize").value_or(8 << 20);
 
   rocksdb::BlockBasedTableOptions tableOptions;
@@ -756,7 +780,7 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
 
   columnOptions.table_factory.reset(rocksdb::NewBlockBasedTableFactory(tableOptions));
 
-  return napi_ok;
+  return rocksdb::Status::OK();
 }
 
 NAPI_METHOD(db_open) {
@@ -776,6 +800,7 @@ NAPI_METHOD(db_open) {
   dbOptions.create_if_missing = BooleanProperty(env, argv[2], "createIfMissing").value_or(true);
   dbOptions.error_if_exists = BooleanProperty(env, argv[2], "errorIfExists").value_or(false);
   dbOptions.avoid_unnecessary_blocking_io = true;
+  dbOptions.write_dbid_to_manifest = true;
   dbOptions.use_adaptive_mutex = true;       // We don't have soo many threads in the libuv thread pool...
   dbOptions.enable_pipelined_write = false;  // We only write in the main thread...
   dbOptions.max_background_jobs = Uint32Property(env, argv[2], "maxBackgroundJobs")
@@ -784,6 +809,12 @@ NAPI_METHOD(db_open) {
   dbOptions.WAL_size_limit_MB = Uint32Property(env, argv[2], "walSizeLimit").value_or(0) / 1e6;
   dbOptions.create_missing_column_families = true;
   dbOptions.unordered_write = BooleanProperty(env, argv[2], "unorderedWrite").value_or(false);
+  dbOptions.fail_if_options_file_error = true;
+  dbOptions.wal_compression = BooleanProperty(env, argv[2], "walCompression").value_or(false)
+                                  ? rocksdb::CompressionType::kZSTD
+                                  : rocksdb::CompressionType::kNoCompression;
+
+  // TODO (feat): dbOptions.listeners
 
   const auto infoLogLevel = StringProperty(env, argv[2], "infoLogLevel").value_or("");
   if (infoLogLevel.size() > 0) {
@@ -812,7 +843,7 @@ NAPI_METHOD(db_open) {
     dbOptions.info_log.reset(new NullLogger());
   }
 
-  NAPI_STATUS_THROWS(InitOptions(env, dbOptions, argv[2]));
+  ROCKS_STATUS_THROWS(InitOptions(env, dbOptions, argv[2]));
 
   std::vector<rocksdb::ColumnFamilyDescriptor> columnsFamilies;
 
@@ -837,7 +868,7 @@ NAPI_METHOD(db_open) {
       napi_value column;
       NAPI_STATUS_THROWS(napi_get_property(env, columns, key, &column));
 
-      NAPI_STATUS_THROWS(InitOptions(env, columnsFamilies[n].options, column));
+      ROCKS_STATUS_THROWS(InitOptions(env, columnsFamilies[n].options, column));
 
       NAPI_STATUS_THROWS(ToString(env, key, columnsFamilies[n].name));
     }
@@ -1112,22 +1143,26 @@ struct GetManyWorker final : public Worker {
                 std::vector<std::string> keys,
                 napi_value callback,
                 const bool valueAsBuffer,
-                const bool fillCache)
+                const bool fillCache,
+                const bool ignoreRangeDeletions)
       : Worker(env, database, callback, "leveldown.get.many"),
         column_(column),
         keys_(std::move(keys)),
         valueAsBuffer_(valueAsBuffer),
         fillCache_(fillCache),
-        snapshot_(database_->db_->GetSnapshot(), [=](const auto ptr) { database_->db_->ReleaseSnapshot(ptr); }) {
+        ignoreRangeDeletions_(ignoreRangeDeletions),
+        snapshot_(database_->db_->GetSnapshot()) {
     database_->IncrementPriorityWork(env);
   }
 
+  ~GetManyWorker() { database_->db_->ReleaseSnapshot(snapshot_); }
+
   rocksdb::Status Execute(Database& database) override {
     rocksdb::ReadOptions readOptions;
     readOptions.fill_cache = fillCache_;
-    readOptions.snapshot = snapshot_.get();
+    readOptions.snapshot = snapshot_;
     readOptions.async_io = true;
-    readOptions.adaptive_readahead = true;
+    readOptions.ignore_range_deletions = ignoreRangeDeletions_;
 
     std::vector<rocksdb::Slice> keys;
     keys.reserve(keys_.size());
@@ -1182,7 +1217,8 @@ struct GetManyWorker final : public Worker {
   std::vector<rocksdb::Status> statuses_;
   const bool valueAsBuffer_;
   const bool fillCache_;
-  std::shared_ptr<const rocksdb::Snapshot> snapshot_;
+  const bool ignoreRangeDeletions_;
+  const rocksdb::Snapshot* snapshot_;
 };
 
 NAPI_METHOD(db_get_many) {
@@ -1206,11 +1242,13 @@ NAPI_METHOD(db_get_many) {
 
   const bool asBuffer = EncodingIsBuffer(env, argv[2], "valueEncoding");
   const bool fillCache = BooleanProperty(env, argv[2], "fillCache").value_or(true);
+  const bool ignoreRangeDeletions = BooleanProperty(env, argv[2], "ignoreRangeDeletions").value_or(false);
 
   rocksdb::ColumnFamilyHandle* column;
   NAPI_STATUS_THROWS(GetColumnFamily(database, env, argv[2], &column));
 
-  auto worker = new GetManyWorker(env, database, column, std::move(keys), argv[3], asBuffer, fillCache);
+  auto worker =
+      new GetManyWorker(env, database, column, std::move(keys), argv[3], asBuffer, fillCache, ignoreRangeDeletions);
   worker->Queue(env);
 
   return 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "7.0.7",
+  "version": "7.0.8",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",