@nxtedition/rocksdb 7.0.57 → 7.0.60

package/deps/rocksdb/rocksdb/db/wal_manager.cc

@@ -366,7 +366,7 @@ Status WalManager::RetainProbableWalFiles(VectorLogPtr& all_logs,
     }
   }
   // end could be -ve.
-  size_t start_index = static_cast<size_t>(std::max(static_cast<int64_t>(0), end - 1));
+  size_t start_index = static_cast<size_t>(std::max(static_cast<int64_t>(0), end));
   // The last wal file is always included
   all_logs.erase(all_logs.begin(), all_logs.begin() + start_index);
   return Status::OK();

package/index.js

@@ -341,14 +341,19 @@ class RocksLevel extends AbstractLevel {
     options.signal?.addEventListener('abort', onAbort)
     this.on('closing', onAbort)
 
+    const db = this
+
     // HACK: https://github.com/facebook/rocksdb/issues/10476
     async function* _updates (options) {
       let first = true
-      for await (const update of this[kUpdates](options)) {
+      for await (const update of db[kUpdates](options)) {
         if (first) {
           if (update.sequence > options.since) {
-            this.emit('warning', `Invalid sequence ${update.sequence} > ${options.since}. Starting from 0.`)
-            first = null
+            // HACK
+            db.emit('warning', `Invalid update sequence ${update.sequence} > ${options.since}. Starting from 0.`)
+            for await (const update of db[kUpdates]({ ...options, since: 0 })) {
+              yield update
+            }
             break
           } else {
             first = false
@@ -356,18 +361,10 @@ class RocksLevel extends AbstractLevel {
         }
         yield update
       }
-
-      if (first === null) {
-        for await (const update of this[kUpdates]({ ...options, since: 0 })) {
-          yield update
-        }
-      }
     }
 
     try {
       let since = options.since
-
-      const db = this
       while (true) {
         const buffer = new Readable({
           signal: ac.signal,
@@ -399,7 +396,7 @@ class RocksLevel extends AbstractLevel {
         }
 
         try {
-          if (since <= this.sequence) {
+          if (since <= db.sequence) {
             for await (const update of _updates(options)) {
               if (ac.signal.aborted) {
                 throw new AbortError()
@@ -421,7 +418,16 @@ class RocksLevel extends AbstractLevel {
           return
         }
 
+        let first = true
         for await (const update of buffer) {
+          if (first) {
+            if (update.sequence > since) {
+              // HACK
+              db.emit('warning', `Invalid batch sequence. Restarting.`)
+              break
+            }
+            first = false
+          }
           if (update.sequence >= since) {
             yield update
             since = update.sequence + update.count

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "7.0.57",
+  "version": "7.0.60",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",