@nxtedition/rocksdb 7.0.30 → 7.0.31

package/binding.cc

@@ -856,11 +856,11 @@ NAPI_METHOD(db_open) {
     NAPI_STATUS_THROWS(napi_set_named_property(env, ret, "maxBackgroundJobs", maxBackgroundJobs));
 
     napi_value walTTL;
-    NAPI_STATUS_THROWS(napi_create_int64(env, dbOptions.WAL_ttl_seconds, &walTTL));
+    NAPI_STATUS_THROWS(napi_create_int64(env, dbOptions.WAL_ttl_seconds * 1e3, &walTTL));
     NAPI_STATUS_THROWS(napi_set_named_property(env, ret, "walTTL", walTTL));
 
     napi_value walSizeLimit;
-    NAPI_STATUS_THROWS(napi_create_int64(env, dbOptions.WAL_size_limit_MB, &walSizeLimit));
+    NAPI_STATUS_THROWS(napi_create_int64(env, dbOptions.WAL_size_limit_MB * 1e6, &walSizeLimit));
     NAPI_STATUS_THROWS(napi_set_named_property(env, ret, "walSizeLimit", walSizeLimit));
 
     napi_value walCompression;
@@ -1149,15 +1149,30 @@ NAPI_METHOD(updates_init) {
   Database* database;
   NAPI_STATUS_THROWS(napi_get_value_external(env, argv[0], reinterpret_cast<void**>(&database)));
 
-  const auto seqNumber = Int64Property(env, argv[1], "since").value_or(database->db_->GetLatestSequenceNumber());
-  const auto keys = BooleanProperty(env, argv[1], "keys").value_or(true);
-  const auto values = BooleanProperty(env, argv[1], "values").value_or(true);
-  const auto data = BooleanProperty(env, argv[1], "data").value_or(true);
+  napi_value sinceProperty;
+  int64_t since;
+  NAPI_STATUS_THROWS(napi_get_named_property(env, argv[1], "since", &sinceProperty));
+  NAPI_STATUS_THROWS(napi_get_value_int64(env, sinceProperty, &since));
+
+  napi_value keysProperty;
+  bool keys;
+  NAPI_STATUS_THROWS(napi_get_named_property(env, argv[1], "keys", &keysProperty));
+  NAPI_STATUS_THROWS(napi_get_value_bool(env, keysProperty, &keys));
+
+  napi_value valuesProperty;
+  bool values;
+  NAPI_STATUS_THROWS(napi_get_named_property(env, argv[1], "values", &valuesProperty));
+  NAPI_STATUS_THROWS(napi_get_value_bool(env, valuesProperty, &values));
+
+  napi_value dataProperty;
+  bool data;
+  NAPI_STATUS_THROWS(napi_get_named_property(env, argv[1], "data", &dataProperty));
+  NAPI_STATUS_THROWS(napi_get_value_bool(env, dataProperty, &data));
 
   rocksdb::ColumnFamilyHandle* column;
   NAPI_STATUS_THROWS(GetColumnFamily(database, env, argv[1], &column, false));
 
-  auto updates = std::make_unique<Updates>(database, seqNumber, keys, values, data, column);
+  auto updates = std::make_unique<Updates>(database, since, keys, values, data, column);
 
   napi_value result;
   NAPI_STATUS_THROWS(napi_create_external(env, updates.get(), Finalize<Updates>, updates.get(), &result));

package/index.js

@@ -151,14 +151,32 @@ class RocksLevel extends AbstractLevel {
   }
 
   async getCurrentWALFile () {
+    if (this.status !== 'open') {
+      throw new ModuleError('Database is not open', {
+        code: 'LEVEL_DATABASE_NOT_OPEN'
+      })
+    }
+
     return binding.db_get_current_wal_file(this[kContext])
   }
 
   async getSortedWALFiles () {
+    if (this.status !== 'open') {
+      throw new ModuleError('Database is not open', {
+        code: 'LEVEL_DATABASE_NOT_OPEN'
+      })
+    }
+
     return binding.db_get_sorted_wal_files(this[kContext])
   }
 
   async flushWAL (options) {
+    if (this.status !== 'open') {
+      throw new ModuleError('Database is not open', {
+        code: 'LEVEL_DATABASE_NOT_OPEN'
+      })
+    }
+
     binding.db_flush_wal(this[kContext], options)
   }
 
@@ -208,6 +226,29 @@ class RocksLevel extends AbstractLevel {
       })
     }
 
+    options = {
+      since: options?.since ?? 0,
+      keys: options?.keys ?? true,
+      values: options?.values ?? true,
+      data: options?.data ?? true
+    }
+
+    if (typeof options.since !== 'number') {
+      throw new TypeError("'since' must be nully or a number")
+    }
+
+    if (typeof options.keys !== 'boolean') {
+      throw new TypeError("'keys' must be nully or a boolean")
+    }
+
+    if (typeof options.values !== 'boolean') {
+      throw new TypeError("'values' must be nully or a boolean")
+    }
+
+    if (typeof options.data !== 'boolean') {
+      throw new TypeError("'data' must be nully or a boolean")
+    }
+
     class Updates {
       constructor (db, options) {
         this.context = binding.updates_init(db[kContext], options)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "7.0.30",
+  "version": "7.0.31",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",