@nxtedition/rocksdb 7.0.16 → 7.0.19

package/binding.cc

@@ -539,11 +539,8 @@ struct Iterator final : public BaseIterator {
 };
 
 struct Updates {
-  Updates(Database* database, bool values, bool keyAsBuffer, bool valueAsBuffer, int64_t seqNumber)
+  Updates(Database* database, int64_t seqNumber)
       : database_(database),
-        values_(values),
-        keyAsBuffer_(keyAsBuffer),
-        valueAsBuffer_(valueAsBuffer),
         seqNumber_(seqNumber) {}
 
   void Close() { iterator_.reset(); }
@@ -561,9 +558,6 @@ struct Updates {
   }
 
   Database* database_;
-  const bool values_;
-  const bool keyAsBuffer_;
-  const bool valueAsBuffer_;
   int64_t seqNumber_;
   std::unique_ptr<rocksdb::TransactionLogIterator> iterator_;
 
@@ -964,15 +958,18 @@ struct UpdatesNextWorker final : public rocksdb::WriteBatch::Handler, public Wor
     }
 
     NAPI_STATUS_RETURN(napi_create_array_with_length(env, cache_.size(), &argv[1]));
+    for (size_t idx = 0; idx < cache_.size(); idx += 3) {
+      napi_value op;
+      NAPI_STATUS_RETURN(Convert(env, cache_[idx + 0], false, op));
+      NAPI_STATUS_RETURN(napi_set_element(env, argv[1], static_cast<int>(idx + 0), op));
 
-    for (size_t idx = 0; idx < cache_.size(); idx += 2) {
       napi_value key;
-      NAPI_STATUS_RETURN(Convert(env, cache_[idx + 0], updates_->keyAsBuffer_, key));
-      NAPI_STATUS_RETURN(napi_set_element(env, argv[1], static_cast<int>(idx + 0), key));
+      NAPI_STATUS_RETURN(Convert(env, cache_[idx + 1], false, key));
+      NAPI_STATUS_RETURN(napi_set_element(env, argv[1], static_cast<int>(idx + 1), key));
 
       napi_value val;
-      NAPI_STATUS_RETURN(Convert(env, cache_[idx + 1], updates_->valueAsBuffer_, val));
-      NAPI_STATUS_RETURN(napi_set_element(env, argv[1], static_cast<int>(idx + 1), val));
+      NAPI_STATUS_RETURN(Convert(env, cache_[idx + 2], false, val));
+      NAPI_STATUS_RETURN(napi_set_element(env, argv[1], static_cast<int>(idx + 2), val));
     }
 
     NAPI_STATUS_RETURN(napi_create_bigint_int64(env, updates_->seqNumber_, &argv[2]));
@@ -986,17 +983,27 @@ struct UpdatesNextWorker final : public rocksdb::WriteBatch::Handler, public Wor
   }
 
   void Put(const rocksdb::Slice& key, const rocksdb::Slice& value) override {
-    cache_.emplace_back(key.ToString());
-    if (updates_->values_) {
-      cache_.emplace_back(value.ToString());
-    } else {
-      cache_.emplace_back(std::nullopt);
-    }
+    cache_.emplace_back("put");
+    cache_.emplace_back(key.ToStringView());
+    cache_.emplace_back(value.ToStringView());
   }
 
   void Delete(const rocksdb::Slice& key) override {
-    cache_.emplace_back(key.ToString());
+    cache_.emplace_back("del");
+    cache_.emplace_back(key.ToStringView());
+    cache_.emplace_back(std::nullopt);
+  }
+
+  void Merge(const rocksdb::Slice& key, const rocksdb::Slice& value) override {
+    cache_.emplace_back("merge");
+    cache_.emplace_back(key.ToStringView());
+    cache_.emplace_back(value.ToStringView());
+  }
+
+  void LogData(const rocksdb::Slice& data) override {
+    cache_.emplace_back("data");
     cache_.emplace_back(std::nullopt);
+    cache_.emplace_back(data.ToStringView());
   }
 
   bool Continue() override { return true; }
@@ -1012,12 +1019,9 @@ NAPI_METHOD(updates_init) {
   Database* database;
   NAPI_STATUS_THROWS(napi_get_value_external(env, argv[0], reinterpret_cast<void**>(&database)));
 
-  const auto values = BooleanProperty(env, argv[1], "values").value_or(true);
-  const bool keyAsBuffer = EncodingIsBuffer(env, argv[1], "keyEncoding");
-  const bool valueAsBuffer = EncodingIsBuffer(env, argv[1], "valueEncoding");
   const auto seqNumber = Int64Property(env, argv[1], "since").value_or(database->db_->GetLatestSequenceNumber());
 
-  auto updates = std::make_unique<Updates>(database, values, keyAsBuffer, valueAsBuffer, seqNumber);
+  auto updates = std::make_unique<Updates>(database, seqNumber);
 
   napi_value result;
   NAPI_STATUS_THROWS(napi_create_external(env, updates.get(), Finalize<Updates>, updates.get(), &result));
@@ -1720,6 +1724,23 @@ NAPI_METHOD(batch_write) {
   return 0;
 }
 
+NAPI_METHOD(batch_put_log_data) {
+  NAPI_ARGV(4);
+
+  Database* database;
+  NAPI_STATUS_THROWS(napi_get_value_external(env, argv[0], reinterpret_cast<void**>(&database)));
+
+  rocksdb::WriteBatch* batch;
+  NAPI_STATUS_THROWS(napi_get_value_external(env, argv[1], reinterpret_cast<void**>(&batch)));
+
+  std::string logData;
+  NAPI_STATUS_THROWS(ToString(env, argv[2], logData));
+
+  ROCKS_STATUS_THROWS(batch->PutLogData(logData));
+
+  return 0;
+}
+
 NAPI_INIT() {
   NAPI_EXPORT_FUNCTION(db_init);
   NAPI_EXPORT_FUNCTION(db_open);
@@ -1748,4 +1769,5 @@ NAPI_INIT() {
   NAPI_EXPORT_FUNCTION(batch_del);
   NAPI_EXPORT_FUNCTION(batch_clear);
   NAPI_EXPORT_FUNCTION(batch_write);
+  NAPI_EXPORT_FUNCTION(batch_put_log_data);
 }

package/chained-batch.js

@@ -38,6 +38,11 @@ class ChainedBatch extends AbstractChainedBatch {
   _close (callback) {
     process.nextTick(callback)
   }
+
+  putLogData (data, options) {
+    // TODO (fix): Check if open...
+    binding.batch_put_log_data(this[kDbContext], this[kBatchContext], data, options)
+  }
 }
 
 exports.ChainedBatch = ChainedBatch

package/index.js

@@ -208,12 +208,12 @@ class RocksLevel extends AbstractLevel {
           return {}
         }
 
-        this.promise = new Promise(resolve => binding.updates_next(this.context, (err, rows, sequence) => {
+        this.promise = new Promise(resolve => binding.updates_next(this.context, (err, rows, sequence, data) => {
           this.promise = null
           if (err) {
             resolve(Promise.reject(err))
           } else {
-            resolve({ rows, sequence })
+            resolve({ rows, data, sequence: Number(sequence) })
           }
         }))
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "7.0.16",
+  "version": "7.0.19",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",