@nxtedition/rocksdb 5.2.38 → 5.2.39

package/binding.cc

@@ -221,7 +221,7 @@ napi_status Convert(napi_env env, rocksdb::PinnableSlice s, bool asBuffer, napi_
 
 struct NapiSlice : public rocksdb::Slice {
   std::unique_ptr<char[]> heap_;
-  std::array<char, 1024> stack_;
+  std::array<char, 128> stack_;
 };
 
 napi_status ToNapiSlice(napi_env env, napi_value from, NapiSlice& slice) {
@@ -602,6 +602,7 @@ NAPI_METHOD(db_open) {
                                                                                       : rocksdb::kNoCompression;
   options.use_adaptive_mutex = true;
   options.enable_pipelined_write = true;
+  options.max_background_jobs = std::thread::hardware_concurrency() / 4;
 
   // TODO: Consider direct IO (https://github.com/facebook/rocksdb/wiki/Direct-IO) once
   // secondary compressed cache is stable.
@@ -640,8 +641,10 @@ NAPI_METHOD(db_open) {
 
   if (cacheSize) {
     tableOptions.block_cache = rocksdb::NewLRUCache(cacheSize);
+    tableOptions.cache_index_and_filter_blocks = BooleanProperty(env, argv[2], "cacheIndexAndFilterBlocks").value_or(true);
   } else {
     tableOptions.no_block_cache = true;
+    tableOptions.cache_index_and_filter_blocks = false;
   }
 
   tableOptions.block_size = Uint32Property(env, argv[2], "blockSize").value_or(4096);
@@ -650,7 +653,6 @@ NAPI_METHOD(db_open) {
   tableOptions.format_version = 5;
   tableOptions.checksum = rocksdb::kXXH3;
   tableOptions.optimize_filters_for_memory = BooleanProperty(env, argv[2], "optimizeFiltersForMemory").value_or(true);
-  tableOptions.cache_index_and_filter_blocks = BooleanProperty(env, argv[2], "cacheIndexAndFilterBlocks").value_or(true);
 
   options.table_factory.reset(rocksdb::NewBlockBasedTableFactory(tableOptions));
 

package/deps/rocksdb/rocksdb.gyp

@@ -84,6 +84,8 @@
               "ROCKSDB_RANGESYNC_PRESENT=1",
               "ROCKSDB_SCHED_GETCPU_PRESENT=1",
               "ROCKSDB_IOURING_PRESENT=1",
+              # "ROCKSDB_JEMALLOC=1",
+              # "JEMALLOC_NO_DEMANGLE=1",
               "HAVE_SSE42=1",
               "HAVE_BMI=1",
               "HAVE_LZCNT=1",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "5.2.38",
+  "version": "5.2.39",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",