@nxtedition/rocksdb 5.2.36 → 5.2.37

package/binding.cc

@@ -96,7 +96,7 @@ static bool HasProperty(napi_env env, napi_value obj, const std::string_view& ke
 }
 
 static napi_value GetProperty(napi_env env, napi_value obj, const std::string_view& key) {
-  napi_value value;
+  napi_value value = nullptr;
   napi_get_named_property(env, obj, key.data(), &value);
   return value;
 }
@@ -226,7 +226,7 @@ napi_status Convert(napi_env env, std::string s, bool asBuffer, napi_value& resu
 napi_status Convert(napi_env env, rocksdb::PinnableSlice s, bool asBuffer, napi_value& result) {
   if (asBuffer) {
     auto ptr = new rocksdb::PinnableSlice(std::move(s));
-    return napi_create_external_buffer(env, ptr->size(), const_cast<char*>(ptr->data()), Finalize<std::string>, ptr,
+    return napi_create_external_buffer(env, ptr->size(), const_cast<char*>(ptr->data()), Finalize<rocksdb::PinnableSlice>, ptr,
                                        &result);
   } else {
     return napi_create_string_utf8(env, s.data(), s.size(), &result);
@@ -1150,20 +1150,12 @@ NAPI_METHOD(batch_do) {
     const auto type = StringProperty(env, element, "type");
 
     if (type == "del") {
-      if (!HasProperty(env, element, "key"))
-        continue;
-
       const auto key = NapiSlice(env, GetProperty(env, element, "key"));
 
       NAPI_PENDING_EXCEPTION();
 
       batch.Delete(key);
     } else if (type == "put") {
-      if (!HasProperty(env, element, "key"))
-        continue;
-      if (!HasProperty(env, element, "value"))
-        continue;
-
       const auto key = NapiSlice(env, GetProperty(env, element, "key"));
       const auto value = NapiSlice(env, GetProperty(env, element, "value"));
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "5.2.36",
+  "version": "5.2.37",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",