@nxtedition/rocksdb 13.0.0 → 13.0.2

package/binding.cc

@@ -885,6 +885,9 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
     }
   }
 
+  columnOptions.optimize_filters_for_hits = false;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "optimizeFiltersForHits", columnOptions.optimize_filters_for_hits));
+
   uint32_t cacheSize = 8 << 20;
   NAPI_STATUS_RETURN(GetProperty(env, options, "cacheSize", cacheSize));
 
@@ -892,11 +895,8 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
 
   if (cacheSize) {
     tableOptions.block_cache = rocksdb::HyperClockCacheOptions(cacheSize, 0).MakeSharedCache();
-    NAPI_STATUS_RETURN(
-        GetProperty(env, options, "cacheIndexAndFilterBlocks", tableOptions.cache_index_and_filter_blocks));
   } else {
     tableOptions.no_block_cache = true;
-    tableOptions.cache_index_and_filter_blocks = false;
   }
 
   std::string optimize = "";
@@ -905,7 +905,7 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
   if (optimize == "point-lookup") {
     tableOptions.data_block_index_type = rocksdb::BlockBasedTableOptions::kDataBlockBinaryAndHash;
     tableOptions.data_block_hash_table_util_ratio = 0.75;
-    tableOptions.filter_policy.reset(rocksdb::NewRibbonFilterPolicy(10, 1));
+    tableOptions.filter_policy.reset(rocksdb::NewRibbonFilterPolicy(10, 2));
 
     columnOptions.memtable_prefix_bloom_size_ratio = 0.02;
     columnOptions.memtable_whole_key_filtering = true;
@@ -915,9 +915,6 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
     tableOptions.filter_policy.reset(rocksdb::NewBloomFilterPolicy(10));
   }
 
-  tableOptions.enable_index_compression = false;
-  NAPI_STATUS_RETURN(GetProperty(env, options, "enableIndexCompression", tableOptions.enable_index_compression));
-
   std::optional<std::string> filterPolicyOpt;
   NAPI_STATUS_RETURN(GetProperty(env, options, "filterPolicy", filterPolicyOpt));
   if (filterPolicyOpt) {
@@ -925,11 +922,20 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
         rocksdb::FilterPolicy::CreateFromString(configOptions, *filterPolicyOpt, &tableOptions.filter_policy));
   }
 
+  tableOptions.block_size = 4 * 1024;
   NAPI_STATUS_RETURN(GetProperty(env, options, "blockSize", tableOptions.block_size));
 
+  tableOptions.block_restart_interval = 16;
   NAPI_STATUS_RETURN(GetProperty(env, options, "blockRestartInterval", tableOptions.block_restart_interval));
 
-  tableOptions.checksum = rocksdb::kXXH3;
+  tableOptions.block_align = false;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "blockAlign", tableOptions.block_align));
+
+  tableOptions.cache_index_and_filter_blocks = true; // false
+  NAPI_STATUS_RETURN(GetProperty(env, options, "cacheIndexAndFilterBlocks", tableOptions.cache_index_and_filter_blocks));
+
+  tableOptions.cache_index_and_filter_blocks_with_high_priority = true;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "cacheIndexAndFilterBlocksWithHighPriority", tableOptions.cache_index_and_filter_blocks_with_high_priority));
 
   tableOptions.decouple_partitioned_filters = true;
   NAPI_STATUS_RETURN(GetProperty(env, options, "decouplePartitionedFilters", tableOptions.block_restart_interval));
@@ -937,12 +943,12 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
   tableOptions.optimize_filters_for_memory = true;
   NAPI_STATUS_RETURN(GetProperty(env, options, "optimizeFiltersForMemory", tableOptions.optimize_filters_for_memory));
 
-  tableOptions.enable_index_compression = false;
-  NAPI_STATUS_RETURN(GetProperty(env, options, "enableIndexCompression", tableOptions.enable_index_compression));
-
   tableOptions.max_auto_readahead_size = 256 * 1024;
   NAPI_STATUS_RETURN(GetProperty(env, options, "maxAutoReadaheadSize", tableOptions.max_auto_readahead_size));
 
+  tableOptions.num_file_reads_for_auto_readahead = 2;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "numFileReadsForAutoReadahead", tableOptions.num_file_reads_for_auto_readahead));
+
   columnOptions.table_factory.reset(rocksdb::NewBlockBasedTableFactory(tableOptions));
 
   return napi_ok;
@@ -995,9 +1001,7 @@ NAPI_METHOD(db_open) {
     NAPI_STATUS_THROWS(GetProperty(env, options, "walSizeLimit", walSizeLimit));
     dbOptions.WAL_size_limit_MB = walSizeLimit / 1e6;
 
-    uint32_t maxTotalWalSize = 0;
-    NAPI_STATUS_THROWS(GetProperty(env, options, "walTotalSizeLimit", walSizeLimit));
-    dbOptions.max_total_wal_size = maxTotalWalSize / 1e6;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "maxTotalWalSize", dbOptions.max_total_wal_size));
 
     bool walCompression = true;
     NAPI_STATUS_THROWS(GetProperty(env, options, "walCompression", walCompression));
@@ -1019,9 +1023,6 @@ NAPI_METHOD(db_open) {
     dbOptions.advise_random_on_open = true;
     NAPI_STATUS_THROWS(GetProperty(env, options, "adviseRandomOnOpen", dbOptions.advise_random_on_open));
 
-    dbOptions.optimize_filters_for_hits = false;
-    NAPI_STATUS_THROWS(GetProperty(env, options, "optimizeFiltersForHits", dbOptions.optimize_filters_for_hits));
-
     dbOptions.bytes_per_sync = 1024 * 1024;
     NAPI_STATUS_THROWS(GetProperty(env, options, "bytesPerSync", dbOptions.bytes_per_sync));
 
@@ -1034,7 +1035,7 @@ NAPI_METHOD(db_open) {
     dbOptions.create_if_missing = false;
     NAPI_STATUS_THROWS(GetProperty(env, options, "createIfMissing", dbOptions.create_if_missing));
 
-    dbOptions.enable_pipelined_write = false;
+    dbOptions.error_if_exists = false;
     NAPI_STATUS_THROWS(GetProperty(env, options, "errorIfExists", dbOptions.error_if_exists));
 
     dbOptions.enable_pipelined_write = true;
@@ -1043,6 +1044,9 @@ NAPI_METHOD(db_open) {
     dbOptions.daily_offpeak_time_utc = "";
     NAPI_STATUS_THROWS(GetProperty(env, options, "dailyOffpeakTime",  dbOptions.daily_offpeak_time_utc));
 
+    dbOptions.unordered_write = false;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "unorderedWrite",  dbOptions.unordered_write));
+
     // TODO (feat): dbOptions.listeners
 
     std::string infoLogLevel;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "13.0.0",
+  "version": "13.0.2",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",