@nxtedition/rocksdb 12.2.12 → 13.0.1

package/binding.cc

@@ -885,6 +885,10 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
     }
   }
 
+  columnOptions.optimize_filters_for_hits = false;
+  NAPI_STATUS_THROWS(GetProperty(env, options, "optimizeFiltersForHits", columnOptions.optimize_filters_for_hits));
+
+
   uint32_t cacheSize = 8 << 20;
   NAPI_STATUS_RETURN(GetProperty(env, options, "cacheSize", cacheSize));
 
@@ -892,11 +896,8 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
 
   if (cacheSize) {
     tableOptions.block_cache = rocksdb::HyperClockCacheOptions(cacheSize, 0).MakeSharedCache();
-    NAPI_STATUS_RETURN(
-        GetProperty(env, options, "cacheIndexAndFilterBlocks", tableOptions.cache_index_and_filter_blocks));
   } else {
     tableOptions.no_block_cache = true;
-    tableOptions.cache_index_and_filter_blocks = false;
   }
 
   std::string optimize = "";
@@ -922,11 +923,20 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
         rocksdb::FilterPolicy::CreateFromString(configOptions, *filterPolicyOpt, &tableOptions.filter_policy));
   }
 
+  tableOptions.block_size = 4 * 1024;
   NAPI_STATUS_RETURN(GetProperty(env, options, "blockSize", tableOptions.block_size));
 
+  tableOptions.block_restart_interval = 16;
   NAPI_STATUS_RETURN(GetProperty(env, options, "blockRestartInterval", tableOptions.block_restart_interval));
 
-  tableOptions.checksum = rocksdb::kXXH3;
+  tableOptions.block_align = false;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "blockAlign", tableOptions.block_align));
+
+  tableOptions.cache_index_and_filter_blocks = true; // false
+  NAPI_STATUS_RETURN(GetProperty(env, options, "cacheIndexAndFilterBlocks", tableOptions.cache_index_and_filter_blocks));
+
+  tableOptions.cache_index_and_filter_blocks_with_high_priority = true;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "cacheIndexAndFilterBlocksWithHighPriority", tableOptions.cache_index_and_filter_blocks_with_high_priority));
 
   tableOptions.decouple_partitioned_filters = true;
   NAPI_STATUS_RETURN(GetProperty(env, options, "decouplePartitionedFilters", tableOptions.block_restart_interval));
@@ -934,6 +944,13 @@ napi_status InitOptions(napi_env env, T& columnOptions, const U& options) {
   tableOptions.optimize_filters_for_memory = true;
   NAPI_STATUS_RETURN(GetProperty(env, options, "optimizeFiltersForMemory", tableOptions.optimize_filters_for_memory));
 
+
+  tableOptions.max_auto_readahead_size = 256 * 1024;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "maxAutoReadaheadSize", tableOptions.max_auto_readahead_size));
+
+  tableOptions.num_file_reads_for_auto_readahead = 2;
+  NAPI_STATUS_RETURN(GetProperty(env, options, "numFileReadsForAutoReadahead", tableOptions.num_file_reads_for_auto_readahead));
+
   columnOptions.table_factory.reset(rocksdb::NewBlockBasedTableFactory(tableOptions));
 
   return napi_ok;
@@ -986,9 +1003,7 @@ NAPI_METHOD(db_open) {
     NAPI_STATUS_THROWS(GetProperty(env, options, "walSizeLimit", walSizeLimit));
     dbOptions.WAL_size_limit_MB = walSizeLimit / 1e6;
 
-    uint32_t maxTotalWalSize = 0;
-    NAPI_STATUS_THROWS(GetProperty(env, options, "walTotalSizeLimit", walSizeLimit));
-    dbOptions.max_total_wal_size = maxTotalWalSize / 1e6;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "maxTotalWalSize", dbOptions.max_total_wal_size));
 
     bool walCompression = true;
     NAPI_STATUS_THROWS(GetProperty(env, options, "walCompression", walCompression));
@@ -996,15 +1011,44 @@ NAPI_METHOD(db_open) {
         walCompression ? rocksdb::CompressionType::kZSTD : rocksdb::CompressionType::kNoCompression;
 
     dbOptions.avoid_unnecessary_blocking_io = true;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "avoidUnnecessaryBlockingIO", dbOptions.avoid_unnecessary_blocking_io));
+
     dbOptions.write_dbid_to_manifest = true;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "writeDbIdToManifest", dbOptions.write_dbid_to_manifest));
+
     dbOptions.create_missing_column_families = true;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "createMissingColumnFamilies", dbOptions.create_missing_column_families));
+
     dbOptions.fail_if_options_file_error = true;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "failIfOptionsFileError", dbOptions.fail_if_options_file_error));
+
+    dbOptions.advise_random_on_open = true;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "adviseRandomOnOpen", dbOptions.advise_random_on_open));
+
+    dbOptions.bytes_per_sync = 1024 * 1024;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "bytesPerSync", dbOptions.bytes_per_sync));
+
+    dbOptions.wal_bytes_per_sync = 1024 * 1024;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "walBytesPerSync", dbOptions.wal_bytes_per_sync));
+
+    dbOptions.strict_bytes_per_sync = true;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "strictBytesPerSync", dbOptions.strict_bytes_per_sync));
 
+    dbOptions.create_if_missing = false;
     NAPI_STATUS_THROWS(GetProperty(env, options, "createIfMissing", dbOptions.create_if_missing));
+
+    dbOptions.error_if_exists = false;
     NAPI_STATUS_THROWS(GetProperty(env, options, "errorIfExists", dbOptions.error_if_exists));
+
+    dbOptions.enable_pipelined_write = true;
     NAPI_STATUS_THROWS(GetProperty(env, options, "pipelinedWrite", dbOptions.enable_pipelined_write));
+
+    dbOptions.daily_offpeak_time_utc = "";
     NAPI_STATUS_THROWS(GetProperty(env, options, "dailyOffpeakTime",  dbOptions.daily_offpeak_time_utc));
 
+    dbOptions.unordered_write = false;
+    NAPI_STATUS_THROWS(GetProperty(env, options, "unorderedWrite",  dbOptions.unordered_write));
+
     // TODO (feat): dbOptions.listeners
 
     std::string infoLogLevel;

package/deps/rocksdb/rocksdb.gyp

@@ -93,10 +93,10 @@
               "USE_COROUTINES=1",
               "HAVE_UINT128_EXTENSION=1",
               "HAVE_ALIGNED_NEW=1",
-              # "ROCKSDB_JEMALLOC=1",
+              "ROCKSDB_JEMALLOC=1",
+              "JEMALLOC_NO_DEMANGLE=1"
               # "HAVE_FULLFSYNC=1",
               # "NUMA=1",
-              # "JEMALLOC_NO_DEMANGLE=1",
             ],
             "direct_dependent_settings": {
               "libraries": [
@@ -108,7 +108,7 @@
                 "/usr/lib/x86_64-linux-gnu/libiberty.a",
                 "/usr/lib/x86_64-linux-gnu/libunwind.a",
                 "/usr/lib/x86_64-linux-gnu/libgflags.a",
-                # "/usr/lib/x86_64-linux-gnu/libjemalloc.a"
+                "/usr/lib/x86_64-linux-gnu/libjemalloc.a"
               ],
             },
             "include_dirs": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "12.2.12",
+  "version": "13.0.1",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",