@nxtedition/rocksdb 10.0.9 → 10.0.11

package/binding.cc

@@ -323,7 +323,7 @@ struct BaseIterator : public Closable {
 
   virtual ~BaseIterator() { assert(!iterator_); }
 
-  bool DidSeek() const { return iterator_ != nullptr && !target_; }
+  bool DidSeek() const { return iterator_ != nullptr; }
 
   void SeekToRange() {
     if (!iterator_) {
@@ -338,19 +338,23 @@ struct BaseIterator : public Closable {
   }
 
   void Seek(const rocksdb::Slice& target) {
-		if ((upper_bound_ && target.compare(*upper_bound_) >= 0) || (lower_bound_ && target.compare(*lower_bound_) < 0)) {
-			// TODO (fix): Why is this required? Seek should handle it?
-			// https://github.com/facebook/rocksdb/issues/9904
-			iterator_->SeekToLast();
-			if (iterator_->Valid()) {
-				iterator_->Next();
-			}
-		} else if (reverse_) {
-			iterator_->SeekForPrev(target);
-		} else {
-			iterator_->Seek(target);
-		}
-	}
+    if (!iterator_) {
+      Init();
+    }
+
+    if ((upper_bound_ && target.compare(*upper_bound_) >= 0) || (lower_bound_ && target.compare(*lower_bound_) < 0)) {
+      // TODO (fix): Why is this required? Seek should handle it?
+      // https://github.com/facebook/rocksdb/issues/9904
+      iterator_->SeekToLast();
+      if (iterator_->Valid()) {
+        iterator_->Next();
+      }
+    } else if (reverse_) {
+      iterator_->SeekForPrev(target);
+    } else {
+      iterator_->Seek(target);
+    }
+  }
 
   rocksdb::Status Close() override {
     snapshot_.reset();
@@ -418,7 +422,6 @@ struct BaseIterator : public Closable {
   std::optional<rocksdb::PinnableSlice> lower_bound_;
   std::optional<rocksdb::PinnableSlice> upper_bound_;
   std::unique_ptr<rocksdb::Iterator> iterator_;
-  std::optional<std::string> target_;
   const bool reverse_;
   const int limit_;
   const bool fillCache_;
@@ -1271,8 +1274,18 @@ NAPI_METHOD(iterator_seek) {
   NapiSlice target;
   NAPI_STATUS_THROWS(GetValue(env, argv[1], target));
 
-  iterator->first_ = true;
-  iterator->Seek(target);
+  struct State {};
+
+  runAsync<State>(
+      std::string("leveldown.iterator.seek"), env, callback,
+      [=](auto& state) {
+				iterator->first_ = true;
+				iterator->Seek(target);
+        return iterator->Status();
+      },
+      [=](auto& state, auto env, auto& argv) {
+        return napi_ok;
+      });
 
   return 0;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "10.0.9",
+  "version": "10.0.11",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",