@nxtedition/rocksdb 10.0.9 → 10.0.10

package/binding.cc

@@ -330,7 +330,23 @@ struct BaseIterator : public Closable {
       Init();
     }
 
-    if (reverse_) {
+    const auto target = std::move(target_);
+
+    if (target) {
+      if ((upper_bound_ && target->compare(*upper_bound_) >= 0) ||
+          (lower_bound_ && target->compare(*lower_bound_) < 0)) {
+        // TODO (fix): Why is this required? Seek should handle it?
+        // https://github.com/facebook/rocksdb/issues/9904
+        iterator_->SeekToLast();
+        if (iterator_->Valid()) {
+          iterator_->Next();
+        }
+      } else if (reverse_) {
+        iterator_->SeekForPrev(*target);
+      } else {
+        iterator_->Seek(*target);
+      }
+    } else if (reverse_) {
       iterator_->SeekToLast();
     } else {
       iterator_->SeekToFirst();
@@ -338,19 +354,9 @@ struct BaseIterator : public Closable {
   }
 
   void Seek(const rocksdb::Slice& target) {
-		if ((upper_bound_ && target.compare(*upper_bound_) >= 0) || (lower_bound_ && target.compare(*lower_bound_) < 0)) {
-			// TODO (fix): Why is this required? Seek should handle it?
-			// https://github.com/facebook/rocksdb/issues/9904
-			iterator_->SeekToLast();
-			if (iterator_->Valid()) {
-				iterator_->Next();
-			}
-		} else if (reverse_) {
-			iterator_->SeekForPrev(target);
-		} else {
-			iterator_->Seek(target);
-		}
-	}
+    target_ = rocksdb::PinnableSlice();
+    target_->PinSelf(target);
+  }
 
   rocksdb::Status Close() override {
     snapshot_.reset();
@@ -417,8 +423,8 @@ struct BaseIterator : public Closable {
   int count_ = 0;
   std::optional<rocksdb::PinnableSlice> lower_bound_;
   std::optional<rocksdb::PinnableSlice> upper_bound_;
+  std::optional<rocksdb::PinnableSlice> target_;
   std::unique_ptr<rocksdb::Iterator> iterator_;
-  std::optional<std::string> target_;
   const bool reverse_;
   const int limit_;
   const bool fillCache_;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/rocksdb",
-  "version": "10.0.9",
+  "version": "10.0.10",
   "description": "A low-level Node.js RocksDB binding",
   "license": "MIT",
   "main": "index.js",