@nxtedition/rocksdb 10.0.17 → 10.0.18

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (3) hide show
  1. package/package.json +1 -1
  2. package/prebuilds/darwin-arm64/@nxtedition+rocksdb.node +0 -0
  3. package/util.h +3 -5
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@nxtedition/rocksdb",
3
- "version": "10.0.17",
3
+ "version": "10.0.18",
4
4
  "description": "A low-level Node.js RocksDB binding",
5
5
  "license": "MIT",
6
6
  "main": "index.js",
package/util.h CHANGED
@@ -245,11 +245,9 @@ napi_status Convert(napi_env env, rocksdb::PinnableSlice* s, Encoding encoding,
245
245
  if (!s || !s->IsPinned()) {
246
246
  return napi_get_null(env, &result);
247
247
  } else if (encoding == Encoding::Buffer) {
248
- // TODO (fix): Is this leaking?
249
- // auto ptr = new rocksdb::PinnableSlice(std::move(*s));
250
- // return napi_create_external_buffer(env, ptr->size(), const_cast<char*>(ptr->data()),
251
- // Finalize<rocksdb::PinnableSlice>, ptr, &result);
252
- return napi_create_buffer_copy(env, s->size(), s->data(), nullptr, &result);
248
+ auto ptr = new rocksdb::PinnableSlice(std::move(*s));
249
+ return napi_create_external_buffer(env, ptr->size(), const_cast<char*>(ptr->data()),
250
+ Finalize<rocksdb::PinnableSlice>, ptr, &result);
253
251
  } else if (encoding == Encoding::String) {
254
252
  return napi_create_string_utf8(env, s->data(), s->size(), &result);
255
253
  } else {