@nxtedition/nxt-undici 7.3.11 → 7.3.13

package/lib/interceptor/cache.js

@@ -113,7 +113,7 @@ class CacheHandler extends DecoratorHandler {
 
     const ttl = cacheControlDirectives.immutable
       ? 31556952
-      : Number(cacheControlDirectives['s-max-age'] ?? cacheControlDirectives['max-age'])
+      : Number(cacheControlDirectives['s-maxage'] ?? cacheControlDirectives['max-age'])
     if (!ttl || !Number.isFinite(ttl) || ttl <= 0) {
       return super.onHeaders(statusCode, headers, resume)
     }
@@ -186,7 +186,11 @@ export default () => (dispatch) => (opts, handler) => {
     return dispatch(opts, handler)
   }
 
-  const cacheControlDirectives = parseCacheControl(opts?.headers['cache-control']) ?? {}
+  const rawCacheControl = opts?.headers?.['cache-control']
+  const cacheControlDirectives = parseCacheControl(rawCacheControl) ?? {}
+  // cache-control-parser does not recognise 'only-if-cached', so check the raw string.
+  const onlyIfCached =
+    typeof rawCacheControl === 'string' && rawCacheControl.includes('only-if-cached')
 
   if (cacheControlDirectives['no-transform']) {
     // Do nothing. We don't transform requests...
@@ -213,19 +217,20 @@ export default () => (dispatch) => (opts, handler) => {
   } catch (err) {
     if (err.message === 'database is locked') {
       // Database is busy. We don't bother trying again...
-      opts.logger?.debug({ err }, 'failed to set cache entry')
+      opts.logger?.debug({ err }, 'failed to get cache entry')
     } else {
-      opts.logger?.error({ err }, 'failed to set cache entry')
+      opts.logger?.error({ err }, 'failed to get cache entry')
     }
   }
 
-  if (!entry && !cacheControlDirectives['only-if-cached']) {
+  if (!entry && !onlyIfCached) {
     return dispatch(
       opts,
       cacheControlDirectives['no-store']
         ? handler
         : new CacheHandler(undici.util.cache.makeCacheKey(opts), {
             maxEntrySize: opts.cache.maxEntrySize,
+            maxEntryTTL: opts.cache.maxEntryTTL,
             store,
             logger: opts.logger,
             handler,

package/lib/interceptor/dns.js

@@ -119,7 +119,7 @@ export default () => (dispatch) => {
         )
 
         for (let i = 0; i < records.length; i++) {
-          if (records[i].expires >= now) {
+          if (records[i].expires >= now && records[i].timeout < now) {
             record = records[i]
             break
           }

package/lib/interceptor/log.js

@@ -89,7 +89,7 @@ class Handler extends DecoratorHandler {
     return super.onData(chunk)
   }
 
-  onComplete() {
+  onComplete(trailers) {
     this.#timing.end = performance.now() - this.#created
 
     const data = {
@@ -117,7 +117,7 @@ class Handler extends DecoratorHandler {
 
     this.onDone()
 
-    super.onComplete()
+    super.onComplete(trailers)
   }
 
   onError(err) {

package/lib/interceptor/lookup.js

@@ -5,23 +5,27 @@ export default () => (dispatch) => async (opts, handler) => {
     return dispatch(opts, handler)
   }
 
-  const origin = await new Promise((resolve, reject) => {
-    const thenable = lookup(opts.origin, { signal: opts.signal ?? undefined }, (err, val) => {
-      if (err) {
-        reject(err)
-      } else {
-        resolve(val)
+  try {
+    const origin = await new Promise((resolve, reject) => {
+      const thenable = lookup(opts.origin, { signal: opts.signal ?? undefined }, (err, val) => {
+        if (err) {
+          reject(err)
+        } else {
+          resolve(val)
+        }
+      })
+
+      if (thenable != null) {
+        Promise.resolve(thenable).then(resolve, reject)
       }
     })
 
-    if (thenable != null) {
-      Promise.resolve(thenable).then(resolve, reject)
+    if (!origin) {
+      throw new Error('invalid origin: ' + origin)
     }
-  })
 
-  if (!origin) {
-    throw new Error('invalid origin: ' + origin)
+    return dispatch({ ...opts, origin }, handler)
+  } catch (err) {
+    handler.onError(err)
   }
-
-  return dispatch({ ...opts, origin }, handler)
 }

package/lib/interceptor/redirect.js

@@ -69,6 +69,7 @@ class Handler extends DecoratorHandler {
       if (!this.#opts.follow(this.#location, this.#count, this.#opts)) {
         assert(!this.#headersSent)
         this.#headersSent = true
+        this.#location = null
         return super.onHeaders(statusCode, headers, resume)
       }
     } else {
@@ -144,7 +145,10 @@ class Handler extends DecoratorHandler {
       this.#location = null
 
       try {
-        this.#dispatch(this.#opts, this)?.catch((err) => this.onError(err))
+        const result = this.#dispatch(this.#opts, this)
+        if (result != null && typeof result.catch === 'function') {
+          result.catch((err) => this.onError(err))
+        }
       } catch (err) {
         this.onError(err)
       }

package/lib/interceptor/response-verify.js

@@ -41,7 +41,7 @@ class Handler extends DecoratorHandler {
     return super.onData(chunk)
   }
 
-  onComplete() {
+  onComplete(trailers) {
     const contentMD5 = this.#hasher?.digest('base64')
 
     if (this.#contentLength != null && this.#pos !== Number(this.#contentLength)) {
@@ -59,7 +59,7 @@ class Handler extends DecoratorHandler {
         }),
       )
     } else {
-      super.onComplete()
+      super.onComplete(trailers)
     }
   }
 }

package/lib/sqlite-cache-store.js

@@ -268,9 +268,9 @@ export class SqliteCacheStore {
     try {
       const startTime = performance.now()
       for (let retryCount = 0; true; retryCount++) {
-        this.#db.exec('BEGIN')
         let n = 0
         try {
+          this.#db.exec('BEGIN')
           while (n < this.#insertBatch.length) {
             const {
               url,
@@ -314,11 +314,22 @@ export class SqliteCacheStore {
         } catch (err) {
           // ROLLBACK is required: a failed statement leaves the connection with
           // an open transaction; without it the next BEGIN would throw.
-          this.#db.exec('ROLLBACK')
+          // On SQLITE_FULL, SQLite automatically rolls back the transaction, so
+          // the explicit ROLLBACK may fail with "no transaction is active" — ignore it.
+          try {
+            this.#db.exec('ROLLBACK')
+          } catch {
+            // already rolled back automatically
+            // TODO (fix): Check that the error is what we expect (something like "no transaction is active")...
+          }
+
           if (err?.errcode === 13 /* SQLITE_FULL */ && retryCount < 3) {
             this.#evictQuery.run(256)
           } else {
-            this.#insertBatch.splice(0, n)
+            // If BEGIN failed (n=0) clear the whole batch to avoid an infinite
+            // retry loop. If an INSERT/COMMIT failed, only clear the entries
+            // that were part of the attempted transaction.
+            this.#insertBatch.splice(0, n || this.#insertBatch.length)
             throw err
           }
         }

package/lib/utils.js

@@ -267,7 +267,6 @@ export class DecoratorHandler {
   onError(err) {
     if (!this.#errored && !this.#completed) {
       this.#errored = true
-      assert(!this.#completed)
       return this.#handler.onError?.(err)
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "7.3.11",
+  "version": "7.3.13",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",