@nxtedition/nxt-undici 7.3.11 → 7.3.12

package/lib/sqlite-cache-store.js

@@ -268,9 +268,9 @@ export class SqliteCacheStore {
     try {
       const startTime = performance.now()
       for (let retryCount = 0; true; retryCount++) {
-        this.#db.exec('BEGIN')
         let n = 0
         try {
+          this.#db.exec('BEGIN')
           while (n < this.#insertBatch.length) {
             const {
               url,
@@ -314,11 +314,22 @@ export class SqliteCacheStore {
         } catch (err) {
           // ROLLBACK is required: a failed statement leaves the connection with
           // an open transaction; without it the next BEGIN would throw.
-          this.#db.exec('ROLLBACK')
+          // On SQLITE_FULL, SQLite automatically rolls back the transaction, so
+          // the explicit ROLLBACK may fail with "no transaction is active" — ignore it.
+          try {
+            this.#db.exec('ROLLBACK')
+          } catch {
+            // already rolled back automatically
+            // TODO (fix): Check that the error is what we expect (something like "no transaction is active")...
+          }
+
           if (err?.errcode === 13 /* SQLITE_FULL */ && retryCount < 3) {
             this.#evictQuery.run(256)
           } else {
-            this.#insertBatch.splice(0, n)
+            // If BEGIN failed (n=0) clear the whole batch to avoid an infinite
+            // retry loop. If an INSERT/COMMIT failed, only clear the entries
+            // that were part of the attempted transaction.
+            this.#insertBatch.splice(0, n || this.#insertBatch.length)
             throw err
           }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "7.3.11",
+  "version": "7.3.12",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",