@nxtedition/nxt-undici 6.0.11 → 6.0.13

package/lib/interceptor/dns.js

@@ -1,9 +1,7 @@
 import net from 'node:net'
-import { resolve4 } from 'node:dns/promises'
+import { resolve4 } from 'node:dns'
 import { DecoratorHandler, getFastNow } from '../utils.js'
 
-function noop() {}
-
 const MAX_TTL = 10e3
 
 class Handler extends DecoratorHandler {
@@ -42,21 +40,32 @@ export default () => (dispatch) => {
   function resolve(hostname) {
     let promise = promises.get(hostname)
     if (!promise) {
-      promise = resolve4(hostname, { ttl: true })
-        .then((records) => {
-          const now = getFastNow()
-          const ret = records.map(({ address, ttl }) => ({
-            address,
-            expires: now + Math.min(MAX_TTL, 1e3 * ttl),
-            pending: 0,
-            errored: 0,
-          }))
+      promise = new Promise((resolve) =>
+        resolve4(hostname, { ttl: true }, (err, records) => {
+          let ret
+
+          if (err) {
+            ret = { error: err }
+          } else {
+            const now = getFastNow()
+            ret = {
+              value: records.map(({ address, ttl }) => ({
+                address,
+                expires: now + Math.min(MAX_TTL, 1e3 * ttl),
+                pending: 0,
+                errored: 0,
+                counter: 0,
+              })),
+            }
+          }
+
           cache.set(hostname, ret)
-          return ret
-        })
-        .finally(() => {
+
           promises.delete(hostname)
-        })
+
+          resolve(ret)
+        }),
+      )
       promises.set(hostname, promise)
     }
     return promise
@@ -73,61 +82,50 @@ export default () => (dispatch) => {
       return dispatch(opts, handler)
     }
 
-    const { host, hostname } = origin
-
-    const now = getFastNow()
-
-    let records = cache.get(hostname)
+    try {
+      const { host, hostname } = origin
 
-    if (records == null || records.every((x) => x.expires < now)) {
-      records = await resolve(hostname)
-    } else if (records.some((x) => x.expires < now + 1e3)) {
-      resolve(hostname).catch(noop)
-    }
+      const now = getFastNow()
 
-    records.sort((a, b) => {
-      if (a.errored !== b.errored) {
-        return a.errored - b.errored
-      }
+      let records = cache.get(hostname)?.value
 
-      if (a.pending !== b.pending) {
-        return a.pending - b.pending
+      if (records == null || records.every((x) => x.expires < now)) {
+        records = await resolve(hostname)
+      } else if (records.some((x) => x.expires < now + 1e3)) {
+        resolve(hostname)
       }
 
-      return 0
-    })
+      records.sort(
+        (a, b) => a.errored - b.errored || a.pending - b.pending || a.counter - b.counter,
+      )
 
-    const record = records.find((x) => x.expires >= now)
+      const record = records.find((x) => x.expires >= now)
 
-    if (!record) {
-      throw Object.assign(new Error(`No available DNS records found for ${hostname}`), {
-        code: 'ENOTFOUND',
-      })
-    }
+      if (!record) {
+        throw Object.assign(new Error(`No available DNS records found for ${hostname}`), {
+          code: 'ENOTFOUND',
+        })
+      }
 
-    origin.hostname = record.address
+      origin.hostname = record.address
 
-    record.pending++
-    try {
-      return dispatch(
+      dispatch(
         { ...opts, origin, headers: { ...opts.headers, host } },
         new Handler(handler, (err, statusCode) => {
           record.pending--
 
-          if (err == null) {
-            if (statusCode != null && statusCode >= 500) {
-              record.errored++
-            } else {
-              record.errored = 0
-            }
-          } else if (err.name !== 'AbortError') {
+          if (statusCode != null && statusCode >= 500) {
+            record.errored++
+          } else if (err != null && err.name !== 'AbortError') {
             record.expires = 0
           }
         }),
       )
+
+      record.counter++
+      record.pending++
     } catch (err) {
-      record.pending--
-      throw err
+      handler.onError(err)
     }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "6.0.11",
+  "version": "6.0.13",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",