@nxtedition/nxt-undici 2.0.8 → 2.0.10

package/lib/interceptor/redirect.js

@@ -4,34 +4,16 @@ import { findHeader, isDisturbed, parseURL } from '../utils.js'
 const redirectableStatusCodes = [300, 301, 302, 303, 307, 308]
 
 class Handler {
-  constructor(opts, { dispatch, handler }) {
+  constructor(opts, { dispatch, handler, count = 0 }) {
     this.dispatch = dispatch
     this.handler = handler
     this.opts = opts
-    this.abort = null
-    this.aborted = false
-    this.reason = null
-    this.maxCount = Number.isFinite(opts.follow) ? opts.follow : opts.follow?.count ?? 0
-
-    this.count = 0
-    this.location = null
-
-    this.handler.onConnect((reason) => {
-      this.aborted = true
-      if (this.abort) {
-        this.abort(reason)
-      } else {
-        this.reason = reason
-      }
-    })
+    this.redirectOpts = null
+    this.count = count
   }
 
   onConnect(abort) {
-    if (this.aborted) {
-      abort(this.reason)
-    } else {
-      this.abort = abort
-    }
+    return this.handler.onConnect(abort)
   }
 
   onUpgrade(statusCode, headers, socket) {
@@ -51,60 +33,65 @@ class Handler {
       return this.handler.onHeaders(statusCode, headers, resume, statusText)
     }
 
-    if (isDisturbed(this.opts.body)) {
-      throw new Error(`Disturbed request cannot be redirected.`)
-    }
+    const location = findHeader(headers, 'location')
 
-    this.location = findHeader(headers, 'location')
-
-    if (!this.location) {
+    if (!location) {
+      // TODO (perf): Consume body?
       throw new Error(`Missing redirection location .`)
     }
 
     this.count += 1
 
     if (typeof this.opts.follow === 'function') {
-      if (!this.opts.follow(this.location, this.count)) {
+      if (!this.opts.follow(location, this.count)) {
         return this.handler.onHeaders(statusCode, headers, resume, statusText)
       }
     } else {
-      if (this.count >= this.maxCount) {
-        throw new Error(`Max redirections reached: ${this.maxCount}.`)
+      const maxCount = Number.isFinite(this.opts.follow)
+        ? this.opts.follow
+        : Number.isFinite(this.opts.follow?.count)
+          ? this.opts.follow?.count
+          : 0
+
+      if (this.count >= maxCount) {
+        // TODO (perf): Consume body?
+        throw new Error(`Max redirections reached: ${maxCount}.`)
       }
     }
 
+    if (isDisturbed(this.opts.body)) {
+      // TODO (perf): Consume body?
+      throw new Error(`Disturbed request cannot be redirected.`)
+    }
+
     const { origin, pathname, search } = parseURL(
-      new URL(this.location, this.opts.origin && new URL(this.opts.path, this.opts.origin)),
+      new URL(location, this.opts.origin && new URL(this.opts.path, this.opts.origin)),
     )
     const path = search ? `${pathname}${search}` : pathname
 
     // Remove headers referring to the original URL.
     // By default it is Host only, unless it's a 303 (see below), which removes also all Content-* headers.
     // https://tools.ietf.org/html/rfc7231#section-6.4
-    this.opts = {
+    this.redirectOpts = {
       ...this.opts,
       headers: cleanRequestHeaders(
         this.opts.headers,
         statusCode === 303,
         this.opts.origin !== origin,
       ),
-      follow: {
-        ...this.opts.follow,
-        count: this.maxCount - 1,
-      },
       path,
       origin,
     }
 
     // https://tools.ietf.org/html/rfc7231#section-6.4.4
     // In case of HTTP 303, always replace method to be either HEAD or GET
-    if (statusCode === 303 && this.opts.method !== 'HEAD') {
-      this.opts = { ...this.opts, method: 'GET', body: null }
+    if (statusCode === 303 && this.redirectOpts.method !== 'HEAD') {
+      this.redirectOpts = { ...this.redirectOpts, method: 'GET', body: null }
     }
   }
 
   onData(chunk) {
-    if (this.location) {
+    if (this.redirectOpts) {
       /*
         https://tools.ietf.org/html/rfc7231#section-6.4
 
@@ -128,7 +115,7 @@ class Handler {
   }
 
   onComplete(trailers) {
-    if (this.location) {
+    if (this.redirectOpts) {
       /*
         https://tools.ietf.org/html/rfc7231#section-6.4
 
@@ -138,8 +125,12 @@ class Handler {
         See comment on onData method above for more detailed informations.
       */
       this.dispatch(
-        this.opts,
-        new Handler(this.opts, { handler: this.handler, dispatch: this.dispatch }),
+        this.redirectOpts,
+        new Handler(this.redirectOpts, {
+          handler: this.handler,
+          dispatch: this.dispatch,
+          count: this.count,
+        }),
       )
     } else {
       return this.handler.onComplete(trailers)
@@ -181,5 +172,5 @@ function cleanRequestHeaders(headers, removeContent, unknownOrigin) {
 
 export default (dispatch) => (opts, handler) =>
   opts.follow != null
-    ? dispatch(opts, new Handler(opts, { handler, dispatch }))
+    ? dispatch(opts, new Handler(opts, { handler, dispatch, count: 0 }))
     : dispatch(opts, handler)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "2.0.8",
+  "version": "2.0.10",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",