@nxtedition/nxt-undici 1.2.0 → 1.2.2

package/lib/index.js

@@ -127,7 +127,7 @@ class Readable extends stream.Readable {
 
 const dispatchers = {
   requestBody: require('./interceptor/request-body.js'),
-  dump: require('./interceptor/dump.js'),
+  abort: require('./interceptor/abort.js'),
   catch: require('./interceptor/catch.js'),
   responseContent: require('./interceptor/response-content.js'),
   requestContent: require('./interceptor/request-content.js'),
@@ -143,27 +143,40 @@ const dispatchers = {
 }
 
 async function request(url, opts) {
+  // TODO (fix): More argument validation...
+
   if (typeof url === 'string') {
     url = new URL(url)
   } else if (url instanceof URL) {
     // Do nothing...
   } else if (typeof url.origin === 'string' && typeof (url.path ?? url.pathname) === 'string') {
     // Do nothing...
-  } else {
-    throw new Error('missing url')
   }
 
   if (opts == null && typeof url === 'object' && url != null) {
     opts = url
   }
 
+  if (url) {
+    // Do nothing...
+  } else if (typeof opts.url === 'string') {
+    url = new URL(opts.url)
+  } else if (url.url instanceof URL) {
+    url = opts.url
+  } else if (typeof opts.origin === 'string' && typeof (opts.path ?? opts.pathname) === 'string') {
+    url = opts
+  } else {
+    throw new Error('missing url')
+  }
+
   const method = opts.method ?? (opts.body ? 'POST' : 'GET')
   const idempotent = opts.idempotent ?? (method === 'GET' || method === 'HEAD')
 
   let headers
   if (Array.isArray(opts.headers)) {
     headers = parseHeaders(opts.headers)
-  } else {
+  } else if (opts.headers != null) {
+    // TODO (fix): Object.values(opts.headers)?
     headers = opts.headers
   }
 
@@ -204,7 +217,7 @@ async function request(url, opts) {
     dispatch = (opts, handler) => dispatcher.dispatch(opts, handler)
     dispatch = dispatchers.catch(dispatch)
     dispatch = dispatchers.requestBody(dispatch)
-    dispatch = dispatchers.dump(dispatch)
+    dispatch = dispatchers.abort(dispatch)
     dispatch = dispatchers.requestId(dispatch)
     dispatch = dispatchers.log(dispatch)
     dispatch = dispatchers.responseRetry(dispatch)
@@ -235,7 +248,6 @@ async function request(url, opts) {
         headersTimeout: opts.headersTimeout,
         bodyTimeout: opts.bodyTimeout,
         idempotent,
-        dump: opts.dump ?? 'abort',
         signal: opts.signal,
         retry: opts.retry ?? 8,
         proxy: opts.proxy,

package/lib/interceptor/{dump.js → abort.js}

@@ -1,25 +1,17 @@
 const { AbortError } = require('../utils')
 
-// TODO (fix): Configurable timeout
-// TODO (fix): Dump?
-
 class Handler {
   constructor(opts, { handler }) {
     this.opts = opts
     this.handler = handler
     this.pos = 0
     this.reason = null
-    this.timeout = null
   }
 
   onConnect(abort) {
     this.abort = abort
     this.handler.onConnect((reason) => {
       this.reason = reason ?? new AbortError()
-      this.timeout = setTimeout(() => {
-        this.timeout = null
-        this.abort(this.reason)
-      }, this.opts.dump?.timeout ?? 10e3)
     })
   }
 
@@ -73,14 +65,8 @@ class Handler {
   }
 
   onFinally(err, rawTrailers) {
-    if (this.timeout) {
-      clearTimeout(this.timeout)
-      this.timeout = null
-    }
-
     return err == null ? this.handler.onComplete(rawTrailers) : this.handler.onError(err)
   }
 }
 
-module.exports = (dispatch) => (opts, handler) =>
-  opts.dump ? dispatch(opts, new Handler(opts, { handler })) : dispatch(opts, handler)
+module.exports = (dispatch) => (opts, handler) => dispatch(opts, new Handler(opts, { handler }))

package/lib/interceptor/log.js

@@ -42,7 +42,7 @@ class Handler {
     this.logger.debug(
       {
         ures: { statusCode, headers: parseHeaders(rawHeaders) },
-        elapsedTime: this.startTime - performance.now(),
+        elapsedTime: performance.now() - this.startTime,
       },
       'upstream request response',
     )
@@ -56,7 +56,7 @@ class Handler {
 
   onComplete(rawTrailers) {
     this.logger.debug(
-      { bytesRead: this.pos, elapsedTime: this.startTime - performance.now() },
+      { bytesRead: this.pos, elapsedTime: performance.now() - this.startTime },
       'upstream request completed',
     )
     return this.handler.onComplete(rawTrailers)
@@ -65,12 +65,12 @@ class Handler {
   onError(err) {
     if (this.aborted) {
       this.logger.debug(
-        { bytesRead: this.pos, elapsedTime: this.startTime - performance.now(), err },
+        { bytesRead: this.pos, elapsedTime: performance.now() - this.startTime, err },
         'upstream request aborted',
       )
     } else {
       this.logger.error(
-        { bytesRead: this.pos, elapsedTime: this.startTime - performance.now(), err },
+        { bytesRead: this.pos, elapsedTime: performance.now() - this.startTime, err },
         'upstream request failed',
       )
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",