@nxtedition/nxt-undici 1.0.2 → 1.0.3

package/lib/index.js

@@ -115,7 +115,7 @@ async function request(url, opts) {
   }
 
   headers = {
-    'request-id': `req-${genReqId()}`,
+    'request-id': genReqId(),
     'user-agent': opts.userAgent ?? globalThis.userAgent,
     ...headers,
   }

package/lib/interceptor/log.js

@@ -1,11 +1,23 @@
 const { parseHeaders } = require('../utils')
-const xuid = require('xuid')
 const { performance } = require('perf_hooks')
 
+// https://github.com/fastify/fastify/blob/main/lib/reqIdGenFactory.js
+// 2,147,483,647 (2^31 − 1) stands for max SMI value (an internal optimization of V8).
+// With this upper bound, if you'll be generating 1k ids/sec, you're going to hit it in ~25 days.
+// This is very likely to happen in real-world applications, hence the limit is enforced.
+// Growing beyond this value will make the id generation slower and cause a deopt.
+// In the worst cases, it will become a float, losing accuracy.
+const maxInt = 2147483647
+let nextReqId = Math.floor(Math.random() * maxInt)
+function genReqId() {
+  nextReqId = (nextReqId + 1) & maxInt
+  return `req-${nextReqId.toString(36)}`
+}
+
 class Handler {
   constructor(opts, { handler }) {
     this.handler = handler
-    this.opts = opts.id ? opts : { ...opts, id: xuid() }
+    this.opts = opts.id ? opts : { ...opts, id: genReqId() }
     this.abort = null
     this.aborted = false
     this.logger = opts.logger.child({ ureq: { id: opts.id } })

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",