@nxtedition/nxt-undici 1.0.0 → 1.0.2

package/lib/index.js

@@ -1,10 +1,22 @@
 const assert = require('assert')
 const createError = require('http-errors')
-const xuid = require('xuid')
 const undici = require('undici')
 const stream = require('stream')
 const { parseHeaders } = require('./utils')
 
+// https://github.com/fastify/fastify/blob/main/lib/reqIdGenFactory.js
+// 2,147,483,647 (2^31 − 1) stands for max SMI value (an internal optimization of V8).
+// With this upper bound, if you'll be generating 1k ids/sec, you're going to hit it in ~25 days.
+// This is very likely to happen in real-world applications, hence the limit is enforced.
+// Growing beyond this value will make the id generation slower and cause a deopt.
+// In the worst cases, it will become a float, losing accuracy.
+const maxInt = 2147483647
+let nextReqId = Math.floor(Math.random() * maxInt)
+function genReqId() {
+  nextReqId = (nextReqId + 1) & maxInt
+  return `req-${nextReqId.toString(36)}`
+}
+
 class Readable extends stream.Readable {
   constructor({ statusCode, statusMessage, headers, size, ...opts }) {
     super(opts)
@@ -102,6 +114,12 @@ async function request(url, opts) {
     headers = opts.headers
   }
 
+  headers = {
+    'request-id': `req-${genReqId()}`,
+    'user-agent': opts.userAgent ?? globalThis.userAgent,
+    ...headers,
+  }
+
   if (method === 'CONNECT') {
     throw new createError.MethodNotAllowed()
   }
@@ -117,11 +135,7 @@ async function request(url, opts) {
     url,
     method,
     body: opts.body,
-    headers: {
-      'request-id': xuid(),
-      'user-agent': opts.userAgent ?? globalThis.userAgent,
-      ...headers,
-    },
+    headers,
     origin: url.origin,
     path: url.path ? url.path : url.search ? `${url.pathname}${url.search ?? ''}` : url.pathname,
     reset: opts.reset ?? false,

package/lib/interceptor/response-body-retry.js

@@ -147,7 +147,7 @@ class Handler {
       },
     }
 
-    this.opts.loggerdebug('retrying response body')
+    this.opts.logger?.debug('retrying response body')
   }
 }
 

package/lib/interceptor/response-retry.js

@@ -79,7 +79,7 @@ class Handler {
         this.handler.onError(err)
       })
 
-    this.opts.loggerdebug('retrying response')
+    this.opts.logger?.debug('retrying response')
   }
 }
 

package/lib/interceptor/response-status-retry.js

@@ -93,7 +93,7 @@ class Handler {
       })
     this.retryPromise = null
 
-    this.opts.loggerdebug('retrying response status')
+    this.opts.logger?.debug('retrying response status')
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/nxt-undici",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "main": "lib/index.js",
@@ -11,7 +11,56 @@
     "cache-control-parser": "^2.0.4",
     "http-errors": "^2.0.0",
     "lru-cache": "^10.0.1",
-    "undici": "^5.26.4",
-    "xuid": "^4.1.2"
+    "undici": "^5.26.4"
+  },
+  "devDependencies": {
+    "@types/node": "^20.8.2",
+    "eslint": "^8.50.0",
+    "eslint-config-prettier": "^9.0.0",
+    "eslint-config-standard": "^17.0.0",
+    "husky": "^8.0.3",
+    "lint-staged": "^14.0.1",
+    "pinst": "^3.0.0",
+    "prettier": "^3.0.3",
+    "tap": "^18.4.2"
+  },
+  "scripts": {
+    "prepare": "husky install",
+    "prepublishOnly": "pinst --disable",
+    "postpublish": "pinst --enable",
+    "test": "tap test"
+  },
+  "lint-staged": {
+    "*.{js,jsx,md,ts}": [
+      "eslint",
+      "prettier --write"
+    ]
+  },
+  "prettier": {
+    "printWidth": 100,
+    "semi": false,
+    "singleQuote": true
+  },
+  "eslintConfig": {
+    "parserOptions": {
+      "ecmaFeatures": {
+        "ecmaVersion": 2020
+      }
+    },
+    "extends": [
+      "standard",
+      "prettier",
+      "prettier/prettier"
+    ],
+    "rules": {
+      "quotes": [
+        "error",
+        "single",
+        {
+          "avoidEscape": true,
+          "allowTemplateLiterals": true
+        }
+      ]
+    }
   }
 }