@nxtedition/lib 28.0.3 → 28.0.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/lib",
-  "version": "28.0.3",
+  "version": "28.0.5",
   "license": "UNLICENSED",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "type": "module",
@@ -92,5 +92,5 @@
     "pino": ">=7.0.0",
     "rxjs": "^7.0.0"
   },
-  "gitHead": "15f4fd00f86a558ae56672b1efa3e909b23feb3f"
+  "gitHead": "f778b4c525a240411f681137d8dd0fe19031c7b0"
 }

package/sequence.js

@@ -1,4 +1,5 @@
 import assert from 'node:assert'
+import util from 'node:util'
 
 export const ID_SEP = '~'
 
@@ -46,12 +47,12 @@ export class Sequence {
       return -1
     }
 
-    if (a && typeof a === 'string') {
-      a = new Sequence(a)
+    if (a === b) {
+      return 0
     }
 
-    if (typeof b === 'string') {
-      b = new Sequence(b)
+    if (typeof a === 'string') {
+      a = new Sequence(a)
     }
 
     return a.compare(b, strict)
@@ -205,13 +206,29 @@ export class Sequence {
   }
 
   at(index) {
-    assert(Number.isFinite(index) && index >= 0 && index * 2 < this.#parts.length)
+    if (!Number.isInteger(index)) {
+      throw new TypeError('index must be an integer')
+    }
+    if (index < 0 || index >= this.#parts.length / 2) {
+      throw new RangeError('index out of range')
+    }
+
     return this.#parts[index * 2 + 1]
   }
 
   set(index, sequence) {
-    assert(Number.isFinite(index) && index >= 0 && index < this.#parts.length)
-    assert(Number.isFinite(sequence) && sequence >= 0)
+    if (!Number.isInteger(index)) {
+      throw new TypeError('index must be an integer')
+    }
+    if (index < 0 || index >= this.#parts.length / 2) {
+      throw new RangeError('index out of range')
+    }
+    if (!Number.isInteger(sequence)) {
+      throw new TypeError('sequence must be an integer')
+    }
+    if (sequence < 0) {
+      throw new RangeError('sequence must be non-negative')
+    }
     if (this.#parts[index * 2 + 1] !== sequence) {
       this.#parts[index * 2 + 1] = sequence
       this.#value = ''
@@ -224,11 +241,23 @@ export class Sequence {
       strict = true
     }
 
-    assert(other instanceof Sequence)
-    assert(typeof strict === 'boolean')
+    if (typeof other === 'string') {
+      if (this.#value && this.#value === other) {
+        return 0
+      }
+      other = new Sequence(other)
+    }
+
+    if (!(other instanceof Sequence)) {
+      throw new TypeError('Can only compare with another Sequence')
+    }
+
+    if (typeof strict !== 'boolean') {
+      throw new TypeError('strict must be a boolean')
+    }
 
-    if (strict && other.identity && this.identity) {
-      assert.strictEqual(other.identity, this.identity)
+    if (strict && other.identity && this.identity && other.identity !== this.identity) {
+      throw new Error('Cannot compare sequences with different identities')
     }
 
     if (this.#parts.length !== other.#parts.length) {
@@ -256,4 +285,12 @@ export class Sequence {
     }
     return this.#value
   }
+
+  [Symbol.toStringTag]() {
+    return this.toString()
+  }
+
+  [util.inspect.custom](depth, options, inspect) {
+    return `Sequence: "${this.toString()}"`
+  }
 }

package/slice.js

@@ -60,6 +60,22 @@ export class Slice {
       maxByteLength = byteLength
     }
 
+    if (byteOffset < 0) {
+      throw new RangeError('byteOffset must be non-negative')
+    }
+
+    if (byteLength < 0) {
+      throw new RangeError('byteLength must be non-negative')
+    }
+
+    if (byteLength > maxByteLength) {
+      throw new RangeError('byteLength cannot be greater than maxByteLength')
+    }
+
+    if (byteOffset + maxByteLength > buffer.byteLength) {
+      throw new RangeError('Slice exceeds buffer length')
+    }
+
     const slice = POOL.pop()
 
     if (slice) {