@nxtedition/lib 28.0.18 → 28.0.20

package/http.js

@@ -216,6 +216,10 @@ export async function requestMiddleware(ctx, next) {
     stats.pending++
   }
 
+  if (ctx[kPendingIndex] !== -1) {
+    throw new Error('context is already pending')
+  }
+
   ctx[kPendingIndex] = pending.push(ctx) - 1
   try {
     const isHealthcheck = req.url === '/healthcheck' || req.url === '/_up'
@@ -366,11 +370,12 @@ export async function requestMiddleware(ctx, next) {
 
     if (ctx[kPendingIndex] !== -1) {
       const idx = ctx[kPendingIndex]
+      ctx[kPendingIndex] = -1
+
       const tmp = pending.pop()
       if (tmp !== ctx) {
         pending[idx] = tmp
         pending[idx][kPendingIndex] = idx
-        tmp[kPendingIndex] = -1
       }
     }
 
@@ -464,10 +469,12 @@ export class ServerResponse extends http.ServerResponse {
     return this.#bytesWritten
   }
 
+  /** @deprecated */
   setHeaders() {
     throw new Error('not supported')
   }
 
+  /** @deprecated */
   appendHeader() {
     throw new Error('not supported')
   }
@@ -530,7 +537,6 @@ export class ServerResponse extends http.ServerResponse {
   /**
    * @param {number} statusCode
    * @param {Record<string, string>} [headers]
-   * @returns
    */
   writeHead(statusCode, headers) {
     if (this.#headersSent) {
@@ -554,7 +560,6 @@ export class ServerResponse extends http.ServerResponse {
 
   /**
    * @param {net.Socket} socket
-   * @returns
    */
   assignSocket(socket) {
     if (!this.destroyed) {
@@ -565,6 +570,11 @@ export class ServerResponse extends http.ServerResponse {
     return super.assignSocket(socket)
   }
 
+  /**
+   * @param {Buffer|string} chunk
+   * @param {string} [encoding]
+   * @param {(err: Error) => void} [callback]
+   */
   write(chunk, encoding, callback) {
     if (!this.destroyed) {
       if (this.#data === -1) {
@@ -587,6 +597,11 @@ export class ServerResponse extends http.ServerResponse {
     return super.write(chunk, encoding, callback)
   }
 
+  /**
+   * @param {Buffer|string} chunk
+   * @param {string} [encoding]
+   * @param {(err: Error) => void} [callback]
+   */
   end(chunk, encoding, callback) {
     if (!this.destroyed) {
       this.#end = performance.now() - this.#created
@@ -612,9 +627,7 @@ export class ServerResponse extends http.ServerResponse {
   }
 
   /**
-   *
    * @param {Error} [err]
-   * @returns
    */
   destroy(err) {
     if (!this.destroyed) {
@@ -672,11 +685,14 @@ export class Http2ServerRequest extends http2.Http2ServerRequest {
 export class Http2ServerResponse extends http2.Http2ServerResponse {
   #created = performance.now()
   #bytesWritten = 0
-  #connect = -1
+  #connect = 0
   #headers = -1
   #data = -1
   #end = -1
 
+  #headersObj = kEmptyObj
+  #headersSent = false
+
   /**
    * @returns {{
    *   created: number,
@@ -696,19 +712,108 @@ export class Http2ServerResponse extends http2.Http2ServerResponse {
     }
   }
 
+  /**
+   * @returns {number}
+   */
   get bytesWritten() {
     return this.#bytesWritten
   }
 
-  flushHeaders() {
+  /** @deprecated */
+  setHeaders() {
+    throw new Error('not supported')
+  }
+
+  /** @deprecated */
+  appendHeader() {
+    throw new Error('not supported')
+  }
+
+  /**
+   * @param {string} key
+   * @param {string} val
+   */
+  setHeader(key, val) {
+    if (this.#headersSent) {
+      throw new Error('headers already sent')
+    }
+
+    if (this.#headersObj === kEmptyObj) {
+      this.#headersObj = {}
+    }
+
+    this.#headersObj[key] = val === undefined ? undefined : `${val}`
+  }
+
+  /**
+   * @param {string} key
+   * @param {string} val
+   */
+  removeHeader(key, val) {
+    if (this.#headersSent) {
+      throw new Error('headers already sent')
+    }
+
+    if (this.#headersObj !== kEmptyObj) {
+      delete this.#headersObj[key]
+    }
+  }
+
+  /**
+   * @returns {string[]}
+   */
+  getHeaderNames() {
+    if (this.#headersSent) {
+      throw new Error('headers already sent')
+    }
+
+    return this.#headersObj === kEmptyObj ? kEmptyArr : Object.keys(this.#headersObj)
+  }
+
+  /**
+   * @returns {Record<string, string>}
+   */
+  getHeaders() {
+    return this.#headersObj
+  }
+
+  /**
+   * @returns {boolean}
+   */
+  get headersSent() {
+    return this.#headersSent
+  }
+
+  /**
+   * @param {number} statusCode
+   * @param {Record<string, string>} [headers]
+   * @returns
+   */
+  writeHead(statusCode, headers) {
+    if (this.#headersSent) {
+      throw new Error('headers already sent')
+    }
+
+    if (this.#headersObj !== kEmptyObj) {
+      headers = headers ? Object.assign(this.#headersObj, headers) : this.#headersObj
+    }
+
     if (!this.destroyed) {
       if (this.#headers === -1) {
         this.#headers = performance.now() - this.#created
       }
     }
-    return super.flushHeaders()
+
+    this.#headersSent = true
+
+    return super.writeHead(statusCode, headers)
   }
 
+  /**
+   * @param {Buffer|string} chunk
+   * @param {string} [encoding]
+   * @param {(err: Error) => void} [callback]
+   */
   write(chunk, encoding, callback) {
     if (!this.destroyed) {
       if (this.#data === -1) {
@@ -731,6 +836,11 @@ export class Http2ServerResponse extends http2.Http2ServerResponse {
     return super.write(chunk, encoding, callback)
   }
 
+  /**
+   * @param {Buffer|string} chunk
+   * @param {string} [encoding]
+   * @param {(err: Error) => void} [callback]
+   */
   end(chunk, encoding, callback) {
     if (!this.destroyed) {
       this.#end = performance.now() - this.#created
@@ -755,6 +865,9 @@ export class Http2ServerResponse extends http2.Http2ServerResponse {
     return super.end(chunk, encoding, callback)
   }
 
+  /**
+   * @param {Error} [err]
+   */
   destroy(err) {
     if (!this.destroyed) {
       if (this.#end === -1) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/lib",
-  "version": "28.0.18",
+  "version": "28.0.20",
   "license": "UNLICENSED",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "type": "module",
@@ -92,5 +92,5 @@
     "pino": ">=7.0.0",
     "rxjs": "^7.0.0"
   },
-  "gitHead": "0e9eba55a86700d53a902b3478366d6cb9791634"
+  "gitHead": "b33dfcfc5f68626f846f364805f51a0e6de74cce"
 }