@nxtedition/lib 28.0.15 → 28.0.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/lib",
-  "version": "28.0.15",
+  "version": "28.0.17",
   "license": "UNLICENSED",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "type": "module",
@@ -92,5 +92,5 @@
     "pino": ">=7.0.0",
     "rxjs": "^7.0.0"
   },
-  "gitHead": "94248f1ed504b65609a9e060335aaabd9d2a0da4"
+  "gitHead": "dfb1058f0e5dea78cb723add803ada5bcfdb908c"
 }

package/shared.js

@@ -94,9 +94,6 @@ export function reader({ sharedState, sharedBuffer }) {
       // wrapped around to the beginning of the buffer.
       if (dataLen === -1) {
         readPos = 0
-        // After wrapping, we must re-check against the writer's position.
-        // It's possible the writer is now at a position > 0.
-        writePos = Atomics.load(state, WRITE_INDEX) | 0
       } else {
         if (dataLen < 0) {
           throw new Error('Invalid data length')
@@ -122,7 +119,7 @@ export function reader({ sharedState, sharedBuffer }) {
     }
 
     // IMPORTANT: The reader only updates its shared `readPos` after a batch
-    // is processed. This significantly reduces atomic write contention.
+    // is processed. This significantly reduces atomic operation overhead.
     if (bytes > 0) {
       Atomics.store(state, READ_INDEX, readPos)
     }
@@ -228,7 +225,7 @@ export function writer({ sharedState, sharedBuffer }, { yield: onYield, logger }
       }
 
       if (readPos === 0) {
-        readPos = Atomics.load(state, READ_INDEX) | 0
+        _yield(0)
       }
 
       // Not enough space at the end. Check if there's space at the beginning.
@@ -259,7 +256,7 @@ export function writer({ sharedState, sharedBuffer }, { yield: onYield, logger }
     // The only free space is between W and R.
 
     if (readPos - writePos < required) {
-      readPos = Atomics.load(state, READ_INDEX) | 0
+      _yield(0)
     }
 
     return readPos - writePos >= required
@@ -375,7 +372,6 @@ export function writer({ sharedState, sharedBuffer }, { yield: onYield, logger }
     if (!_acquire(len)) {
       const startTime = performance.now()
       logger?.warn({ readPos, writePos }, 'yield started')
-      _yield(0)
       for (let n = 0; !_acquire(len); n++) {
         if (performance.now() - startTime > timeout) {
           throw new Error('Timeout while waiting for space in the buffer')

package/slice.js

@@ -1,7 +1,6 @@
 import util from 'node:util'
 
 const EMPTY_BUF = Buffer.alloc(0)
-const POOL = []
 
 export class Slice {
   buffer
@@ -24,6 +23,10 @@ export class Slice {
     byteLength = buffer.byteLength,
     maxByteLength = byteLength,
   ) {
+    if (!(buffer instanceof Buffer)) {
+      throw new TypeError('buffer must be a Buffer')
+    }
+
     if (byteOffset < 0 || !Number.isInteger(byteOffset)) {
       throw new RangeError(`Invalid byteOffset: ${byteOffset}`)
     }
@@ -46,61 +49,6 @@ export class Slice {
     this.maxByteLength = maxByteLength
   }
 
-  static create(buffer, byteOffset, byteLength, maxByteLength) {
-    if (buffer === undefined) {
-      buffer = Slice.EMPTY_BUF
-    }
-    if (byteOffset === undefined) {
-      byteOffset = 0
-    }
-    if (byteLength === undefined) {
-      byteLength = buffer.byteLength
-    }
-    if (maxByteLength === undefined) {
-      maxByteLength = byteLength
-    }
-
-    if (byteOffset < 0) {
-      throw new RangeError('byteOffset must be non-negative')
-    }
-
-    if (byteLength < 0) {
-      throw new RangeError('byteLength must be non-negative')
-    }
-
-    if (byteLength > maxByteLength) {
-      throw new RangeError('byteLength cannot be greater than maxByteLength')
-    }
-
-    if (byteOffset + maxByteLength > buffer.byteLength) {
-      throw new RangeError('Slice exceeds buffer length')
-    }
-
-    const slice = POOL.pop()
-
-    if (slice) {
-      slice.buffer = buffer
-      slice.byteOffset = byteOffset
-      slice.byteLength = byteLength
-      slice.maxByteLength = maxByteLength
-      return slice
-    }
-
-    return new Slice(buffer, byteOffset, byteLength, maxByteLength)
-  }
-
-  static free(slice) {
-    if (slice == null) {
-      return
-    }
-
-    slice.reset()
-
-    if (POOL.length < 16 * 1024) {
-      POOL.push(slice)
-    }
-  }
-
   reset() {
     this.buffer = Slice.EMPTY_BUF
     this.byteOffset = 0