@nxtedition/lib 21.0.16 → 21.0.17

package/http.js

@@ -67,24 +67,19 @@ export async function request(ctx, next) {
       reqLogger.debug('request started')
     }
 
-    await Promise.all([
-      next(),
-      new Promise((resolve, reject) => {
-        req.on('timeout', onRequestTimeout).on('error', reject)
-        res
-          .on('timeout', onResponseTimeout)
-          .on('error', reject)
-          // TODO (fix): Use 'end' once we can trust that
-          // 'end' or 'error' will always be emitted.
-          .on('close', function () {
-            this.log.debug('request closed')
-            resolve(null)
-            ac.abort()
-          })
-      }),
-    ])
+    try {
+      await Promise.all([
+        next(),
+        new Promise((resolve, reject) => {
+          req.on('timeout', onRequestTimeout).on('error', reject)
+          res.on('timeout', onResponseTimeout).on('error', reject).on('close', resolve)
+        }),
+      ])
+    } finally {
+      ac.abort()
+    }
 
-    const elapsedTime = Math.round(performance.now() - startTime)
+    const elapsedTime = Math.ceil(performance.now() - startTime)
 
     if (isHealthcheck) {
       // Do nothing...
@@ -99,7 +94,7 @@ export async function request(ctx, next) {
     }
   } catch (err) {
     const statusCode = err.statusCode || err.$metadata?.httpStatusCode || 500
-    const responseTime = Math.round(performance.now() - startTime)
+    const responseTime = Math.ceil(performance.now() - startTime)
 
     if (!res.headersSent && !res.destroyed) {
       res.statusCode = statusCode
@@ -129,24 +124,20 @@ export async function request(ctx, next) {
         res.write(JSON.stringify(err.body))
       }
 
-      reqLogger = reqLogger.child({ res, err, responseTime })
-
       if (statusCode < 500) {
-        reqLogger.warn('request failed')
+        reqLogger.warn({ res, err, responseTime }, 'request failed')
       } else {
-        reqLogger.error('request error')
+        reqLogger.error({ res, err, responseTime }, 'request error')
       }
 
       res.end()
     } else {
-      reqLogger = reqLogger.child({ res, err, responseTime })
-
       if (req.aborted || !res.writableEnded || err.name === 'AbortError') {
-        reqLogger.debug('request aborted')
+        reqLogger.debug({ res, err, responseTime }, 'request aborted')
       } else if (statusCode < 500) {
-        reqLogger.warn('request failed')
+        reqLogger.warn({ res, err, responseTime }, 'request failed')
       } else {
-        reqLogger.error('request error')
+        reqLogger.error({ res, err, responseTime }, 'request error')
       }
 
       if (!res.writableEnded) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/lib",
-  "version": "21.0.16",
+  "version": "21.0.17",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "type": "module",