@nxtedition/lib 19.1.3 → 19.1.5

package/errors.js

@@ -42,12 +42,16 @@ export function parseError(error) {
 const kSeen = Symbol('kSeen')
 
 export function serializeError(error) {
+  return _serializeError(error, { depth: 0 })
+}
+
+function _serializeError(error, { depth }) {
   if (!error) {
     return null
   }
 
   if (typeof error === 'string') {
-    return [serializeError({ message: error })]
+    return [_serializeError({ message: error }, { depth })]
   }
 
   if (Buffer.isBuffer(error)) {
@@ -55,13 +59,17 @@ export function serializeError(error) {
   }
 
   if (Array.isArray(error)) {
-    return error.map(serializeError).filter(Boolean)
+    return error.map((x) => _serializeError(x, { depth })).filter(Boolean)
   }
 
   if (Object.prototype.hasOwnProperty.call(error, kSeen)) {
     return null
   }
 
+  if (depth > 8) {
+    return [{ messages: 'Maximum error serialization depth exceeded' }]
+  }
+
   error[kSeen] = undefined
 
   const type =
@@ -104,8 +112,10 @@ export function serializeError(error) {
     signalCode = SIGNALS[signalCode] ?? signalCode
   }
 
-  errors = Array.isArray(errors) ? errors.map(serializeError).filter(Boolean) : undefined
-  cause = cause ? serializeError(cause) : undefined
+  errors = Array.isArray(errors)
+    ? errors.map((x) => _serializeError(x, { depth: depth + 1 })).filter(Boolean)
+    : undefined
+  cause = cause ? _serializeError(cause, { depth: depth + 1 }) : undefined
 
   delete error[kSeen]
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/lib",
-  "version": "19.1.3",
+  "version": "19.1.5",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "type": "module",

package/s3.js

@@ -4,7 +4,8 @@ import tp from 'node:timers/promises'
 import AWS from '@aws-sdk/client-s3'
 import PQueue from 'p-queue'
 
-const queue = new PQueue({ concurrency: 8 })
+const QUEUE = new PQueue({ concurrency: 8 })
+const MD5_HEX_EXPR = /^[A-F0-9]{32}$/i
 
 /**
  * Uploads a file to S3 using multipart upload.
@@ -14,6 +15,7 @@ const queue = new PQueue({ concurrency: 8 })
  * @param {AbortSignal} options.signal - The signal to abort the upload.
  * @param {Object} options.logger - The logger to use.
  * @param {number} [options.partSize=16e6] - The size of each part in the multipart upload.
+ * @param {PQueue} [options.queue] - The queue to use for part uploads.
  * @param {Object} options.params - The parameters for the upload.
  * @param {Buffer|NodeJS.ReadStream} options.params.Body - The data to upload.
  * @param {string} options.params.Key - The key of the object.
@@ -22,7 +24,14 @@ const queue = new PQueue({ concurrency: 8 })
  * @param {number} [options.params.ContentLength] - The length of the object.
  * @returns {Promise<Object>} The result of the upload.
  */
-export async function upload({ client: s3, signal, logger, partSize = 16e6, params }) {
+export async function upload({
+  client: s3,
+  queue = QUEUE,
+  signal,
+  logger,
+  partSize = 16e6,
+  params,
+}) {
   if (s3 == null) {
     throw new Error('Invalid client')
   }
@@ -35,9 +44,18 @@ export async function upload({ client: s3, signal, logger, partSize = 16e6, para
     throw new Error('Invalid params')
   }
 
-  const { Body, Key, Bucket, ContentMD5, ContentLength } = params ?? {}
+  const { Body, Key, Bucket, ContentMD5, ContentLength } = params
 
-  // TODO (fix): Valdate ContentMD & ContentLength
+  const size = ContentLength != null ? Number(ContentLength) : null
+
+  if (size != null && (!Number.isFinite(size) || size < 0)) {
+    throw new Error('Invalid params.ContentLength')
+  }
+
+  const hash = ContentMD5 != null ? Buffer.from(ContentMD5, 'base64').toString('hex') : null
+  if (hash != null && !MD5_HEX_EXPR.test(hash)) {
+    throw new Error('Invalid params.ContentMD5')
+  }
 
   const promises = []
 
@@ -123,7 +141,7 @@ export async function upload({ client: s3, signal, logger, partSize = 16e6, para
                 } catch (err) {
                   logger?.warn({ err }, 'part upload failed')
 
-                  if (retryCount < 3) {
+                  if (retryCount < 5) {
                     logger?.debug({ retryCount }, 'part upload retry')
                     await tp.setTimeout(1e3, undefined, { signal: uploader.signal })
                   } else {
@@ -196,9 +214,6 @@ export async function upload({ client: s3, signal, logger, partSize = 16e6, para
       parts,
     }
 
-    const size = ContentLength != null ? Number(ContentLength) : null
-    const hash = ContentMD5 ? Buffer.from(ContentMD5, 'base64').toString('hex') : null
-
     if (size != null && size !== result.size) {
       throw new Error(`Expected size ${size} but got ${result.size}`)
     }