@nxtedition/lib 19.1.0 → 19.1.1

package/couch.js

@@ -1,4 +1,5 @@
 import assert from 'node:assert'
+import stream from 'node:stream'
 import querystring from 'node:querystring'
 import createError from 'http-errors'
 import { makeWeakCache } from './weakCache.js'
@@ -8,7 +9,6 @@ import urljoin from 'url-join'
 import undici from 'undici'
 import { AbortError } from './errors.js'
 import split2 from 'split2'
-import stream from 'node:stream'
 
 // https://github.com/fastify/fastify/blob/main/lib/reqIdGenFactory.js
 // 2,147,483,647 (2^31 − 1) stands for max SMI value (an internal optimization of V8).
@@ -886,26 +886,21 @@ function _normalizeAllDocsOptions({
   }
 }
 
-class Handler {
-  #state = 0
-  #str = ''
-  #decoder = new TextDecoder()
-  #resolve
-  #reject
-  #resume
-  #abort
+class Handler extends undici.DecoratorHandler {
+  #str
+  #decoder
   #onAbort
   #signal
-  #next
   #statusCode
   #statusText
   #opts
+  #handler
+
+  constructor({ opts, signal, handler }) {
+    super(handler)
 
-  constructor({ opts, signal, resolve, reject, next }) {
-    this.#next = next
+    this.#handler = handler
     this.#opts = opts
-    this.#resolve = resolve
-    this.#reject = reject
     this.#signal = signal
   }
 
@@ -913,101 +908,64 @@ class Handler {
     if (this.#signal?.aborted) {
       abort(this.#signal.reason)
     } else {
-      this.#abort = abort
       if (this.#signal) {
         this.#onAbort = () => abort(this.#signal.reason)
         this.#signal.addEventListener('abort', this.#onAbort)
       }
+
+      this.#str = ''
+      this.#decoder = null
+      this.#handler.onConnect?.(abort)
     }
   }
 
   onHeaders(statusCode, rawHeaders, resume, statusText) {
     this.#statusCode = statusCode
     this.#statusText = statusText
-    this.#resume = resume
 
     if (this.#statusCode >= 200 && this.#statusCode < 300) {
-      this.#next = null
+      this.#handler.onHeaders?.(statusCode, rawHeaders, resume, statusText)
+    } else {
+      this.#decoder = new TextDecoder()
     }
   }
 
   onData(data) {
-    if (!this.#next) {
+    if (this.#decoder) {
       this.#str += this.#decoder.decode(data, { stream: true })
     } else {
-      const lines = this.#decoder.decode(data, { stream: true }).split(/\r?\n+/)
-      lines[0] = this.#str + lines[0]
-      this.#str = lines.pop() ?? ''
-
-      const rows = []
-      for (const line of lines) {
-        if (this.#state === 0) {
-          if (line.endsWith('[')) {
-            this.#state = 1
-          } else {
-            throw new Error('unexpected data')
-          }
-        } else if (this.#state === 1) {
-          if (line.startsWith(']')) {
-            this.#state = 2
-          } else {
-            rows.push(JSON.parse(line.slice(0, line.lastIndexOf('}') + 1)))
-          }
-        }
-      }
-
-      if (rows.length === 0) {
-        return true
-      }
-
-      const thenable = this.#next(rows)
-
-      if (!thenable) {
-        return true
-      }
-
-      thenable.then(this.#resume, this.#abort)
-
-      return false
+      return this.#handler?.onData(data)
     }
   }
 
-  onComplete() {
-    assert(!this.#next || this.#state === 2)
-
-    if (!this.#next) {
-      this.#str += this.#decoder.decode(undefined, { stream: false })
-
-      if (this.#statusCode >= 200 && this.#statusCode < 300) {
-        this.onFinally(null, this.#next ? null : JSON.parse(this.#str))
-      } else {
-        let body
-        let reason
-        let error
-        try {
-          body = JSON.parse(this.#str)
-          reason = body.reason
-          error = body.error
-        } catch {
-          // Do nothing...
-        }
+  onComplete(trailers) {
+    if (this.#decoder) {
+      let body
+      let reason
+      let error
+      try {
+        body = JSON.parse(this.#str)
+        reason = body.reason
+        error = body.error
+      } catch {
+        // Do nothing...
+      }
 
-        this.onFinally(
-          Object.assign(new Error(this.#statusText ?? reason), {
-            reason,
-            error,
-            data: {
-              req: this.#opts,
-              res: {
-                body,
-                statusCode: this.#statusCode,
-              },
+      this.onFinally(
+        Object.assign(new Error(this.#statusText ?? reason), {
+          reason,
+          error,
+          data: {
+            req: this.#opts,
+            res: {
+              body,
+              statusCode: this.#statusCode,
             },
-          }),
-        )
-      }
+          },
+        }),
+      )
     } else {
-      this.onFinally(null)
+      this.onFinally(null, trailers)
     }
   }
 
@@ -1021,14 +979,127 @@ class Handler {
     }
 
     if (err) {
-      this.#reject(err)
+      this.#handler.onError?.(err)
+    } else {
+      this.#handler.onComplete?.(val)
+    }
+  }
+}
+
+class StreamOutput extends stream.Readable {
+  #str
+  #resume
+  #abort
+  #state
+  #decoder
+  #didPush = false
+
+  constructor({ highWaterMark }) {
+    super({ objectMode: true, highWaterMark })
+  }
+
+  _read() {
+    this.#resume?.()
+  }
+
+  _destroy(err, callback) {
+    this.#abort?.(err)
+    callback(err)
+  }
+
+  onConnect(abort) {
+    if (this.destroyed) {
+      abort(this.errored)
+    } else if (!this.#didPush) {
+      this.#state = 0
+      this.#str = ''
+      this.#abort = abort
+      this.#decoder = new TextDecoder()
     } else {
-      this.#resolve(val)
+      throw new Error('unusable')
+    }
+  }
+
+  onHeaders(statusCode, rawHeaders, resume, statusText) {
+    if (statusCode >= 300 || statusCode < 200) {
+      throw new Error('invalid status code: ' + statusCode)
+    }
+
+    this.#resume = resume
+  }
+
+  onData(data) {
+    const lines = this.#decoder.decode(data, { stream: true }).split(/\r?\n+/)
+    lines[0] = this.#str + lines[0]
+    this.#str = lines.pop() ?? ''
+
+    for (const line of lines) {
+      if (this.#state === 0) {
+        if (line.endsWith('[')) {
+          this.#state = 1
+        } else {
+          throw new Error('unexpected data')
+        }
+      } else if (this.#state === 1) {
+        if (line.startsWith(']')) {
+          this.#state = 2
+        } else {
+          this.push(JSON.parse(line.slice(0, line.lastIndexOf('}') + 1)))
+          this.#didPush = true
+        }
+      }
     }
+
+    return this.readableLength < this.readableHighWaterMark
+  }
+
+  onComplete() {
+    assert(this.#state === 2)
+    this.push(null)
+  }
+
+  onError(err) {
+    this.destroy(err)
   }
 }
 
-export async function request(
+class PromiseOutput {
+  #resolve
+  #reject
+  #str
+  #decoder
+
+  constructor({ resolve, reject }) {
+    this.#resolve = resolve
+    this.#reject = reject
+  }
+
+  onConnect() {
+    this.#decoder = new TextDecoder()
+    this.#str = ''
+  }
+
+  onHeaders(statusCode, rawHeaders, resume, statusText) {
+    if (statusCode >= 300 || statusCode < 200) {
+      throw new Error('invalid status code: ' + statusCode)
+    }
+  }
+
+  onData(data) {
+    this.#str += this.#decoder.decode(data, { stream: true })
+  }
+
+  onComplete() {
+    this.#str += this.#decoder.decode(undefined, { stream: false })
+    this.#resolve(JSON.parse(this.#str))
+  }
+
+  onError(err) {
+    this.#reject(err)
+  }
+}
+
+export function request(
   url,
   {
     body,
@@ -1037,8 +1108,8 @@ export async function request(
     headers,
     dispatcher = undici.getGlobalDispatcher(),
     signal,
+    stream,
   },
-  next,
 ) {
   url = new URL(url)
   if (url.search) {
@@ -1055,7 +1126,19 @@ export async function request(
     },
     body: body != null && typeof body === 'object' ? JSON.stringify(body) : body,
   }
-  return new Promise((resolve, reject) => {
-    dispatcher.dispatch(opts, new Handler({ opts, signal, resolve, reject, next }))
-  })
+
+  dispatcher = dispatcher.compose(
+    (dispatch) => (opts, handler) => dispatch(opts, new Handler({ opts, signal, handler })),
+  )
+
+  if (stream) {
+    const handler = new StreamOutput({ highWaterMark: stream.highWaterMark ?? 128 })
+    dispatcher.dispatch(opts, handler)
+    return handler
+  } else {
+    return new Promise((resolve, reject) => {
+      const handler = new PromiseOutput({ resolve, reject })
+      dispatcher.dispatch(opts, handler)
+    })
+  }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/lib",
-  "version": "19.1.0",
+  "version": "19.1.1",
   "license": "MIT",
   "author": "Robert Nagy <robert.nagy@boffins.se>",
   "type": "module",
@@ -75,10 +75,10 @@
     "/__tests__"
   ],
   "dependencies": {
-    "@aws-sdk/client-s3": "^3.552.0",
+    "@aws-sdk/client-s3": "^3.554.0",
     "@elastic/elasticsearch": "^8.13.1",
-    "@elastic/transport": "^8.5.0",
-    "@nxtedition/nxt-undici": "^2.0.45",
+    "@elastic/transport": "^8.5.1",
+    "@nxtedition/nxt-undici": "^2.0.46",
     "date-fns": "^3.6.0",
     "fast-querystring": "^1.1.1",
     "hasha": "^6.0.0",
@@ -94,13 +94,13 @@
     "p-queue": "^8.0.1",
     "pino": "^8.20.0",
     "pino-std-serializers": "^6.2.2",
-    "qs": "^6.12.0",
+    "qs": "^6.12.1",
     "request-target": "^1.0.2",
     "smpte-timecode": "^1.3.5",
     "split-string": "^6.0.0",
     "split2": "^4.2.0",
     "toobusy-js": "^0.5.1",
-    "undici": "^6.12.0",
+    "undici": "^6.13.0",
     "url-join": "^5.0.0"
   },
   "devDependencies": {
@@ -111,7 +111,7 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-config-standard": "^17.0.0",
     "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-n": "^17.1.0",
+    "eslint-plugin-n": "^17.2.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^6.0.0",
     "husky": "^9.0.11",