@nxtedition/deepstream.io-client-js 24.0.0 → 24.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nxtedition/deepstream.io-client-js",
-  "version": "24.0.0",
+  "version": "24.0.2",
   "description": "the javascript client for deepstream.io",
   "homepage": "http://deepstream.io",
   "bugs": {

package/src/record/record-handler.js

@@ -13,8 +13,6 @@ const timers = require('../utils/timers')
 
 const kEmpty = Symbol('kEmpty')
 
-function noop() {}
-
 function onUpdate(record, subscription) {
   if (subscription.state && record.state < subscription.state) {
     return
@@ -172,6 +170,10 @@ class RecordHandler {
     return this._stats
   }
 
+  /**
+   * @param {string} name
+   * @returns {Record}
+   */
   getRecord(name) {
     invariant(
       typeof name === 'string' && name.length > 0 && name !== '[object Object]',
@@ -351,17 +353,18 @@ class RecordHandler {
         dataOnly,
         data: kEmpty,
         timeout: null,
-        abort: noop,
+        /** @type {Record?} */ record: null,
+        /** @type {Function?} */ abort: null,
         unsubscribe() {
           if (this.timeout) {
             timers.clearTimeout(this.timeout)
             this.timeout = null
           }
 
-          if (this.ignal) {
+          if (this.signal) {
             utils.removeAbortListener(this.signal, this.abort)
             this.signal = null
-            this.abort = noop
+            this.abort = null
           }
 
           if (this.record) {
@@ -372,14 +375,14 @@ class RecordHandler {
         },
       }
 
-      const record = this.getRecord(name).subscribe(onUpdate, subscription)
+      subscription.record = this.getRecord(name).subscribe(onUpdate, subscription)
 
-      if (timeout && subscription.state && record.state < subscription.state) {
+      if (timeout && subscription.state && subscription.record.state < subscription.state) {
         subscription.timeout = timers.setTimeout(onTimeout, timeout, subscription)
       }
 
-      if (record.version) {
-        onUpdate(record, subscription)
+      if (subscription.record.version) {
+        onUpdate(subscription.record, subscription)
       }
 
       if (subscription.signal) {

package/src/record/record.js

@@ -27,26 +27,34 @@ class Record {
     this._onPending(true)
   }
 
+  /** @type {string} */
   get name() {
     return this._name
   }
 
+  /** @type {string} */
   get version() {
     return this._version
   }
 
+  /** @type {Object} */
   get data() {
     return this._data
   }
 
+  /** @type {Number} */
   get state() {
     return this._state
   }
 
+  /** @type {Number} */
   get refs() {
     return this._refs
   }
 
+  /**
+   * @returns {Record}
+   */
   ref() {
     this._refs += 1
     if (this._refs === 1) {
@@ -56,6 +64,9 @@ class Record {
     return this
   }
 
+  /**
+   * @returns {Record}
+   */
   unref() {
     this._refs -= 1
     if (this._refs === 0) {
@@ -64,6 +75,11 @@ class Record {
     return this
   }
 
+  /**
+   * @param {*} fn
+   * @param {*} opaque
+   * @returns {Record}
+   */
   subscribe(fn, opaque = null) {
     if (this._emitting) {
       this._subscriptions = this._subscriptions.slice()
@@ -75,6 +91,12 @@ class Record {
     return this
   }
 
+  /**
+   *
+   * @param {*} fn
+   * @param {*} opaque
+   * @returns {Record}
+   */
   unsubscribe(fn, opaque = null) {
     if (this._emitting) {
       this._subscriptions = this._subscriptions.slice()