@nx/webpack 23.2.0-beta.10 → 23.2.0-beta.11

package/README.md

@@ -7,9 +7,9 @@
 
 <div style="text-align: center;">
 
-[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)]()
+[![License](https://img.shields.io/npm/l/@nx/workspace.svg?style=flat-square)](<>)
 [![NPM Version](https://badge.fury.io/js/nx.svg)](https://www.npmjs.com/package/nx)
-[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)]()
+[![Semantic Release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat-square)](<>)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
 [![Join us on the Official Nx Discord Server](https://img.shields.io/discord/1143497901675401286?label=discord)](https://go.nx.dev/community)
 [![Nx Sandboxing](https://staging.nx.app/workspaces/62d013ea0852fe0a2df74438/sandbox-badge.svg)](https://nx.dev/docs/features/ci-features/sandboxing)

package/dist/src/executors/webpack/schema.d.ts

@@ -93,8 +93,7 @@ export interface WebpackExecutorOptions {
   rebaseRootRelative?: boolean;
 }
 
-export interface NormalizedWebpackExecutorOptions
-  extends WebpackExecutorOptions {
+export interface NormalizedWebpackExecutorOptions extends WebpackExecutorOptions {
   outputFileName: string;
   assets: AssetGlobPattern[];
   root: string;

package/dist/src/plugins/nx-webpack-plugin/lib/apply-base-config.js

@@ -24,6 +24,23 @@ const extensionAlias = {
 };
 const extensions = ['.ts', '.tsx', '.mjs', '.js', '.jsx'];
 const mainFields = ['module', 'main'];
+/**
+ * `withNx` builds a raw config that webpack validates, and only the boolean is
+ * schema-valid before 5.110. `NxAppWebpackPlugin` instead mutates options that
+ * are already normalized, which 5.110 fills by setting `.javascript` on
+ * `minimize`, so a boolean throws there.
+ */
+function setMinimizeValue(optimization, shouldMinify, configIsNormalized) {
+    if (!shouldMinify) {
+        optimization.minimize = false;
+        return;
+    }
+    if (configIsNormalized) {
+        optimization.minimize = {};
+        return;
+    }
+    optimization.minimize = true;
+}
 function applyBaseConfig(options, config = {}, { useNormalizedEntry, } = {}) {
     // Defaults that was applied from executor schema previously.
     options.compiler ??= 'babel';
@@ -31,13 +48,13 @@ function applyBaseConfig(options, config = {}, { useNormalizedEntry, } = {}) {
     options.fileReplacements ??= [];
     options.memoryLimit ??= 2048;
     options.transformers ??= [];
-    applyNxIndependentConfig(options, config);
+    applyNxIndependentConfig(options, config, !!useNormalizedEntry);
     // Some of the options only work during actual tasks, not when reading the webpack config during CreateNodes.
     if (global.NX_GRAPH_CREATION)
         return;
     applyNxDependentConfig(options, config, { useNormalizedEntry });
 }
-function applyNxIndependentConfig(options, config) {
+function applyNxIndependentConfig(options, config, configIsNormalized) {
     const TerserPlugin = require('terser-webpack-plugin');
     const hashFormat = (0, hash_format_1.getOutputHashFormat)(options.outputHashing);
     config.context = path.join(options.root, options.projectRoot);
@@ -126,12 +143,12 @@ function applyNxIndependentConfig(options, config) {
         (x) => IGNORED_WEBPACK_WARNINGS.some((r) => typeof x === 'string' ? r.test(x) : r.test(x.message)),
         ...(config.ignoreWarnings ?? []),
     ];
+    const shouldMinify = typeof options.optimization === 'object'
+        ? !!options.optimization.scripts
+        : !!options.optimization;
     config.optimization = {
         ...config.optimization,
         sideEffects: true,
-        minimize: typeof options.optimization === 'object'
-            ? !!options.optimization.scripts
-            : !!options.optimization,
         minimizer: [
             options.compiler !== 'swc'
                 ? new TerserPlugin({
@@ -164,6 +181,7 @@ function applyNxIndependentConfig(options, config) {
         runtimeChunk: false,
         concatenateModules: true,
     };
+    setMinimizeValue(config.optimization, shouldMinify, configIsNormalized);
     config.stats = {
         hash: true,
         timings: false,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/webpack",
-  "version": "23.2.0-beta.10",
+  "version": "23.2.0-beta.11",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -118,8 +118,8 @@
     "tslib": "^2.3.0",
     "webpack-node-externals": "^3.0.0",
     "webpack-subresource-integrity": "^5.1.0",
-    "@nx/devkit": "23.2.0-beta.10",
-    "@nx/js": "23.2.0-beta.10"
+    "@nx/devkit": "23.2.0-beta.11",
+    "@nx/js": "23.2.0-beta.11"
   },
   "peerDependencies": {
     "webpack": "^5.0.0",
@@ -138,7 +138,7 @@
     }
   },
   "devDependencies": {
-    "nx": "23.2.0-beta.10"
+    "nx": "23.2.0-beta.11"
   },
   "publishConfig": {
     "access": "public"