@nx/webpack 19.8.14 → 19.8.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/webpack",
-  "version": "19.8.14",
+  "version": "19.8.15",
   "private": false,
   "description": "The Nx Plugin for Webpack contains executors and generators that support building applications using Webpack.",
   "repository": {
@@ -69,9 +69,9 @@
     "webpack-dev-server": "^5.0.4",
     "webpack-node-externals": "^3.0.0",
     "webpack-subresource-integrity": "^5.1.0",
-    "@nx/devkit": "19.8.14",
-    "@nx/js": "19.8.14",
-    "@nrwl/webpack": "19.8.14"
+    "@nx/devkit": "19.8.15",
+    "@nx/js": "19.8.15",
+    "@nrwl/webpack": "19.8.15"
   },
   "publishConfig": {
     "access": "public"

package/src/plugins/nx-typescript-webpack-plugin/nx-tsconfig-paths-webpack-plugin.d.ts

@@ -4,5 +4,5 @@ export declare class NxTsconfigPathsWebpackPlugin {
     private options;
     constructor(options: NormalizedNxAppWebpackPluginOptions);
     apply(compiler: Compiler): void;
-    handleBuildLibsFromSource(config: Partial<WebpackOptionsNormalized | Configuration>, options: any): void;
+    handleBuildLibsFromSource(config: Partial<WebpackOptionsNormalized | Configuration>, options: NormalizedNxAppWebpackPluginOptions): void;
 }

package/src/plugins/nx-typescript-webpack-plugin/nx-tsconfig-paths-webpack-plugin.js

@@ -42,7 +42,9 @@ class NxTsconfigPathsWebpackPlugin {
                     .map((dependency) => dependency.node.name)
                     .join(',');
                 const buildCommand = `nx run-many --target=build --projects=${buildableDependencies}`;
-                config.plugins.push(new webpack_nx_build_coordination_plugin_1.WebpackNxBuildCoordinationPlugin(buildCommand));
+                config.plugins.push(new webpack_nx_build_coordination_plugin_1.WebpackNxBuildCoordinationPlugin(buildCommand, {
+                    skipWatchingDeps: options.watchDependencies === false,
+                }));
             }
         }
     }

package/src/plugins/nx-webpack-plugin/nx-app-webpack-plugin-options.d.ts

@@ -222,6 +222,10 @@ export interface NxAppWebpackPluginOptions {
      * Whether to rebase absolute path for assets in postcss cli resources.
      */
     rebaseRootRelative?: boolean;
+    /**
+     * Watch buildable dependencies and rebuild when they change.
+     */
+    watchDependencies?: boolean;
 }
 export interface NormalizedNxAppWebpackPluginOptions extends NxAppWebpackPluginOptions {
     projectName: string;

package/src/plugins/webpack-nx-build-coordination-plugin.d.ts

@@ -1,11 +1,21 @@
 import type { Compiler } from 'webpack';
+type PluginOptions = {
+    skipInitialBuild?: boolean;
+    skipWatchingDeps?: boolean;
+};
 export declare class WebpackNxBuildCoordinationPlugin {
     private readonly buildCmd;
     private currentlyRunning;
     private buildCmdProcess;
+    constructor(buildCmd: string);
+    /**
+     * @deprecated Use the constructor with the `options` parameter instead.
+     */
     constructor(buildCmd: string, skipInitialBuild?: boolean);
+    constructor(buildCmd: string, options?: PluginOptions);
     apply(compiler: Compiler): void;
     startWatchingBuildableLibs(): Promise<void>;
     buildChangedProjects(): Promise<void>;
     private createFileWatcher;
 }
+export {};

package/src/plugins/webpack-nx-build-coordination-plugin.js

@@ -6,20 +6,25 @@ const client_1 = require("nx/src/daemon/client/client");
 const watch_1 = require("nx/src/command-line/watch/watch");
 const output_1 = require("nx/src/utils/output");
 class WebpackNxBuildCoordinationPlugin {
-    constructor(buildCmd, skipInitialBuild) {
+    constructor(buildCmd, skipInitialBuildOrOptions) {
         this.buildCmd = buildCmd;
         this.currentlyRunning = 'none';
         this.buildCmdProcess = null;
-        if (!skipInitialBuild) {
+        const options = typeof skipInitialBuildOrOptions === 'boolean'
+            ? { skipInitialBuild: skipInitialBuildOrOptions }
+            : skipInitialBuildOrOptions;
+        if (!options?.skipInitialBuild) {
             this.buildChangedProjects();
         }
-        if ((0, client_1.isDaemonEnabled)()) {
-            this.startWatchingBuildableLibs();
-        }
-        else {
-            output_1.output.warn({
-                title: 'Nx Daemon is not enabled. Buildable libs will not be rebuilt on file changes.',
-            });
+        if (!options?.skipWatchingDeps) {
+            if ((0, client_1.isDaemonEnabled)()) {
+                this.startWatchingBuildableLibs();
+            }
+            else {
+                output_1.output.warn({
+                    title: 'Nx Daemon is not enabled. Buildable libs will not be rebuilt on file changes.',
+                });
+            }
         }
     }
     apply(compiler) {

package/src/utils/module-federation/get-remotes-for-host.js

@@ -49,7 +49,16 @@ function getRemotes(devRemotes, skipRemotes, config, context, pathToManifestFile
         devkit_1.logger.info(`Remotes not served automatically: ${[...remotesToSkip.values()].join(', ')}`);
     }
     const knownRemotes = Array.from(collectedRemotes).filter((r) => !remotesToSkip.has(r));
-    const knownDynamicRemotes = dynamicRemotes.filter((r) => !remotesToSkip.has(r) && context.projectGraph.nodes[r]);
+    // With dynamic remotes, the manifest file may contain the names with `_` due to MF limitations on naming
+    // The project graph might contain these names with `-` rather than `_`. Check for both.
+    // This can occur after migration of existing remotes past Nx 19.8
+    let normalizedDynamicRemotes = dynamicRemotes.map((r) => {
+        if (context.projectGraph.nodes[r.replace(/_/g, '-')]) {
+            return r.replace(/_/g, '-');
+        }
+        return r;
+    });
+    const knownDynamicRemotes = normalizedDynamicRemotes.filter((r) => !remotesToSkip.has(r) && context.projectGraph.nodes[r]);
     devkit_1.logger.info(`NX Starting module federation dev-server for ${chalk.bold(context.projectName)} with ${[...knownRemotes, ...knownDynamicRemotes].length} remotes`);
     const devServeApps = new Set(!devRemotes
         ? []