@nx/webpack 19.6.0-beta.0 → 19.6.0-beta.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/webpack",
-  "version": "19.6.0-beta.0",
+  "version": "19.6.0-beta.1",
   "private": false,
   "description": "The Nx Plugin for Webpack contains executors and generators that support building applications using Webpack.",
   "repository": {
@@ -69,9 +69,9 @@
     "webpack-dev-server": "^4.9.3",
     "webpack-node-externals": "^3.0.0",
     "webpack-subresource-integrity": "^5.1.0",
-    "@nx/devkit": "19.6.0-beta.0",
-    "@nx/js": "19.6.0-beta.0",
-    "@nrwl/webpack": "19.6.0-beta.0"
+    "@nx/devkit": "19.6.0-beta.1",
+    "@nx/js": "19.6.0-beta.1",
+    "@nrwl/webpack": "19.6.0-beta.1"
   },
   "publishConfig": {
     "access": "public"

package/src/plugins/use-legacy-nx-plugin/use-legacy-nx-plugin.d.ts

@@ -1,6 +1,6 @@
-import { NxWebpackExecutionContext } from '../../utils/config';
-import { NxAppWebpackPluginOptions } from '../nx-webpack-plugin/nx-app-webpack-plugin-options';
-import { Configuration } from 'webpack';
+import type { NxWebpackExecutionContext } from '../../utils/config';
+import type { NxAppWebpackPluginOptions } from '../nx-webpack-plugin/nx-app-webpack-plugin-options';
+import type { Compiler, Configuration } from 'webpack';
 /**
  * This function is used to wrap the legacy plugin function to be used with the `composePlugins` function.
  * Initially the webpack config would be passed to the legacy plugin function and the options would be passed as a second argument.
@@ -26,4 +26,6 @@ module.exports = async () => ({
  * @param executorOptions The options passed usually inside the executor or the config file
  * @returns Webpack configuration
  */
-export declare function useLegacyNxPlugin(fn: (config: Configuration, ctx: NxWebpackExecutionContext) => Promise<Configuration>, executorOptions: NxAppWebpackPluginOptions): Promise<(config: Configuration) => Promise<Configuration>>;
+export declare function useLegacyNxPlugin(fn: (config: Configuration, ctx: NxWebpackExecutionContext) => Promise<Configuration>, executorOptions: NxAppWebpackPluginOptions): Promise<{
+    apply(compiler: Compiler): void;
+}>;

package/src/plugins/use-legacy-nx-plugin/use-legacy-nx-plugin.js

@@ -47,12 +47,24 @@ async function useLegacyNxPlugin(fn, executorOptions) {
         projectName: projectName,
     };
     const configuration = process.env.NX_TASK_TARGET_CONFIGURATION;
-    return async (config) => {
-        const ctx = {
-            context,
-            options: options,
-            configuration,
-        };
-        return await fn(config, ctx);
+    const ctx = {
+        context,
+        options: options,
+        configuration,
+    };
+    return {
+        apply(compiler) {
+            compiler.hooks.beforeCompile.tapPromise('NxLegacyAsyncPlugin', () => {
+                return new Promise((resolve) => {
+                    fn(compiler.options, ctx).then((updated) => {
+                        // Merge options back shallowly since it's a fully functional configuration.
+                        // Most likely, the user modified the config in place, but this guarantees that updates are applied if users did something like:
+                        // `return { ...config, plugins: [...config.plugins, new MyPlugin()] }`
+                        Object.assign(compiler.options, updated);
+                        resolve();
+                    });
+                });
+            });
+        },
     };
 }