@nx/webpack 18.0.0-beta.1 → 18.0.0-beta.3

package/generators.json

@@ -3,7 +3,7 @@
   "version": "0.1",
   "generators": {
     "init": {
-      "factory": "./src/generators/init/init#webpackInitGenerator",
+      "factory": "./src/generators/init/init#webpackInitGeneratorInternal",
       "schema": "./src/generators/init/schema.json",
       "description": "Initialize the `@nrwl/webpack` plugin.",
       "aliases": ["ng-add"],
@@ -11,7 +11,7 @@
     },
     "configuration": {
       "aliases": ["webpack-project"],
-      "factory": "./src/generators/configuration/configuration",
+      "factory": "./src/generators/configuration/configuration#configurationGeneratorInternal",
       "schema": "./src/generators/configuration/schema.json",
       "description": "Add webpack configuration to a project.",
       "hidden": true

package/index.d.ts

@@ -4,7 +4,7 @@ export { configurationGenerator };
 export declare const webpackProjectGenerator: typeof configurationGenerator;
 export * from './src/utils/create-copy-plugin';
 export * from './src/utils/config';
-export * from './src/generators/init/init';
+export { webpackInitGenerator } from './src/generators/init/init';
 export type { WebDevServerOptions } from './src/executors/dev-server/schema';
 export * from './src/executors/dev-server/dev-server.impl';
 export * from './src/executors/webpack/lib/normalize-options';

package/index.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.NxTsconfigPathsWebpackPlugin = exports.NxWebpackPlugin = exports.webpackProjectGenerator = exports.configurationGenerator = void 0;
+exports.NxTsconfigPathsWebpackPlugin = exports.NxWebpackPlugin = exports.webpackInitGenerator = exports.webpackProjectGenerator = exports.configurationGenerator = void 0;
 const tslib_1 = require("tslib");
 const configuration_1 = require("./src/generators/configuration/configuration");
 Object.defineProperty(exports, "configurationGenerator", { enumerable: true, get: function () { return configuration_1.configurationGenerator; } });
@@ -9,7 +9,8 @@ Object.defineProperty(exports, "configurationGenerator", { enumerable: true, get
 exports.webpackProjectGenerator = configuration_1.configurationGenerator;
 tslib_1.__exportStar(require("./src/utils/create-copy-plugin"), exports);
 tslib_1.__exportStar(require("./src/utils/config"), exports);
-tslib_1.__exportStar(require("./src/generators/init/init"), exports);
+var init_1 = require("./src/generators/init/init");
+Object.defineProperty(exports, "webpackInitGenerator", { enumerable: true, get: function () { return init_1.webpackInitGenerator; } });
 tslib_1.__exportStar(require("./src/executors/dev-server/dev-server.impl"), exports);
 tslib_1.__exportStar(require("./src/executors/webpack/lib/normalize-options"), exports);
 tslib_1.__exportStar(require("./src/executors/webpack/webpack.impl"), exports);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/webpack",
-  "version": "18.0.0-beta.1",
+  "version": "18.0.0-beta.3",
   "private": false,
   "description": "The Nx Plugin for Webpack contains executors and generators that support building applications using Webpack.",
   "repository": {
@@ -62,9 +62,9 @@
     "webpack-dev-server": "^4.9.3",
     "webpack-node-externals": "^3.0.0",
     "webpack-subresource-integrity": "^5.1.0",
-    "@nx/devkit": "18.0.0-beta.1",
-    "@nx/js": "18.0.0-beta.1",
-    "@nrwl/webpack": "18.0.0-beta.1"
+    "@nx/devkit": "18.0.0-beta.3",
+    "@nx/js": "18.0.0-beta.3",
+    "@nrwl/webpack": "18.0.0-beta.3"
   },
   "publishConfig": {
     "access": "public"

package/src/generators/configuration/configuration.d.ts

@@ -1,4 +1,5 @@
-import { Tree } from '@nx/devkit';
+import { GeneratorCallback, Tree } from '@nx/devkit';
 import { ConfigurationGeneratorSchema } from './schema';
-export declare function configurationGenerator(tree: Tree, options: ConfigurationGeneratorSchema): Promise<import("@nx/devkit").GeneratorCallback>;
+export declare function configurationGenerator(tree: Tree, options: ConfigurationGeneratorSchema): Promise<GeneratorCallback>;
+export declare function configurationGeneratorInternal(tree: Tree, options: ConfigurationGeneratorSchema): Promise<GeneratorCallback>;
 export default configurationGenerator;

package/src/generators/configuration/configuration.js

@@ -1,15 +1,27 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.configurationGenerator = void 0;
+exports.configurationGeneratorInternal = exports.configurationGenerator = void 0;
 const devkit_1 = require("@nx/devkit");
 const init_1 = require("../init/init");
 const has_plugin_1 = require("../../utils/has-plugin");
 const add_build_target_defaults_1 = require("@nx/devkit/src/generators/add-build-target-defaults");
-async function configurationGenerator(tree, options) {
-    const task = await (0, init_1.webpackInitGenerator)(tree, {
+const ensure_dependencies_1 = require("../../utils/ensure-dependencies");
+function configurationGenerator(tree, options) {
+    return configurationGeneratorInternal(tree, { addPlugin: false, ...options });
+}
+exports.configurationGenerator = configurationGenerator;
+async function configurationGeneratorInternal(tree, options) {
+    const tasks = [];
+    options.addPlugin ??= process.env.NX_ADD_PLUGINS !== 'false';
+    const initTask = await (0, init_1.webpackInitGenerator)(tree, {
         ...options,
         skipFormat: true,
     });
+    tasks.push(initTask);
+    const depsTask = (0, ensure_dependencies_1.ensureDependencies)(tree, {
+        compiler: options.compiler === 'babel' ? undefined : options.compiler,
+    });
+    tasks.push(depsTask);
     checkForTargetConflicts(tree, options);
     if (!(0, has_plugin_1.hasPlugin)(tree)) {
         addBuildTarget(tree, options);
@@ -21,9 +33,9 @@ async function configurationGenerator(tree, options) {
     if (!options.skipFormat) {
         await (0, devkit_1.formatFiles)(tree);
     }
-    return task;
+    return (0, devkit_1.runTasksInSerial)(...tasks);
 }
-exports.configurationGenerator = configurationGenerator;
+exports.configurationGeneratorInternal = configurationGeneratorInternal;
 function checkForTargetConflicts(tree, options) {
     if (options.skipValidation)
         return;
@@ -49,10 +61,11 @@ function createWebpackConfig(tree, options) {
         tree.write((0, devkit_1.joinPathFragments)(project.root, 'webpack.config.js'), (0, has_plugin_1.hasPlugin)(tree)
             ? `
 const { NxWebpackPlugin } = require('@nx/webpack');
+const { join } = require('path');
 
 module.exports = {
   output: {
-    path: '${buildOptions.outputPath}',
+    path: join(__dirname, '${(0, devkit_1.offsetFromRoot)(project.root)}${buildOptions.outputPath}'),
   },
   plugins: [
     new NxWebpackPlugin({
@@ -60,6 +73,7 @@ module.exports = {
       tsConfig: '${buildOptions.tsConfig}',
       compiler: '${buildOptions.compiler}',
       main: '${buildOptions.main}',
+      outputHashing: '${buildOptions.target !== 'web' ? 'none' : 'all'}',
     })
   ],
 }
@@ -79,10 +93,11 @@ module.exports = composePlugins(withNx(), withWeb(), (config) => {
         tree.write((0, devkit_1.joinPathFragments)(project.root, 'webpack.config.js'), (0, has_plugin_1.hasPlugin)(tree)
             ? `
 const { NxWebpackPlugin } = require('@nx/webpack');
+const { join } = require('path');
 
 module.exports = {
   output: {
-    path: '${buildOptions.outputPath}',
+    path: join(__dirname, '${(0, devkit_1.offsetFromRoot)(project.root)}${buildOptions.outputPath}'),
   },
   plugins: [
     new NxWebpackPlugin({
@@ -90,6 +105,7 @@ module.exports = {
       tsConfig: '${buildOptions.tsConfig}',
       compiler: '${buildOptions.compiler}',
       main: '${buildOptions.main}',
+      outputHashing: '${buildOptions.target !== 'web' ? 'none' : 'all'}',
     })
   ],
 }

package/src/generators/configuration/schema.d.ts

@@ -10,4 +10,5 @@ export interface ConfigurationGeneratorSchema {
   target?: 'node' | 'web' | 'webworker';
   webpackConfig?: string;
   babelConfig?: string;
+  addPlugin?: boolean;
 }

package/src/generators/init/init.d.ts

@@ -1,4 +1,5 @@
 import { GeneratorCallback, Tree } from '@nx/devkit';
 import { Schema } from './schema';
 export declare function webpackInitGenerator(tree: Tree, schema: Schema): Promise<GeneratorCallback>;
+export declare function webpackInitGeneratorInternal(tree: Tree, schema: Schema): Promise<GeneratorCallback>;
 export default webpackInitGenerator;

package/src/generators/init/init.js

@@ -1,13 +1,17 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.webpackInitGenerator = void 0;
+exports.webpackInitGeneratorInternal = exports.webpackInitGenerator = void 0;
 const devkit_1 = require("@nx/devkit");
 const update_package_scripts_1 = require("@nx/devkit/src/utils/update-package-scripts");
 const plugin_1 = require("../../plugins/plugin");
 const versions_1 = require("../../utils/versions");
-async function webpackInitGenerator(tree, schema) {
-    const shouldAddPlugin = process.env.NX_PCV3 === 'true';
-    if (shouldAddPlugin) {
+function webpackInitGenerator(tree, schema) {
+    return webpackInitGeneratorInternal(tree, { addPlugin: false, ...schema });
+}
+exports.webpackInitGenerator = webpackInitGenerator;
+async function webpackInitGeneratorInternal(tree, schema) {
+    schema.addPlugin ??= process.env.NX_ADD_PLUGINS !== 'false';
+    if (schema.addPlugin) {
         addPlugin(tree);
     }
     let installTask = () => { };
@@ -16,7 +20,7 @@ async function webpackInitGenerator(tree, schema) {
             '@nx/webpack': versions_1.nxVersion,
             '@nx/web': versions_1.nxVersion,
         };
-        if (shouldAddPlugin) {
+        if (schema.addPlugin) {
             devDependencies['webpack-cli'] = versions_1.webpackCliVersion;
         }
         installTask = (0, devkit_1.addDependenciesToPackageJson)(tree, {}, devDependencies, undefined, schema.keepExistingVersions);
@@ -29,7 +33,7 @@ async function webpackInitGenerator(tree, schema) {
     }
     return installTask;
 }
-exports.webpackInitGenerator = webpackInitGenerator;
+exports.webpackInitGeneratorInternal = webpackInitGeneratorInternal;
 function addPlugin(tree) {
     const nxJson = (0, devkit_1.readNxJson)(tree);
     nxJson.plugins ??= [];

package/src/generators/init/schema.d.ts

@@ -3,4 +3,5 @@ export interface Schema {
   skipPackageJson?: boolean;
   keepExistingVersions?: boolean;
   updatePackageScripts?: boolean;
+  addPlugin?: boolean;
 }

package/src/plugins/nx-webpack-plugin/lib/compiler-loaders.js

@@ -46,7 +46,7 @@ function createLoaderFromCompiler(options) {
                 },
             };
         case 'babel':
-            const tsConfig = (0, js_1.readTsConfig)(options.tsConfig);
+            const tsConfig = (0, js_1.readTsConfig)(path.join(options.root, options.tsConfig));
             const babelConfig = {
                 test: /\.([jt])sx?$/,
                 loader: path.join(__dirname, '../../../utils/web-babel-loader'),

package/src/plugins/nx-webpack-plugin/lib/normalize-options.js

@@ -65,7 +65,7 @@ function normalizeOptions(options) {
         sourceMap: options.sourceMap ?? !isProd,
         sourceRoot,
         styles: options.styles ?? [],
-        target: options.target ?? 'web',
+        target: options.target,
         targetName,
         vendorChunk: options.vendorChunk ?? !isProd,
     };

package/src/plugins/plugin.js

@@ -57,9 +57,7 @@ exports.createNodes = [
 ];
 async function createWebpackTargets(configFilePath, projectRoot, options, context) {
     const namedInputs = (0, get_named_inputs_1.getNamedInputs)(projectRoot, context);
-    global.NX_GRAPH_CREATION = true;
     const webpackConfig = (0, resolve_user_defined_webpack_config_1.resolveUserDefinedWebpackConfig)((0, path_1.join)(context.workspaceRoot, configFilePath), (0, js_1.getRootTsConfigPath)(), true);
-    delete global.NX_GRAPH_CREATION;
     const webpackOptions = await (0, read_webpack_options_1.readWebpackOptions)(webpackConfig);
     const outputPath = normalizeOutputPath(webpackOptions.output?.path, projectRoot);
     const targets = {};

package/src/utils/with-nx.js

@@ -15,6 +15,7 @@ function withNx(pluginOptions = {}) {
         (0, apply_base_config_1.applyBaseConfig)({
             ...options,
             ...pluginOptions,
+            target: options.target ?? 'web',
             assets: options.assets
                 ? options.assets
                 : pluginOptions.assets