@nx/webpack 17.2.3 → 17.2.5

package/README.md

@@ -1,4 +1,9 @@
-<p style="text-align: center;"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx.png" width="600" alt="Nx - Smart, Fast and Extensible Build System"></p>
+<p style="text-align: center;">
+  <picture>
+    <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-dark.svg">
+    <img alt="Nx - Smart Monorepos · Fast CI" src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-light.svg" width="100%">
+  </picture>
+</p>
 
 <div style="text-align: center;">
 
@@ -15,9 +20,9 @@
 
 <hr>
 
-# Nx: Smart, Fast and Extensible Build System
+# Nx: Smart Monorepos · Fast CI
 
-Nx is a next generation build system with first class monorepo support and powerful integrations.
+Nx is a build system with built-in tooling and advanced CI capabilities. It helps you maintain and scale monorepos, both locally and on CI.
 
 This package is a [Webpack plugin for Nx](https://nx.dev/packages/webpack).
 
@@ -59,5 +64,5 @@ npx nx@latest init
 - [Blog Posts About Nx](https://blog.nrwl.io/nx/home)
 
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
-width="100%" alt="Nx - Smart, Fast and Extensible Build System"></a></p>
+width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/webpack",
-  "version": "17.2.3",
+  "version": "v17.2.5",
   "private": false,
   "description": "The Nx Plugin for Webpack contains executors and generators that support building applications using Webpack.",
   "repository": {
@@ -62,9 +62,9 @@
     "webpack-dev-server": "^4.9.3",
     "webpack-node-externals": "^3.0.0",
     "webpack-subresource-integrity": "^5.1.0",
-    "@nx/devkit": "17.2.3",
-    "@nx/js": "17.2.3",
-    "@nrwl/webpack": "17.2.3"
+    "@nx/devkit": "v17.2.5",
+    "@nx/js": "v17.2.5",
+    "@nrwl/webpack": "v17.2.5"
   },
   "publishConfig": {
     "access": "public"

package/src/executors/dev-server/dev-server.impl.js

@@ -37,8 +37,8 @@ async function* devServerExecutor(serveOptions, context) {
         // Only add the dev server option if user is composable plugin.
         // Otherwise, user should define `devServer` option directly in their webpack config.
         if (typeof userDefinedWebpackConfig === 'function' &&
-            (0, config_1.isNxWebpackComposablePlugin)(userDefinedWebpackConfig) &&
-            !buildOptions.standardWebpackConfigFunction) {
+            ((0, config_1.isNxWebpackComposablePlugin)(userDefinedWebpackConfig) ||
+                !buildOptions.standardWebpackConfigFunction)) {
             config = await userDefinedWebpackConfig({ devServer }, {
                 options: buildOptions,
                 context,

package/src/executors/webpack/webpack.impl.js

@@ -32,8 +32,8 @@ async function getWebpackConfigs(options, context) {
             ? (0, config_1.composePluginsSync)((0, with_nx_1.withNx)(options), (0, with_web_1.withWeb)(options))
             : (0, with_nx_1.withNx)(options))({}, { options, context });
     if (typeof userDefinedWebpackConfig === 'function' &&
-        (0, config_1.isNxWebpackComposablePlugin)(userDefinedWebpackConfig) &&
-        !options.standardWebpackConfigFunction) {
+        ((0, config_1.isNxWebpackComposablePlugin)(userDefinedWebpackConfig) ||
+            !options.standardWebpackConfigFunction)) {
         // Old behavior, call the Nx-specific webpack config function that user exports
         return await userDefinedWebpackConfig(config, {
             options,

package/src/utils/module-federation/remotes.js

@@ -39,7 +39,7 @@ function handleArrayRemote(remote, remoteEntryExt, isRemoteGlobal) {
         : '';
     // if the remote is defined with anything other than http then we assume it's a promise based remote
     // In that case we should use what the user provides as the remote location
-    if (remoteLocation.startsWith('http')) {
+    if (!remoteLocation.startsWith('promise new Promise')) {
         return `${globalPrefix}${baseRemote}/remoteEntry.${remoteEntryExt}`;
     }
     else {