@nx/webpack 0.0.0-pr-27957-a99d5ea → 0.0.0-pr-28229-afe192c

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/webpack",
-  "version": "0.0.0-pr-27957-a99d5ea",
+  "version": "0.0.0-pr-28229-afe192c",
   "private": false,
   "description": "The Nx Plugin for Webpack contains executors and generators that support building applications using Webpack.",
   "repository": {
@@ -69,13 +69,12 @@
     "webpack-dev-server": "^5.0.4",
     "webpack-node-externals": "^3.0.0",
     "webpack-subresource-integrity": "^5.1.0",
-    "@nx/devkit": "0.0.0-pr-27957-a99d5ea",
-    "@nx/js": "0.0.0-pr-27957-a99d5ea",
-    "@nrwl/webpack": "0.0.0-pr-27957-a99d5ea"
+    "@nx/devkit": "0.0.0-pr-28229-afe192c",
+    "@nx/js": "0.0.0-pr-28229-afe192c"
   },
   "publishConfig": {
     "access": "public"
   },
   "type": "commonjs",
   "types": "./index.d.ts"
-}
+}

package/src/plugins/webpack-nx-build-coordination-plugin.js

@@ -46,7 +46,9 @@ class WebpackNxBuildCoordinationPlugin {
         this.currentlyRunning = 'nx-build';
         try {
             return await new Promise((res) => {
-                this.buildCmdProcess = (0, child_process_1.exec)(this.buildCmd);
+                this.buildCmdProcess = (0, child_process_1.exec)(this.buildCmd, {
+                    windowsHide: true,
+                });
                 this.buildCmdProcess.stdout.pipe(process.stdout);
                 this.buildCmdProcess.stderr.pipe(process.stderr);
                 this.buildCmdProcess.on('exit', () => {

package/src/utils/module-federation/secondary-entry-points.js

@@ -76,6 +76,26 @@ function recursivelyCollectSecondaryEntryPointsFromDirectory(pkgName, pkgVersion
         recursivelyCollectSecondaryEntryPointsFromDirectory(pkgName, pkgVersion, pkgRoot, mainEntryPointExports, subDirs, collectedPackages);
     }
 }
+function collectPackagesFromExports(pkgName, pkgVersion, exports, collectedPackages) {
+    for (const [relativeEntryPoint, exportOptions] of Object.entries(exports)) {
+        const defaultExportOptions = typeof exportOptions?.['default'] === 'string'
+            ? exportOptions?.['default']
+            : exportOptions?.['default']?.['default'];
+        if (defaultExportOptions?.search(/\.(js|mjs|cjs)$/)) {
+            let entryPointName = (0, devkit_1.joinPathFragments)(pkgName, relativeEntryPoint);
+            if (entryPointName.endsWith('.json')) {
+                entryPointName = (0, path_1.dirname)(entryPointName);
+            }
+            if (entryPointName === '.') {
+                continue;
+            }
+            if (collectedPackages.find((p) => p.name === entryPointName)) {
+                continue;
+            }
+            collectedPackages.push({ name: entryPointName, version: pkgVersion });
+        }
+    }
+}
 function collectPackageSecondaryEntryPoints(pkgName, pkgVersion, collectedPackages) {
     let pathToPackage;
     let packageJsonPath;
@@ -97,6 +117,9 @@ function collectPackageSecondaryEntryPoints(pkgName, pkgVersion, collectedPackag
         packageJson = (0, devkit_1.readJsonFile)(packageJsonPath);
     }
     const { exports } = packageJson;
+    if (exports) {
+        collectPackagesFromExports(pkgName, pkgVersion, exports, collectedPackages);
+    }
     const subDirs = getNonNodeModulesSubDirs(pathToPackage);
     recursivelyCollectSecondaryEntryPointsFromDirectory(pkgName, pkgVersion, pathToPackage, exports, subDirs, collectedPackages);
 }

package/src/utils/module-federation/share.js

@@ -222,8 +222,12 @@ function addStringDependencyToSharedConfig(sharedConfig, dependency, projectGrap
         sharedConfig[dependency] = config;
     }
     else {
-        throw new Error(`The specified dependency "${dependency}" in the additionalShared configuration does not exist in the project graph. ` +
-            `Please check your additionalShared configuration and make sure you are including valid workspace projects or npm packages.`);
+        const pkgJsonPath = require.resolve(`${dependency}/package.json`);
+        if (!pkgJsonPath) {
+            throw new Error(`Could not find package ${dependency} when applying it as a shared package. Are you sure it has been installed?`);
+        }
+        const pkgJson = (0, devkit_1.readJsonFile)(pkgJsonPath);
+        const config = getNpmPackageSharedConfig(dependency, pkgJson.version);
     }
 }
 function getEmptySharedLibrariesConfig() {