@nx/storybook 23.3.0-beta.1 → 23.3.0-beta.3

package/dist/src/generators/configuration/configuration.js

@@ -3,6 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.configurationGenerator = configurationGenerator;
 exports.configurationGeneratorInternal = configurationGeneratorInternal;
 const devkit_1 = require("@nx/devkit");
+const internal_1 = require("@nx/devkit/internal");
+const semver_1 = require("semver");
 const js_1 = require("@nx/js");
 const init_1 = require("../init/init");
 const deprecation_1 = require("../../utils/deprecation");
@@ -12,7 +14,7 @@ const utilities_1 = require("../../utils/utilities");
 const versions_1 = require("../../utils/versions");
 const ensure_dependencies_1 = require("./lib/ensure-dependencies");
 const edit_root_tsconfig_1 = require("./lib/edit-root-tsconfig");
-const internal_1 = require("@nx/js/internal");
+const internal_2 = require("@nx/js/internal");
 function configurationGenerator(tree, schema) {
     return configurationGeneratorInternal(tree, { addPlugin: false, ...schema });
 }
@@ -62,7 +64,7 @@ async function configurationGeneratorInternal(tree, rawSchema) {
         ? p === '@nx/storybook/plugin'
         : p.plugin === '@nx/storybook/plugin');
     const mainDir = !!nextConfigFilePath &&
-        (0, internal_1.getProjectType)(tree, root, projectType) === 'application'
+        (0, internal_2.getProjectType)(tree, root, projectType) === 'application'
         ? 'components'
         : 'src';
     const usesVite = !!viteConfigFilePath || schema.uiFramework?.endsWith('-vite');
@@ -97,7 +99,19 @@ async function configurationGeneratorInternal(tree, rawSchema) {
         devDeps['storybook'] = (0, utilities_1.getStorybookVersionToInstall)(tree);
     }
     if (schema.interactionTests) {
-        devDeps['@storybook/test-runner'] = (0, versions_1.versions)(tree).testRunnerVersion;
+        const testRunnerVersion = (0, versions_1.versions)(tree).testRunnerVersion;
+        // @storybook/test-runner depends on @swc/core.
+        (0, internal_2.acknowledgeSwcBuildScripts)(tree);
+        if ((0, semver_1.gte)((0, semver_1.minVersion)(testRunnerVersion), '0.24.0')) {
+            // Only the 0.24 line runs on jest 30, whose jest-resolve depends on
+            // unrs-resolver and, from 30.5.0, pins a jest-haste-map that depends on
+            // @parcel/watcher. Storybook 8 and 9 select jest 29, which needs neither.
+            (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), {
+                '@parcel/watcher': false,
+                'unrs-resolver': false,
+            });
+        }
+        devDeps['@storybook/test-runner'] = testRunnerVersion;
     }
     if (schema.tsConfiguration) {
         devDeps['ts-node'] = versions_1.tsNodeVersion;
@@ -110,6 +124,10 @@ async function configurationGeneratorInternal(tree, rawSchema) {
     }
     if (projectType !== 'application' &&
         schema.uiFramework === '@storybook/react-webpack5') {
+        // core-js' install script only prints a funding message.
+        (0, internal_1.acknowledgeBuildScripts)(tree, (0, devkit_1.detectPackageManager)(tree.root), {
+            'core-js': false,
+        });
         devDeps['core-js'] = versions_1.coreJsVersion;
     }
     if (schema.uiFramework?.endsWith('-vite') && !viteConfigFilePath) {

package/dist/src/generators/init/init.js

@@ -16,6 +16,11 @@ function checkDependenciesInstalled(host, schema) {
     };
     const storybookVersionToInstall = (0, utilities_1.getStorybookVersionToInstall)(host);
     devDependencies['storybook'] = storybookVersionToInstall;
+    // storybook depends on esbuild, whose install script only validates the
+    // prebuilt binary that ships as an optional dependency.
+    (0, internal_1.acknowledgeBuildScripts)(host, (0, devkit_1.detectPackageManager)(host.root), {
+        esbuild: false,
+    });
     return (0, devkit_1.addDependenciesToPackageJson)(host, {}, devDependencies, undefined, schema.keepExistingVersions ?? true);
 }
 function addCacheableOperation(tree) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/storybook",
-  "version": "23.3.0-beta.1",
+  "version": "23.3.0-beta.3",
   "private": false,
   "type": "commonjs",
   "files": [
@@ -92,18 +92,18 @@
     "@phenomnomnominal/tsquery": "~6.2.0",
     "semver": "^7.6.3",
     "tslib": "^2.3.0",
-    "@nx/devkit": "23.3.0-beta.1",
-    "@nx/cypress": "23.3.0-beta.1",
-    "@nx/js": "23.3.0-beta.1",
-    "@nx/eslint": "23.3.0-beta.1"
+    "@nx/devkit": "23.3.0-beta.3",
+    "@nx/cypress": "23.3.0-beta.3",
+    "@nx/js": "23.3.0-beta.3",
+    "@nx/eslint": "23.3.0-beta.3"
   },
   "devDependencies": {
     "storybook": "9.0.6",
-    "nx": "23.3.0-beta.1"
+    "nx": "23.3.0-beta.3"
   },
   "peerDependencies": {
     "storybook": ">=8.0.0 <11.0.0",
-    "@nx/web": "23.3.0-beta.1"
+    "@nx/web": "23.3.0-beta.3"
   },
   "peerDependenciesMeta": {
     "@nx/web": {