@nx/rspack 20.7.0 → 20.7.1

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/rspack",
   "description": "The Nx Plugin for Rspack contains executors and generators that support building applications using Rspack.",
-  "version": "20.7.0",
+  "version": "20.7.1",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -24,10 +24,10 @@
   "generators": "./generators.json",
   "executors": "./executors.json",
   "dependencies": {
-    "@nx/js": "20.7.0",
-    "@nx/devkit": "20.7.0",
-    "@nx/web": "20.7.0",
-    "@nx/module-federation": "20.7.0",
+    "@nx/js": "20.7.1",
+    "@nx/devkit": "20.7.1",
+    "@nx/web": "20.7.1",
+    "@nx/module-federation": "20.7.1",
     "@phenomnomnominal/tsquery": "~5.0.1",
     "@rspack/core": "^1.1.5",
     "@rspack/dev-server": "^1.0.9",

package/src/executors/dev-server/lib/get-dev-server-config.js

@@ -31,8 +31,7 @@ function getDevServerOptions(root, serveOptions, buildOptions) {
             htmlAcceptHeaders: ['text/html', 'application/xhtml+xml'],
         },
         onListening(server) {
-            const isHttps = server.options.https ||
-                server.options.server?.type === 'https';
+            const isHttps = server.options.server?.type === 'https';
             devkit_1.logger.info(`NX Web Development Server is listening at ${isHttps ? 'https' : 'http'}://${server.options.host}:${server.options.port}${(0, serve_path_1.buildServePath)(buildOptions)}`);
         },
         open: false,

package/src/plugins/nx-app-rspack-plugin/nx-app-rspack-plugin.js

@@ -33,6 +33,10 @@ class NxAppRspackPlugin {
             Object.keys(compiler.options.entry['main']).length === 0) {
             compiler.options.entry = {};
         }
+        // Prefer `clean` option from Rspack config over our own.
+        if (typeof compiler.options.output.clean !== 'undefined') {
+            this.options.deleteOutputPath = false;
+        }
         (0, apply_base_config_1.applyBaseConfig)(this.options, compiler.options, {
             useNormalizedEntry: true,
         });

package/src/plugins/utils/apply-base-config.js

@@ -88,7 +88,7 @@ function applyNxIndependentConfig(options, config) {
         hashFunction: config.output?.hashFunction ?? 'xxhash64',
         // Disabled for performance
         pathinfo: config.output?.pathinfo ?? false,
-        clean: options.deleteOutputPath,
+        clean: config.output?.clean ?? options.deleteOutputPath,
     };
     config.watch = options.watch;
     config.watchOptions = {
@@ -184,8 +184,11 @@ function applyNxDependentConfig(options, config, { useNormalizedEntry } = {}) {
     if (options.useTsconfigPaths) {
         plugins.push(new nx_tsconfig_paths_rspack_plugin_1.NxTsconfigPathsRspackPlugin({ ...options, tsConfig }));
     }
-    // New TS Solution already has a typecheck target
-    if (!options?.skipTypeChecking && !isUsingTsSolution) {
+    // New TS Solution already has a typecheck target but allow it to run during serve
+    if ((!options?.skipTypeChecking && !isUsingTsSolution) ||
+        (isUsingTsSolution &&
+            options?.skipTypeChecking === false &&
+            process.env['WEBPACK_SERVE'])) {
         const { TsCheckerRspackPlugin } = require('ts-checker-rspack-plugin');
         plugins.push(new TsCheckerRspackPlugin({
             typescript: {

package/src/plugins/utils/models.d.ts

@@ -63,6 +63,7 @@ export interface NxAppRspackPluginOptions {
     commonChunk?: boolean;
     /**
      * Delete the output path before building.
+     * @deprecated Use the `output.clean` option in Rspack. https://rspack.dev/config/output#outputclean
      */
     deleteOutputPath?: boolean;
     /**