@nx/rspack 20.0.1 → 20.0.3

package/README.md

@@ -66,52 +66,3 @@ npx nx@latest init
 <p style="text-align: center;"><a href="https://nx.dev/#learning-materials" target="_blank" rel="noreferrer"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx-courses-and-videos.svg" 
 width="100%" alt="Nx - Smart Monorepos · Fast CI"></a></p>
 
-
-<p style="text-align: center;"><img src="https://raw.githubusercontent.com/nrwl/nx/master/images/nx.png" width="600" alt="Nx - Smart, Fast and Extensible Build System"></p>
-
-<hr>
-
-# Nx: Smart, Fast and Extensible Build System
-
-Nx is a next generation build system with first class monorepo support and powerful integrations.
-
-This package is a Rspack plugin for Nx.
-
-## Getting Started
-
-Use `--preset=@nx/rspack` when creating new workspace.
-
-e.g.
-
-```bash
-npx create-nx-workspace@latest rspack-demo --preset=@nx/rspack
-```
-
-Now, you can go into the `rspack-demo` folder and start development.
-
-```bash
-cd rspack-demo
-npm start
-```
-
-You can also run lint, test, and e2e scripts for the project.
-
-```bash
-npm run lint
-npm run test
-npm run e2e
-```
-
-## Existing workspaces
-
-You can add Rspack to any existing Nx workspace.
-
-First, install the plugin:
-
-```bash
-npm install --save-dev @nx/rspack
-```
-
-Then, r
-
-**Note:** You must restart the server if you make any changes to your library.

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/rspack",
   "description": "The Nx Plugin for Rspack contains executors and generators that support building applications using Rspack.",
-  "version": "20.0.1",
+  "version": "20.0.3",
   "type": "commonjs",
   "repository": {
     "type": "git",
@@ -24,19 +24,25 @@
   "generators": "./generators.json",
   "executors": "./executors.json",
   "dependencies": {
-    "@nx/js": "20.0.1",
-    "@nx/devkit": "20.0.1",
-    "@nx/eslint": "20.0.1",
+    "@nx/js": "20.0.3",
+    "@nx/devkit": "20.0.3",
+    "@nx/web": "20.0.3",
     "@phenomnomnominal/tsquery": "~5.0.1",
+    "enquirer": "~2.3.6",
+    "express": "^4.19.2",
+    "http-proxy-middleware": "^3.0.0",
     "less-loader": "11.1.0",
     "license-webpack-plugin": "^4.0.2",
     "sass-loader": "^12.2.0",
     "stylus-loader": "^7.1.0",
     "postcss-loader": "^8.1.1",
     "@rspack/core": "^1.0.4",
+    "@rspack/dev-server": "^1.0.4",
     "@rspack/plugin-react-refresh": "^1.0.0",
-    "@rspack/plugin-minify": "^0.7.5",
-    "chalk": "~4.1.0"
+    "chalk": "~4.1.0",
+    "tsconfig-paths": "^4.1.2",
+    "tslib": "^2.3.0",
+    "webpack-sources": "^3.2.3"
   },
   "peerDependencies": {
     "@module-federation/enhanced": "~0.6.0",

package/src/executors/dev-server/dev-server.impl.js

@@ -24,9 +24,8 @@ async function* runExecutor(options, context) {
     devServerConfig = {
         ...devServerConfig,
         ...firstCompiler.options.devServer,
-        port: devServerConfig.port,
     };
-    const baseUrl = `http://localhost:${options.port ?? 4200}`;
+    const baseUrl = `http://localhost:${devServerConfig.port ?? 4200}`;
     return yield* (0, async_iterable_1.createAsyncIterable)(({ next }) => {
         const server = new dev_server_1.RspackDevServer({
             ...devServerConfig,

package/src/executors/module-federation-dev-server/module-federation-dev-server.impl.js

@@ -131,8 +131,8 @@ async function* moduleFederationDevServer(options, context) {
     options.staticRemotesPort ??= remotes.staticRemotePort;
     // Set NX_MF_DEV_REMOTES for the Nx Runtime Library Control Plugin
     process.env.NX_MF_DEV_REMOTES = JSON.stringify([
-        ...(remotes.devRemotes.map((r) => typeof r === 'string' ? r : r.remoteName) ?? []),
-        p.name,
+        ...(remotes.devRemotes.map((r) => typeof r === 'string' ? r : r.remoteName) ?? []).map((r) => r.replace(/-/g, '_')),
+        p.name.replace(/-/g, '_'),
     ]);
     const staticRemotesConfig = (0, parse_static_remotes_config_1.parseStaticRemotesConfig)([...remotes.staticRemotes, ...remotes.dynamicRemotes], context);
     const mappedLocationsOfStaticRemotes = await (0, build_static_remotes_1.buildStaticRemotes)(staticRemotesConfig, nxBin, context, options);

package/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.js

@@ -168,8 +168,8 @@ async function* moduleFederationSsrDevServer(ssrDevServerOptions, context) {
     }, pathToManifestFile);
     options.staticRemotesPort ??= remotes.staticRemotePort;
     process.env.NX_MF_DEV_REMOTES = JSON.stringify([
-        ...(remotes.devRemotes.map((r) => typeof r === 'string' ? r : r.remoteName) ?? []),
-        projectConfig.name,
+        ...(remotes.devRemotes.map((r) => typeof r === 'string' ? r : r.remoteName) ?? []).map((r) => r.replace(/-/g, '_')),
+        projectConfig.name.replace(/-/g, '_'),
     ]);
     const staticRemotesConfig = (0, parse_static_remotes_config_1.parseStaticSsrRemotesConfig)([...remotes.staticRemotes, ...remotes.dynamicRemotes], context);
     const mappedLocationsOfStaticRemotes = await buildSsrStaticRemotes(staticRemotesConfig, nxBin, context, options);

package/src/utils/resolve-user-defined-rspack-config.js

@@ -23,7 +23,7 @@ reload = false) {
     const maybeCustomRspackConfig = require(path);
     cleanupTranspiler();
     // If the user provides a configuration in TS file
-    // then there are 3 cases for exporing an object. The first one is:
+    // then there are 3 cases for exploring an object. The first one is:
     // `module.exports = { ... }`. And the second one is:
     // `export default { ... }`. The ESM format is compiled into:
     // `{ default: { ... } }`

package/src/utils/with-web.js

@@ -97,8 +97,8 @@ function withWeb(opts = {}) {
                         ? path.join(context.root, options.indexHtml)
                         : path.join(projectRoot, 'src/index.html'),
                 }),
-                new core_1.rspack.DefinePlugin({
-                    'process.env.NODE_ENV': isProd ? "'production'" : "'development'",
+                new core_1.rspack.EnvironmentPlugin({
+                    NODE_ENV: 'development',
                 }),
             ],
         };