@nx/rsbuild 20.4.0 → 20.4.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@nx/rsbuild",
   "description": "The Nx Plugin for Rsbuild contains an Nx plugin, executors and utilities that support building applications using Rsbuild.",
-  "version": "20.4.0",
+  "version": "20.4.2",
   "type": "commonjs",
   "publishConfig": {
     "access": "public"
@@ -30,8 +30,8 @@
   "executors": "./executors.json",
   "dependencies": {
     "tslib": "^2.3.0",
-    "@nx/devkit": "20.4.0",
-    "@nx/js": "20.4.0",
+    "@nx/devkit": "20.4.2",
+    "@nx/js": "20.4.2",
     "@rsbuild/core": "1.1.8",
     "minimatch": "9.0.3",
     "@phenomnomnominal/tsquery": "~5.0.1"

package/src/plugins/plugin.js

@@ -46,7 +46,7 @@ async function createNodesInternal(configFilePath, options, context, targetsCach
     }
     const tsConfigFiles = siblingFiles.filter((p) => (0, minimatch_1.minimatch)(p, 'tsconfig*{.json,.*.json}')) ?? [];
     const normalizedOptions = normalizeOptions(options);
-    const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, normalizedOptions, context, [(0, js_1.getLockFileName)((0, devkit_1.detectPackageManager)(context.workspaceRoot))]);
+    const hash = await (0, calculate_hash_for_create_nodes_1.calculateHashForCreateNodes)(projectRoot, { ...normalizedOptions, isUsingTsSolutionSetup }, context, [(0, js_1.getLockFileName)((0, devkit_1.detectPackageManager)(context.workspaceRoot))]);
     targetsCache[hash] ??= await createRsbuildTargets(configFilePath, projectRoot, normalizedOptions, tsConfigFiles, isUsingTsSolutionSetup, context);
     const { targets, metadata } = targetsCache[hash];
     return {
@@ -129,21 +129,30 @@ async function createRsbuildTargets(configFilePath, projectRoot, options, tsConf
                 { externalDependencies: ['typescript'] },
             ],
             command: isUsingTsSolutionSetup
-                ? `tsc --build --emitDeclarationOnly --pretty --verbose`
-                : `tsc --noEmit -p ${tsConfigToUse}`,
+                ? `tsc --build --emitDeclarationOnly`
+                : `tsc -p ${tsConfigToUse} --noEmit`,
             options: { cwd: (0, devkit_1.joinPathFragments)(projectRoot) },
             metadata: {
-                description: `Run Typechecking`,
+                description: `Runs type-checking for the project.`,
+                technologies: ['typescript'],
                 help: {
-                    command: `${pmc.exec} tsc --help -p ${tsConfigToUse}`,
-                    example: {
-                        options: {
-                            noEmit: true,
-                        },
-                    },
+                    command: isUsingTsSolutionSetup
+                        ? `${pmc.exec} tsc --build --help`
+                        : `${pmc.exec} tsc -p ${tsConfigToUse} --help`,
+                    example: isUsingTsSolutionSetup
+                        ? { args: ['--force'] }
+                        : { options: { noEmit: true } },
                 },
             },
         };
+        if (isUsingTsSolutionSetup) {
+            targets[options.typecheckTargetName].dependsOn = [
+                `^${options.typecheckTargetName}`,
+            ];
+            targets[options.typecheckTargetName].syncGenerators = [
+                '@nx/js:typescript-sync',
+            ];
+        }
     }
     (0, util_1.addBuildAndWatchDepsTargets)(context.workspaceRoot, projectRoot, targets, options, pmc);
     return { targets, metadata: {} };