@nx/rollup 0.0.0-pr-30457-2f25946 → 0.0.0-pr-3-49a51e7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/rollup",
-  "version": "0.0.0-pr-30457-2f25946",
+  "version": "0.0.0-pr-3-49a51e7",
   "private": false,
   "description": "The Nx Plugin for Rollup contains executors and generators that support building applications using Rollup.",
   "repository": {
@@ -29,8 +29,8 @@
     "migrations": "./migrations.json"
   },
   "dependencies": {
-    "@nx/devkit": "0.0.0-pr-30457-2f25946",
-    "@nx/js": "0.0.0-pr-30457-2f25946",
+    "@nx/devkit": "0.0.0-pr-3-49a51e7",
+    "@nx/js": "0.0.0-pr-3-49a51e7",
     "@rollup/plugin-babel": "^6.0.4",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-image": "^3.0.3",

package/src/executors/rollup/schema.d.ts

@@ -15,23 +15,22 @@ export interface Globals {
 export interface RollupExecutorOptions {
   outputPath: string;
   tsConfig: string;
-  main: string;
-  additionalEntryPoints?: string[];
   allowJs?: boolean;
+  project: string;
+  main: string;
+  outputFileName?: string;
+  extractCss?: boolean | string;
+  external?: string[] | 'all' | 'none';
+  rollupConfig?: string | string[];
+  watch?: boolean;
   assets?: any[];
-  babelUpwardRootMode?: boolean;
-  buildLibsFromSource?: boolean;
-  compiler?: 'babel' | 'tsc' | 'swc';
   deleteOutputPath?: boolean;
-  external?: string[] | 'all' | 'none';
-  extractCss?: boolean | string;
   format?: ('cjs' | 'esm')[];
-  generateExportsField?: boolean;
+  compiler?: 'babel' | 'tsc' | 'swc';
   javascriptEnabled?: boolean;
-  project?: string;
-  outputFileName?: string;
-  rollupConfig?: string | string[];
+  generateExportsField?: boolean;
+  additionalEntryPoints?: string[];
   skipTypeCheck?: boolean;
+  babelUpwardRootMode?: boolean;
   skipTypeField?: boolean;
-  watch?: boolean;
 }

package/src/executors/rollup/schema.json

@@ -1,14 +1,15 @@
 {
   "version": 2,
   "outputCapture": "direct-nodejs",
-  "title": "Web Library Rollup Target",
+  "title": "Web Library Rollup Target (Experimental)",
   "description": "Packages a library for different web usages (ESM, CommonJS).",
   "cli": "nx",
   "type": "object",
   "properties": {
     "project": {
       "type": "string",
-      "description": "The path to package.json file."
+      "description": "The path to package.json file.",
+      "x-priority": "important"
     },
     "main": {
       "type": "string",
@@ -137,11 +138,6 @@
       },
       "x-priority": "important"
     },
-    "buildLibsFromSource": {
-      "type": "boolean",
-      "description": "Read buildable libraries from source instead of building them separately.",
-      "default": true
-    },
     "skipTypeCheck": {
       "type": "boolean",
       "description": "Whether to skip TypeScript type checking.",

package/src/generators/configuration/configuration.js

@@ -122,8 +122,6 @@ function updatePackageJson(tree, options, outputConfig, isTsSolutionSetup) {
                 : undefined) ?? nxJson.targetDefaults?.[options.buildTarget]);
             ({ main, outputPath } = mergedTarget.options);
         }
-        // the file must exist in the TS solution setup
-        const tsconfigBase = (0, devkit_1.readJson)(tree, 'tsconfig.base.json');
         packageJson = (0, js_1.getUpdatedPackageJsonContent)(packageJson, {
             main,
             outputPath,
@@ -134,7 +132,6 @@ function updatePackageJson(tree, options, outputConfig, isTsSolutionSetup) {
             format: options.format ?? ['esm'],
             outputFileExtensionForCjs: '.cjs.js',
             outputFileExtensionForEsm: '.esm.js',
-            skipDevelopmentExports: !tsconfigBase.compilerOptions?.customConditions?.includes('development'),
         });
         // rollup has a specific declaration file generation not handled by the util above,
         // adjust accordingly

package/src/plugins/with-nx/with-nx-options.d.ts

@@ -15,10 +15,6 @@ export interface RollupWithNxPluginOptions {
      * Whether to set rootmode to upward. See https://babeljs.io/docs/en/options#rootmode
      */
     babelUpwardRootMode?: boolean;
-    /**
-     * Build the libraries from source. Default is `true`.
-     */
-    buildLibsFromSource?: boolean;
     /**
      * Which compiler to use.
      */

package/src/plugins/with-nx/with-nx.js

@@ -43,9 +43,7 @@ dependencies) {
     const options = (0, normalize_options_1.normalizeOptions)(projectNode.data.root, projectNode.data.sourceRoot, rawOptions);
     const useBabel = options.compiler === 'babel';
     const useSwc = options.compiler === 'swc';
-    const tsConfigPath = options.buildLibsFromSource || global.NX_GRAPH_CREATION
-        ? (0, devkit_1.joinPathFragments)(devkit_1.workspaceRoot, options.tsConfig)
-        : (0, buildable_libs_utils_1.createTmpTsConfig)(options.tsConfig, devkit_1.workspaceRoot, projectRoot, dependencies);
+    const tsConfigPath = (0, devkit_1.joinPathFragments)(devkit_1.workspaceRoot, options.tsConfig);
     const tsConfigFile = ts.readConfigFile(tsConfigPath, ts.sys.readFile);
     const tsConfig = ts.parseJsonConfigFileContent(tsConfigFile.config, ts.sys, (0, node_path_1.dirname)(tsConfigPath));
     if (!options.format || !options.format.length) {
@@ -143,7 +141,7 @@ dependencies) {
             // Needed to generate type definitions, even if we're using babel or swc.
             require('rollup-plugin-typescript2')({
                 check: !options.skipTypeCheck,
-                tsconfig: tsConfigPath,
+                tsconfig: options.tsConfig,
                 tsconfigOverride: {
                     compilerOptions: createTsCompilerOptions(projectRoot, tsConfig, options, dependencies),
                 },