@nx/remix 24.0.0-beta.2 → 24.0.0-beta.3

package/dist/src/generators/convert-to-inferred/convert-to-inferred.js

@@ -18,7 +18,6 @@ async function convertToInferred(tree, options) {
         devTargetName: 'dev',
         startTargetName: 'start',
         serveStaticTargetName: 'serve-static',
-        typecheckTargetName: 'typecheck',
     }, [
         {
             executors: ['@nx/remix:build'],

package/dist/src/migrations/update-24-0-0/register-typescript-plugin-for-typecheck.d.ts

@@ -0,0 +1,4 @@
+import { type Tree } from '@nx/devkit';
+export default function update(tree: Tree): Promise<{
+    skipAgentic: boolean;
+}>;

package/dist/src/migrations/update-24-0-0/register-typescript-plugin-for-typecheck.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = update;
+const devkit_1 = require("@nx/devkit");
+const internal_1 = require("@nx/js/internal");
+async function update(tree) {
+    if (!(0, internal_1.registerTypescriptPluginForTypecheck)(tree, '@nx/remix/plugin', {
+        removeTypecheckTargetName: true,
+    })) {
+        return { skipAgentic: true };
+    }
+    await (0, devkit_1.formatFiles)(tree);
+}

package/dist/src/migrations/update-24-0-0/register-typescript-plugin-for-typecheck.md

@@ -0,0 +1,40 @@
+#### Register `@nx/js/typescript` for typecheck targets
+
+`@nx/remix/plugin` no longer infers a `typecheck` target in any setup, and `@nx/js/typescript` provides it instead. This migration registers `@nx/js/typescript` with only its typecheck target when the workspace uses `@nx/remix/plugin` and doesn't register `@nx/js/typescript` yet, so your projects keep a `typecheck` target.
+
+The new registration is added before the framework plugin and reuses its `typecheckTargetName`, and the migration then removes that option from `@nx/remix/plugin`. Registrations with `typecheckTargetName: false` have the option removed without registering `@nx/js/typescript`.
+
+#### Sample code changes
+
+##### Before
+
+```json title="nx.json"
+{
+  "plugins": [
+    {
+      "plugin": "@nx/remix/plugin",
+      "options": {
+        "buildTargetName": "build",
+        "typecheckTargetName": "typecheck"
+      }
+    }
+  ]
+}
+```
+
+##### After
+
+```json title="nx.json"
+{
+  "plugins": [
+    {
+      "plugin": "@nx/js/typescript",
+      "options": { "typecheck": { "targetName": "typecheck" } }
+    },
+    {
+      "plugin": "@nx/remix/plugin",
+      "options": { "buildTargetName": "build" }
+    }
+  ]
+}
+```

package/dist/src/plugins/plugin.d.ts

@@ -3,7 +3,6 @@ export interface RemixPluginOptions {
     buildTargetName?: string;
     devTargetName?: string;
     startTargetName?: string;
-    typecheckTargetName?: string;
     buildDepsTargetName?: string;
     watchDepsTargetName?: string;
     serveStaticTargetName?: string;

package/dist/src/plugins/plugin.js

@@ -31,7 +31,7 @@ exports.createNodes = [
             let results = [];
             let nodeErrors = [];
             try {
-                results = await (0, devkit_1.createNodesFromFiles)((configFile, _, ctx, idx) => createNodesInternal(configFile, normalizedOptions, ctx, targetsCache, isUsingTsSolutionSetup, pmc, entries[idx].siblingFiles, entries[idx].remixCompiler, projectHashes[idx] + configFile), entries.map((e) => e.configFile), options, context);
+                results = await (0, devkit_1.createNodesFromFiles)((configFile, _, ctx, idx) => createNodesInternal(configFile, normalizedOptions, ctx, targetsCache, isUsingTsSolutionSetup, pmc, entries[idx].remixCompiler, projectHashes[idx] + configFile), entries.map((e) => e.configFile), options, context);
             }
             catch (e) {
                 if (e instanceof devkit_1.AggregateCreateNodesError) {
@@ -57,10 +57,10 @@ exports.createNodes = [
  * @deprecated Migrate to React Router with `@nx/react`. This will be removed in Nx 25.
  */
 exports.createNodesV2 = exports.createNodes;
-async function createNodesInternal(configFilePath, options, context, targetsCache, isUsingTsSolutionSetup, pmc, siblingFiles, remixCompiler, hash) {
+async function createNodesInternal(configFilePath, options, context, targetsCache, isUsingTsSolutionSetup, pmc, remixCompiler, hash) {
     const projectRoot = (0, path_1.dirname)(configFilePath);
     if (!targetsCache.has(hash)) {
-        targetsCache.set(hash, await buildRemixTargets(configFilePath, projectRoot, options, context, siblingFiles, remixCompiler, isUsingTsSolutionSetup, pmc));
+        targetsCache.set(hash, await buildRemixTargets(configFilePath, projectRoot, options, context, remixCompiler, isUsingTsSolutionSetup, pmc));
     }
     const { targets, metadata } = targetsCache.get(hash);
     const project = {
@@ -74,7 +74,7 @@ async function createNodesInternal(configFilePath, options, context, targetsCach
         },
     };
 }
-async function buildRemixTargets(configFilePath, projectRoot, options, context, siblingFiles, remixCompiler, isUsingTsSolutionSetup, pmc) {
+async function buildRemixTargets(configFilePath, projectRoot, options, context, remixCompiler, isUsingTsSolutionSetup, pmc) {
     const namedInputs = (0, internal_1.getNamedInputs)(projectRoot, context);
     const { buildDirectory, assetsBuildDirectory, serverBuildPath } = await getBuildPaths(configFilePath, projectRoot, context.workspaceRoot, remixCompiler);
     const targets = {};
@@ -82,7 +82,6 @@ async function buildRemixTargets(configFilePath, projectRoot, options, context,
     targets[options.devTargetName] = devTarget(serverBuildPath, projectRoot, remixCompiler, namedInputs, isUsingTsSolutionSetup);
     targets[options.startTargetName] = startTarget(projectRoot, serverBuildPath, options.buildTargetName, remixCompiler, namedInputs, isUsingTsSolutionSetup);
     targets[options.serveStaticTargetName] = startTarget(projectRoot, serverBuildPath, options.buildTargetName, remixCompiler, namedInputs, isUsingTsSolutionSetup);
-    targets[options.typecheckTargetName] = typecheckTarget(options.typecheckTargetName, projectRoot, namedInputs, siblingFiles, isUsingTsSolutionSetup, pmc);
     (0, internal_2.addBuildAndWatchDepsTargets)(context.workspaceRoot, projectRoot, targets, options, pmc);
     return { targets, metadata: {} };
 }
@@ -158,41 +157,6 @@ function startTarget(projectRoot, serverBuildPath, buildTargetName, remixCompile
     }
     return startTarget;
 }
-function typecheckTarget(typecheckTargetName, projectRoot, namedInputs, siblingFiles, isUsingTsSolutionSetup, pmc) {
-    const hasTsConfigAppJson = siblingFiles.includes('tsconfig.app.json');
-    const typecheckTarget = {
-        cache: true,
-        inputs: [
-            ...('production' in namedInputs
-                ? ['production', '^production']
-                : ['default', '^default']),
-            { externalDependencies: ['typescript'] },
-        ],
-        command: isUsingTsSolutionSetup
-            ? `tsc --build --emitDeclarationOnly`
-            : `tsc${hasTsConfigAppJson ? ` -p tsconfig.app.json` : ``} --noEmit`,
-        options: {
-            cwd: projectRoot,
-        },
-        metadata: {
-            description: `Runs type-checking for the project.`,
-            technologies: ['typescript'],
-            help: {
-                command: isUsingTsSolutionSetup
-                    ? `${pmc.exec} tsc --build --help`
-                    : `${pmc.exec} tsc${hasTsConfigAppJson ? ` -p tsconfig.app.json` : ``} --help`,
-                example: isUsingTsSolutionSetup
-                    ? { args: ['--force'] }
-                    : { options: { noEmit: true } },
-            },
-        },
-    };
-    if (isUsingTsSolutionSetup) {
-        typecheckTarget.dependsOn = [`^${typecheckTargetName}`];
-        typecheckTarget.syncGenerators = ['@nx/js:typescript-sync'];
-    }
-    return typecheckTarget;
-}
 async function getBuildPaths(configFilePath, projectRoot, workspaceRoot, remixCompiler) {
     const configPath = (0, path_1.join)(workspaceRoot, configFilePath);
     if (remixCompiler === RemixCompiler.IsClassic) {
@@ -232,7 +196,6 @@ function normalizeOptions(options) {
     options.buildTargetName ??= 'build';
     options.devTargetName ??= 'dev';
     options.startTargetName ??= 'start';
-    options.typecheckTargetName ??= 'typecheck';
     options.serveStaticTargetName ??= 'serve-static';
     return options;
 }
@@ -272,7 +235,7 @@ async function filterRemixConfigs(configFilePaths, context) {
             if (remixCompiler === RemixCompiler.IsNotRemix) {
                 return null;
             }
-            return { configFile, projectRoot, siblingFiles, remixCompiler };
+            return { configFile, projectRoot, remixCompiler };
         }
         catch (e) {
             preErrors.push([configFile, e]);

package/migrations.json

@@ -20,6 +20,12 @@
       "version": "24.0.0-beta.0",
       "description": "Migrate Remix v2 applications to React Router v7 with @nx/react, including Nx configuration and validation.",
       "prompt": "./dist/src/migrations/update-24-0-0/migrate-to-react-router.md"
+    },
+    "update-24-0-0-register-typescript-plugin-for-typecheck": {
+      "version": "24.0.0-beta.3",
+      "description": "Register @nx/js/typescript with its typecheck target in workspaces that use @nx/remix/plugin without it, and remove the typecheckTargetName option from @nx/remix/plugin, since @nx/remix/plugin no longer infers typecheck targets.",
+      "implementation": "./dist/src/migrations/update-24-0-0/register-typescript-plugin-for-typecheck",
+      "documentation": "./dist/src/migrations/update-24-0-0/register-typescript-plugin-for-typecheck.md"
     }
   },
   "packageJsonUpdates": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/remix",
-  "version": "24.0.0-beta.2",
+  "version": "24.0.0-beta.3",
   "description": "Deprecated Remix v2 task inference for Nx. Generators and executors were removed in Nx 24, except convert-to-inferred. The remaining plugin will be removed in Nx 25. Migrate to React Router with @nx/react.",
   "repository": {
     "type": "git",
@@ -52,16 +52,16 @@
     "supportsOptionalMigrations": true
   },
   "dependencies": {
-    "@nx/devkit": "24.0.0-beta.2",
-    "@nx/js": "24.0.0-beta.2",
+    "@nx/devkit": "24.0.0-beta.3",
+    "@nx/js": "24.0.0-beta.3",
     "tslib": "^2.3.0"
   },
   "devDependencies": {
-    "@nx/eslint": "24.0.0-beta.2",
-    "nx": "24.0.0-beta.2"
+    "@nx/eslint": "24.0.0-beta.3",
+    "nx": "24.0.0-beta.3"
   },
   "peerDependencies": {
-    "@nx/cypress": "24.0.0-beta.2",
+    "@nx/cypress": "24.0.0-beta.3",
     "@remix-run/dev": "^2.0.0"
   },
   "peerDependenciesMeta": {